| Message ID | 20230519104359.2048821-12-lukma@denx.de |
|---|---|
| State | Accepted |
| Commit | a21789194873d768ba829eb0169c7f0e3ceb85ef |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | arm: xea: Update i.MX28 XEA board to use DM_SERIAL | expand |
> Before this change the FR_TXFF (Transmit FIFO full) bit (5 in > HW_UARTDBG_FR) has been used to assess if there is still data pending > to be sent via UART. > This approach is problematic, as it may happen that serial is in the > middle of transmission (so the TX FIFO is NOT full anymore) and this > test returns true infinitely. As a result, for example in _serial_flush() > DM serial function we are locked in endless while(). > The fix here is to test explicitly if the TX FIFO is empty. > Signed-off-by: Lukasz Majewski <lukma@denx.de> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/drivers/serial/serial_pl01x.c b/drivers/serial/serial_pl01x.c index dbf2b2df34..428a4d210d 100644 --- a/drivers/serial/serial_pl01x.c +++ b/drivers/serial/serial_pl01x.c @@ -329,7 +329,7 @@ int pl01x_serial_pending(struct udevice *dev, bool input) if (input) return pl01x_tstc(priv->regs); else - return fr & UART_PL01x_FR_TXFF ? 0 : 1; + return fr & UART_PL01x_FR_TXFE ? 0 : 1; } static const struct dm_serial_ops pl01x_serial_ops = {
Before this change the FR_TXFF (Transmit FIFO full) bit (5 in HW_UARTDBG_FR) has been used to assess if there is still data pending to be sent via UART. This approach is problematic, as it may happen that serial is in the middle of transmission (so the TX FIFO is NOT full anymore) and this test returns true infinitely. As a result, for example in _serial_flush() DM serial function we are locked in endless while(). The fix here is to test explicitly if the TX FIFO is empty. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- drivers/serial/serial_pl01x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)