| Message ID | 20230428075336.135516-3-n-jain1@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Update env support for Am62x | expand |
On 4/28/2023 1:23 PM, Nikhil M Jain wrote: > Remove the earlycon settings from args_all. > Could you explain why is it okay to drop earlycon? Note, earlycon helps us to debug kernel crashes "before" kernel initializes UART driver ... Its very useful to have it on by default Regards Vignesh > Signed-off-by: Nikhil M Jain <n-jain1@ti.com> > --- > board/ti/am62x/am62x.env | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/board/ti/am62x/am62x.env b/board/ti/am62x/am62x.env > index e4e64fa637..cdd30b08ed 100644 > --- a/board/ti/am62x/am62x.env > +++ b/board/ti/am62x/am62x.env > @@ -7,8 +7,7 @@ findfdt= > setenv fdtfile ${name_fdt} > name_kern=Image > console=ttyS2,115200n8 > -args_all=setenv optargs ${optargs} earlycon=ns16550a,mmio32,0x02800000 > - ${mtdparts} > +args_all=setenv optargs ${optargs} ${mtdparts} > run_kern=booti ${loadaddr} ${rd_spec} ${fdtaddr} > > boot=mmc
diff --git a/board/ti/am62x/am62x.env b/board/ti/am62x/am62x.env index e4e64fa637..cdd30b08ed 100644 --- a/board/ti/am62x/am62x.env +++ b/board/ti/am62x/am62x.env @@ -7,8 +7,7 @@ findfdt= setenv fdtfile ${name_fdt} name_kern=Image console=ttyS2,115200n8 -args_all=setenv optargs ${optargs} earlycon=ns16550a,mmio32,0x02800000 - ${mtdparts} +args_all=setenv optargs ${optargs} ${mtdparts} run_kern=booti ${loadaddr} ${rd_spec} ${fdtaddr} boot=mmc
Remove the earlycon settings from args_all. Signed-off-by: Nikhil M Jain <n-jain1@ti.com> --- board/ti/am62x/am62x.env | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)