| Message ID | 20230403184650.20379-1-heinrich.schuchardt@canonical.com |
|---|---|
| State | Accepted |
| Commit | b52d6de20768ddba6b9e75d198179eca6ec66300 |
| Delegated to: | Simon Glass |
| Headers | show |
| Series | [1/1] common: static fdt_simplefb_enable_existing_node() | expand |
On Tue, 4 Apr 2023 at 06:47, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote: > > Function fdt_simplefb_enable_existing_node() should be static as it is not > used outside common/fdt_simplefb.c. > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > common/fdt_simplefb.c | 8 +++++++- > include/fdt_simplefb.h | 1 - > 2 files changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org>
On Tue, 4 Apr 2023 at 06:47, Heinrich Schuchardt <heinrich.schuchardt@canonical.com> wrote: > > Function fdt_simplefb_enable_existing_node() should be static as it is not > used outside common/fdt_simplefb.c. > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> > --- > common/fdt_simplefb.c | 8 +++++++- > include/fdt_simplefb.h | 1 - > 2 files changed, 7 insertions(+), 2 deletions(-) > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks!
diff --git a/common/fdt_simplefb.c b/common/fdt_simplefb.c index 282c34fe0b..069ced75a7 100644 --- a/common/fdt_simplefb.c +++ b/common/fdt_simplefb.c @@ -71,7 +71,13 @@ int fdt_simplefb_add_node(void *blob) return fdt_simplefb_configure_node(blob, off); } -int fdt_simplefb_enable_existing_node(void *blob) +/** + * fdt_simplefb_enable_existing_node() - enable simple-framebuffer DT node + * + * @blob: device-tree + * Return: 0 on success, non-zero otherwise + */ +static int fdt_simplefb_enable_existing_node(void *blob) { int off; diff --git a/include/fdt_simplefb.h b/include/fdt_simplefb.h index 41cd740ac0..af93e3be63 100644 --- a/include/fdt_simplefb.h +++ b/include/fdt_simplefb.h @@ -9,6 +9,5 @@ #ifndef _FDT_SIMPLEFB_H_ #define _FDT_SIMPLEFB_H_ int fdt_simplefb_add_node(void *blob); -int fdt_simplefb_enable_existing_node(void *blob); int fdt_simplefb_enable_and_mem_rsv(void *blob); #endif
Function fdt_simplefb_enable_existing_node() should be static as it is not used outside common/fdt_simplefb.c. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com> --- common/fdt_simplefb.c | 8 +++++++- include/fdt_simplefb.h | 1 - 2 files changed, 7 insertions(+), 2 deletions(-)