diff mbox series

[1/1] cmd: missing break in test_write_limit()

Message ID 20230402045154.8493-1-heinrich.schuchardt@canonical.com
State Accepted
Commit 7e218c19c74bcedf3a2225fe2bf1aee34b2bb5ee
Delegated to: Ilias Apalodimas
Headers show
Series [1/1] cmd: missing break in test_write_limit() | expand

Commit Message

Heinrich Schuchardt April 2, 2023, 4:51 a.m. UTC 
In test_write_limit() an unintended fall-through occurs.

Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
 cmd/tpm_test.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Glass April 2, 2023, 6:45 p.m. UTC | #1 
On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt
<heinrich.schuchardt@canonical.com> wrote:
>
> In test_write_limit() an unintended fall-through occurs.
>
> Suggested-by: Simon Glass <sjg@chromium.org>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
>  cmd/tpm_test.c | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Ilias Apalodimas April 3, 2023, 5:52 a.m. UTC | #2 
On Sun, 2 Apr 2023 at 21:45, Simon Glass <sjg@chromium.org> wrote:
>
> On Sun, 2 Apr 2023 at 16:51, Heinrich Schuchardt
> <heinrich.schuchardt@canonical.com> wrote:
> >
> > In test_write_limit() an unintended fall-through occurs.
> >
> > Suggested-by: Simon Glass <sjg@chromium.org>
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > ---
> >  cmd/tpm_test.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff mbox series

Patch

diff --git a/cmd/tpm_test.c b/cmd/tpm_test.c
index b35eae81dc..c4ed8e5901 100644
--- a/cmd/tpm_test.c
+++ b/cmd/tpm_test.c
@@ -471,6 +471,7 @@  static int test_write_limit(struct udevice *dev)
 			break;
 		case TPM_MAXNVWRITES:
 			assert(i >= TPM_MAX_NV_WRITES_NOOWNER);
+			break;
 		default:
 			pr_err("\tunexpected error code %d (0x%x)\n",
 			      result, result);