diff mbox series

test: cmd: fdt: Drop unused fdt_test_header_get() fdt parameter

Message ID 20230311162846.162218-1-marek.vasut+renesas@mailbox.org
State Accepted
Delegated to: Simon Glass
Headers show
Series test: cmd: fdt: Drop unused fdt_test_header_get() fdt parameter | expand

Commit Message

Marek Vasut March 11, 2023, 4:28 p.m. UTC 
The 'fdt' parameter is not used anywhere in the function, drop it.
This also should fix the following compiler warning in sandbox_spl:

test/cmd/fdt.c:1159:9: warning: 'fdt_test_header_get' accessing 4096 bytes in a region of size 256 [-Wstringop-overflow=]

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
 test/cmd/fdt.c | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

Comments

Simon Glass March 14, 2023, 10:08 p.m. UTC | #1 
Hi Marek,

On Sat, 11 Mar 2023 at 09:29, Marek Vasut
<marek.vasut+renesas@mailbox.org> wrote:
>
> The 'fdt' parameter is not used anywhere in the function, drop it.
> This also should fix the following compiler warning in sandbox_spl:
>
> test/cmd/fdt.c:1159:9: warning: 'fdt_test_header_get' accessing 4096 bytes in a region of size 256 [-Wstringop-overflow=]
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
>  test/cmd/fdt.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)

OK, Tom has complained about this so I'll merge this into the
offending patch. I think it is a new-compiler thing.

Regards,
Simon
diff mbox series

Patch

diff --git a/test/cmd/fdt.c b/test/cmd/fdt.c
index ebe411f5b67..22e8c7e3d26 100644
--- a/test/cmd/fdt.c
+++ b/test/cmd/fdt.c
@@ -1112,7 +1112,7 @@  static int fdt_test_bootcpu(struct unit_test_state *uts)
 }
 FDT_TEST(fdt_test_bootcpu, UT_TESTF_CONSOLE_REC);
 
-static int fdt_test_header_get(struct unit_test_state *uts, char fdt[4096],
+static int fdt_test_header_get(struct unit_test_state *uts,
 			       const char *field, const unsigned long val)
 {
 	/* Test getting valid header entry */
@@ -1156,16 +1156,16 @@  static int fdt_test_header(struct unit_test_state *uts)
 	ut_assertok(ut_check_console_end(uts));
 
 	/* Test header get */
-	fdt_test_header_get(uts, fdt, "magic", fdt_magic(fdt));
-	fdt_test_header_get(uts, fdt, "totalsize", fdt_totalsize(fdt));
-	fdt_test_header_get(uts, fdt, "off_dt_struct", fdt_off_dt_struct(fdt));
-	fdt_test_header_get(uts, fdt, "off_dt_strings", fdt_off_dt_strings(fdt));
-	fdt_test_header_get(uts, fdt, "off_mem_rsvmap", fdt_off_mem_rsvmap(fdt));
-	fdt_test_header_get(uts, fdt, "version", fdt_version(fdt));
-	fdt_test_header_get(uts, fdt, "last_comp_version", fdt_last_comp_version(fdt));
-	fdt_test_header_get(uts, fdt, "boot_cpuid_phys", fdt_boot_cpuid_phys(fdt));
-	fdt_test_header_get(uts, fdt, "size_dt_strings", fdt_size_dt_strings(fdt));
-	fdt_test_header_get(uts, fdt, "size_dt_struct", fdt_size_dt_struct(fdt));
+	fdt_test_header_get(uts, "magic", fdt_magic(fdt));
+	fdt_test_header_get(uts, "totalsize", fdt_totalsize(fdt));
+	fdt_test_header_get(uts, "off_dt_struct", fdt_off_dt_struct(fdt));
+	fdt_test_header_get(uts, "off_dt_strings", fdt_off_dt_strings(fdt));
+	fdt_test_header_get(uts, "off_mem_rsvmap", fdt_off_mem_rsvmap(fdt));
+	fdt_test_header_get(uts, "version", fdt_version(fdt));
+	fdt_test_header_get(uts, "last_comp_version", fdt_last_comp_version(fdt));
+	fdt_test_header_get(uts, "boot_cpuid_phys", fdt_boot_cpuid_phys(fdt));
+	fdt_test_header_get(uts, "size_dt_strings", fdt_size_dt_strings(fdt));
+	fdt_test_header_get(uts, "size_dt_struct", fdt_size_dt_struct(fdt));
 
 	return 0;
 }