From patchwork Mon Feb 27 19:53:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 1749108 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.a=rsa-sha256 header.s=mail20150812 header.b=slUY0AyW; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.a=rsa-sha256 header.s=mail20150812 header.b=h4zxb1Pw; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PQWWd03Rlz1yWy for ; Tue, 28 Feb 2023 06:58:04 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6A78E85B6C; Mon, 27 Feb 2023 20:56:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=mailbox.org header.i=@mailbox.org header.b="slUY0AyW"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="h4zxb1Pw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 49A8C85953; Mon, 27 Feb 2023 20:55:14 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [IPv6:2001:67c:2050:0:465::202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6038485A9B for ; Mon, 27 Feb 2023 20:55:10 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.vasut+renesas@mailbox.org Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4PQWSD1lhbz9sby; Mon, 27 Feb 2023 20:55:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1677527708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nwbjFmMi7vjgBOn8TTQpQfWrfGItqszT9QSq11ZWd4Y=; b=slUY0AyWx00j0Z0zqgDrb16Wx/X8vEWHrhQgDUwoykVcxCQ8+mgnqTI3WO0u12yh1ckmp1 UE6w+UGJ2LqtAbfkHn6C8Om+RruXbICA36jrhRKA3EIa6gqglvUcfgNjcT1GyoATrPdIGq /P0cSEdI6FpKLTRB5QTjsKzegbMwbZIBkE94QbbxkzjaBtEWrYyJkWsbUTD8sRpXSKX+wa 3zMKCJbK3+x2JPpZJ8jT0Y9T/L7oOy+p2lHhFkxxgZMrnp8qUN7UOnOcFEUx21IeGBBGpD XsRKstlDwaHdY84SOyGMkswDcat+XCxti/QJL0LErSY2oxFs5oZUzuXf607Cdg== From: Marek Vasut DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1677527706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nwbjFmMi7vjgBOn8TTQpQfWrfGItqszT9QSq11ZWd4Y=; b=h4zxb1PwWaJCVfFRPv3fROlTClXj0dOErQdmUKw4+ph4LMKMlvUha5WtrfMwNgXRpU/Sh6 7dARFwSbhJVWUEnKyRg/7K48kj1T2OCsm0Sm+OLEJ92rVEimcuUi6WKK9hxiyiM+JBTYLL vJtisd+Ou2lkGLUn+cNI72f9wLLps8f/vJZOW1YnM8k4VD9NaSLLTKQlIbx7s8g8hN+Sya MtZiSIEJqKuIbIHNlWMnNNMJ+Q0s6ghaOllMJTGsX89PGOUVmWOUv+IK41POfER6lkRB4y n3Pa0j0xDnmlzFuVeIuEn8jNByf+bRJMt5OAwtrlpkN+ptEWf1mD7wnPjJQYUw== To: u-boot@lists.denx.de Cc: Marek Vasut , Heinrich Schuchardt , Simon Glass , Tom Rini Subject: [PATCH 08/32] cmd: fdt: Handle 64bit pointers in fdt get addr Date: Mon, 27 Feb 2023 20:53:33 +0100 Message-Id: <20230227195357.98723-8-marek.vasut+renesas@mailbox.org> In-Reply-To: <20230227195357.98723-1-marek.vasut+renesas@mailbox.org> References: <20230227195357.98723-1-marek.vasut+renesas@mailbox.org> MIME-Version: 1.0 X-MBO-RS-META: gzmc3bouhmqy13wqrhm1mw7y3w6r3wbw X-MBO-RS-ID: 52d905cc72523fbb87d X-Rspamd-Queue-Id: 4PQWSD1lhbz9sby X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean The command assumed 32bit pointers so far, with 64bit pointer the command would overwrite a piece of stack. Fix it by extending the array size to cater for 64bit pointer, and use snprintf() to avoid writing past the end of the array ever again. Signed-off-by: Marek Vasut Reviewed-by: Simon Glass --- Cc: Heinrich Schuchardt Cc: Simon Glass Cc: Tom Rini --- cmd/fdt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/fdt.c b/cmd/fdt.c index 279dad9fe11..bc19303159d 100644 --- a/cmd/fdt.c +++ b/cmd/fdt.c @@ -466,9 +466,9 @@ static int do_fdt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) return ret; } else if (subcmd[0] == 'a') { /* Get address */ - char buf[11]; + char buf[19]; - sprintf(buf, "0x%p", nodep); + snprintf(buf, sizeof(buf), "0x%p", nodep); env_set(var, buf); } else if (subcmd[0] == 's') { /* Get size */