diff mbox series

ARM: dts: at91: sama7g5: fix clock id for ebi node

Message ID 20230223112858.1641-1-mihai.sain@microchip.com
State Accepted
Commit 1415cdac77d66b3d6ed4b4367e31c61dae41aebe
Delegated to: Eugen Hristev
Headers show
Series ARM: dts: at91: sama7g5: fix clock id for ebi node | expand

Commit Message

Mihai Sain Feb. 23, 2023, 11:28 a.m. UTC
The PMC_MCK1 clock id for the ebi node is 23.

Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
---
 arch/arm/dts/sama7g5.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Eugen Hristev Feb. 24, 2023, 12:30 p.m. UTC | #1
On 2/23/23 13:28, Mihai Sain wrote:
> The PMC_MCK1 clock id for the ebi node is 23.
> 
> Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>
> ---
>   arch/arm/dts/sama7g5.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
> index d38090d7dd..a802153af8 100644
> --- a/arch/arm/dts/sama7g5.dtsi
> +++ b/arch/arm/dts/sama7g5.dtsi
> @@ -150,7 +150,7 @@
>   				  0x1 0x0 0x48000000 0x8000000
>   				  0x2 0x0 0x50000000 0x8000000
>   				  0x3 0x0 0x58000000 0x8000000>;
> -			clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
> +			clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
>   			status = "disabled";
>   
>   			nand_controller: nand-controller {

Hi Mihai,

It appears PMC_MCK1 = PMC_MAIN(3) + 10 , in Linux.
In U-boot indeed it's 23.

Thanks for fixing it,

Reviewed-by: Eugen Hristev <eugen.hristev@collabora.com>

PS. I will amend the commit as it appears 4ce85577ac does not exist
Claudiu Beznea Feb. 24, 2023, 4:49 p.m. UTC | #2
On 23.02.2023 13:28, Mihai Sain wrote:
> The PMC_MCK1 clock id for the ebi node is 23.
> 
> Fixes: 4ce85577ac ("ARM: dts: at91: sama7g5/sama7g5ek: align with Linux DT")
> Signed-off-by: Mihai Sain <mihai.sain@microchip.com>

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>


> ---
>  arch/arm/dts/sama7g5.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
> index d38090d7dd..a802153af8 100644
> --- a/arch/arm/dts/sama7g5.dtsi
> +++ b/arch/arm/dts/sama7g5.dtsi
> @@ -150,7 +150,7 @@
>  				  0x1 0x0 0x48000000 0x8000000
>  				  0x2 0x0 0x50000000 0x8000000
>  				  0x3 0x0 0x58000000 0x8000000>;
> -			clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
> +			clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
>  			status = "disabled";
>  
>  			nand_controller: nand-controller {
diff mbox series

Patch

diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi
index d38090d7dd..a802153af8 100644
--- a/arch/arm/dts/sama7g5.dtsi
+++ b/arch/arm/dts/sama7g5.dtsi
@@ -150,7 +150,7 @@ 
 				  0x1 0x0 0x48000000 0x8000000
 				  0x2 0x0 0x50000000 0x8000000
 				  0x3 0x0 0x58000000 0x8000000>;
-			clocks = <&pmc PMC_TYPE_CORE 13>; /* PMC_MCK1 */
+			clocks = <&pmc PMC_TYPE_CORE 23>; /* PMC_MCK1 */
 			status = "disabled";
 
 			nand_controller: nand-controller {