Message ID | 20230221201925.9644-48-pali@kernel.org |
---|---|
State | Accepted |
Commit | 2f6855a6aa8d55d8341f454f87cabc784a890193 |
Delegated to: | Stefan Roese |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=X5jnZcS7; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PLrZm1B1hz23j7 for <incoming@patchwork.ozlabs.org>; Wed, 22 Feb 2023 07:33:04 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8CE6985B7E; Tue, 21 Feb 2023 21:24:41 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="X5jnZcS7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B1C3685A7B; Tue, 21 Feb 2023 21:23:57 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D3C6585AFD for <u-boot@lists.denx.de>; Tue, 21 Feb 2023 21:22:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D124FB810D1; Tue, 21 Feb 2023 20:22:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6292AC433D2; Tue, 21 Feb 2023 20:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677010957; bh=y+0vFyQUIHl1yNi34tleuYqAyw3lgSQGe4HS7MWertk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X5jnZcS718Y29gQMmCdRfS9C1tzyR0AVRnwC8bxZOAiqkm0G8uDW16PzTUESaxlgE ZGbZCuWrHQL9/urWBgbR878nSafH0Pf01UUo+g/XlRTb0WQhgJiPAb8VJSM1mv6bWw AoV7VscpO9t26GQ0RBGIhCQ7GIQcDZAHOqx+LcegJmTBlWcH8nrxzyr0pqUlvPexrw Q+qvY2WzgozWf6Fl2J/mdeNqPWU3OU7vXJel2dTDCnoVgOlz1TM35wcoSvxXLWE6wz FUFWBLm3wKtA01ZAw/YvYsRZdnonRKWxqoTwATt7uT/NYmlE8muFNvZiHF2fxQbIxK v7m8vc4u7BFGg== Received: by pali.im (Postfix) id 5E7C8AC9; Tue, 21 Feb 2023 21:22:35 +0100 (CET) From: =?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org> To: u-boot@lists.denx.de Cc: Stefan Roese <sr@denx.de>, Tony Dinh <mibodhi@gmail.com>, Josua Mayer <josua@solid-run.com> Subject: [PATCH RFC u-boot-mvebu 47/59] tools: mkimage: Print human readable error when -d is not specified Date: Tue, 21 Feb 2023 21:19:13 +0100 Message-Id: <20230221201925.9644-48-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230221201925.9644-1-pali@kernel.org> References: <20230221201925.9644-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean |
Series |
arm: mvebu: Various fixes
|
expand
|
diff --git a/tools/mkimage.c b/tools/mkimage.c index 955a1f39a419..c53768f8d8de 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -568,6 +568,11 @@ int main(int argc, char **argv) } if ((params.type != IH_TYPE_MULTI) && (params.type != IH_TYPE_SCRIPT)) { + if (!params.datafile) { + fprintf(stderr, "%s: Option -d with image data file was not specified\n", + params.cmdname); + exit(EXIT_FAILURE); + } dfd = open(params.datafile, O_RDONLY | O_BINARY); if (dfd < 0) { fprintf(stderr, "%s: Can't open %s: %s\n",
When asking mkimage to create a new image file and option -d is not specified then mkimage show human unfriendly error message: mkimage: Can't open (null): Bad address Without debugger it is hard to debug what is the issue. Function open() is being called with file name set to NULL. So add a check for this and if it happens then show human readable message that option -d was not specified. Signed-off-by: Pali Rohár <pali@kernel.org> --- tools/mkimage.c | 5 +++++ 1 file changed, 5 insertions(+)