| Message ID | 20230207233718.3162217-2-tharvey@gateworks.com |
|---|---|
| State | Accepted |
| Commit | 2b7252953c502eb64593aebeb65409d268068365 |
| Delegated to: | Ramon Fried |
| Headers | show |
| Series | [1/3] net: ksz9477: remove unnecessary dsa_set_tagging call | expand |
On Wed, Feb 8, 2023 at 1:37 AM Tim Harvey <tharvey@gateworks.com> wrote: > > We don't do anything useful with the master dev, so remove the variable. > > Signed-off-by: Tim Harvey <tharvey@gateworks.com> > --- > drivers/net/ksz9477.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/net/ksz9477.c b/drivers/net/ksz9477.c > index fecc394e0277..5b0ef78ab93b 100644 > --- a/drivers/net/ksz9477.c > +++ b/drivers/net/ksz9477.c > @@ -443,15 +443,10 @@ static int ksz_i2c_probe(struct udevice *dev) > { > struct dsa_pdata *pdata = dev_get_uclass_plat(dev); > struct ksz_dsa_priv *priv = dev_get_priv(dev); > - struct udevice *master = dsa_get_master(dev); > int i, ret; > u8 data8; > u32 id; > > - if (!master) > - return -ENODEV; > - > - dev_dbg(dev, "%s %s master:%s\n", __func__, dev->name, master->name); > dev_set_parent_priv(dev, priv); > > ret = i2c_set_chip_offset_len(dev, 2); > -- > 2.25.1 > Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
diff --git a/drivers/net/ksz9477.c b/drivers/net/ksz9477.c index fecc394e0277..5b0ef78ab93b 100644 --- a/drivers/net/ksz9477.c +++ b/drivers/net/ksz9477.c @@ -443,15 +443,10 @@ static int ksz_i2c_probe(struct udevice *dev) { struct dsa_pdata *pdata = dev_get_uclass_plat(dev); struct ksz_dsa_priv *priv = dev_get_priv(dev); - struct udevice *master = dsa_get_master(dev); int i, ret; u8 data8; u32 id; - if (!master) - return -ENODEV; - - dev_dbg(dev, "%s %s master:%s\n", __func__, dev->name, master->name); dev_set_parent_priv(dev, priv); ret = i2c_set_chip_offset_len(dev, 2);
We don't do anything useful with the master dev, so remove the variable. Signed-off-by: Tim Harvey <tharvey@gateworks.com> --- drivers/net/ksz9477.c | 5 ----- 1 file changed, 5 deletions(-)