From patchwork Sat Dec 17 16:11:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1716906 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=HVcAch2k; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NZ9w45jRHz240B for ; Sun, 18 Dec 2022 03:12:04 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A2B1985389; Sat, 17 Dec 2022 17:11:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="HVcAch2k"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 387358537A; Sat, 17 Dec 2022 17:11:51 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7600D8537A for ; Sat, 17 Dec 2022 17:11:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-il1-x136.google.com with SMTP id i25so2757305ila.8 for ; Sat, 17 Dec 2022 08:11:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rQAuw4RrRFQakkUWajF/SdV5sge1eegoJuJ0jSnZTjQ=; b=HVcAch2k/gqMjEDBGdpgiUL3XaQQ+St3b3kK7Yf+NqPgV2EklXcJ5HLQF6nIIf+f+m UFaRSvykBAuH3jhaSF2+roDvxAfTHanYL4t07mcK6/a3NmfL+uNk9B6JsZzoNy+9cQZj UK0Qz2vCvpExT3UFjzcGCpJoOCrWV/S/bGGX4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rQAuw4RrRFQakkUWajF/SdV5sge1eegoJuJ0jSnZTjQ=; b=Zi+eZUEoBfSeUiB1/sNuOOYe4XLFD3cxvcgt3ivprSjjChzsYW+RA+w49Q2QcdvAM9 49r9NnxuK1X+uUPADpIvWjA8wOfiBUdtZEwmJw3uveX9MRrvRzRx1S7mFzD7LrqpeHuC pil56+Giv2N6h1jhNIoz6t/YXoIUXPTP852ixtbKtCPYrxcji5WCpDn5vKuoMb7+oR5k LvCrRw0TDENUET6QfacoHvl8349E7Fbd1gYxMeI/a5RQH8i0EkEVySzSzgVcmuOpVvzs 3VeEXYZKsUIAP4/3VDUnSE1htMxm8FEUZEfISj2ebx21ihctf+6wDEwnJ27uTJZXZQJD m3/w== X-Gm-Message-State: AFqh2kqM9k4JDrSsdtec5rET0khCiHqDQsxKbnlChMRhlOrIwdTisa3K xShivTpOXCtqa7XCZcSn4NzpOMo4dCvzo94x X-Google-Smtp-Source: AMrXdXvwO0RLrMG2k5yUxtevlhCIn5/up3uZND6GM/RzdzNgfVXaaFT39KtjR/r5X2keQz9S8t9WOA== X-Received: by 2002:a92:cd8d:0:b0:2ff:b176:d1f5 with SMTP id r13-20020a92cd8d000000b002ffb176d1f5mr2814469ilb.19.1671293506909; Sat, 17 Dec 2022 08:11:46 -0800 (PST) Received: from sjg1.roam.corp.google.com (c-67-190-102-125.hsd1.co.comcast.net. [67.190.102.125]) by smtp.gmail.com with ESMTPSA id o5-20020a056e02092500b00302f958e71dsm1652817ilt.49.2022.12.17.08.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Dec 2022 08:11:46 -0800 (PST) From: Simon Glass To: U-Boot Mailing List Cc: Peter Geis , Jerome Forissier , Tom Rini , Philippe Reynes , Alper Nebi Yasak , huang lin , Jeffy Chen , Simon Glass , Kever Yang , Philipp Tomsich , Quentin Schulz , Ivan Mikhaylov , Roger Quadros Subject: [PATCH v6 02/12] binman: Tidy up comment in fit _gen_node Date: Sat, 17 Dec 2022 09:11:07 -0700 Message-Id: <20221217161117.61699-3-sjg@chromium.org> X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog In-Reply-To: <20221217161117.61699-1-sjg@chromium.org> References: <20221217161117.61699-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Expand this comment to cover both cases that are supported. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/fit.py | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/tools/binman/etype/fit.py b/tools/binman/etype/fit.py index 7860e2aeea3..8ad4f3a8a83 100644 --- a/tools/binman/etype/fit.py +++ b/tools/binman/etype/fit.py @@ -579,11 +579,17 @@ class Entry_fit(Entry_section): def _gen_node(base_node, node, depth, in_images, entry): """Generate nodes from a template - This creates one node for each member of self._fdts using the - provided template. If a property value contains 'NAME' it is - replaced with the filename of the FDT. If a property value contains - SEQ it is replaced with the node sequence number, where 1 is the - first. + This creates one or more nodes depending on the fit,operation being + used. + + For OP_GEN_FDT_NODES it creates one node for each member of + self._fdts using the provided template. If a property value contains + 'NAME' it is replaced with the filename of the FDT. If a property + value contains SEQ it is replaced with the node sequence number, + where 1 is the first. + + For OP_SPLIT_ELF it emits one node for each section in the ELF file. + If the file is missing, nothing is generated. Args: base_node (Node): Base Node of the FIT (with 'description'