From patchwork Sun Dec 4 15:14:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rini X-Patchwork-Id: 1712015 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256 header.s=google header.b=V2x+yKrz; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4NQ9gt5gMqz23mf for ; Mon, 5 Dec 2022 02:33:46 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id A7CA8856D1; Sun, 4 Dec 2022 16:16:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="V2x+yKrz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E0DA38563B; Sun, 4 Dec 2022 16:15:34 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EAFF085621 for ; Sun, 4 Dec 2022 16:15:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-ed1-x534.google.com with SMTP id m19so12570000edj.8 for ; Sun, 04 Dec 2022 07:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=zRj86w+udLBLRSnI9msf9sbF2/92hXVLciCVoBMXePc=; b=V2x+yKrzhE5+b6NevVjjAmkm3qE3HloHpAbsw9rXk4yqBsSQ+4psHRirmQWACeiK5O l3FiBLD18qWswYcn5kqNQQUQO/CWrdiAIpzolhArNNozfbu7E6RIhCQf7iA9XG1uRVx1 TDR6uR+5YgsMfGH5cclzsNiEMlegDW3JvQmPM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zRj86w+udLBLRSnI9msf9sbF2/92hXVLciCVoBMXePc=; b=zBS23y38uCHevnx3dLTy1bTtkC5mBoue2888dTG/2F4jYIzsxlOif+LjCId13/Othf 8qaVxDuOl4g4NfJr8+xzTT9u1x33MV2TGwEgTnu4N0SlRRU729zEyVBfFAJHtUYKTl4L vNLBBWboV/9qp/3sWWPZbFetCpMqVPBiq8L1iN+AWVqsK/uhfq1hlHKsEwkfEcfoM8sp 3fZQZBnjL5BnOseCKSCWsWUbtvcfbFzWtUijs23VzFzOupbD8JHktQYrJCSPzjkqr2qn VfLEOSOUAlbl0y2+lR/OVWSqqmgUAaQuLT0uEyIen/UWhPaTUlv22g4wZUztCi8sq3BJ b8Tg== X-Gm-Message-State: ANoB5pkFhD13RzmCYSd9DDwjLM3YYRQAdI9owZhhJNZY/8hAAlhd5wOI KJlwutoyOkoN7UA9vdec9qnWg7g8q0I7rjj8 X-Google-Smtp-Source: AA0mqf7vcWgVxZyVqIqzhvfn4GR7Pcqf1pXa0Nj0s6gksKez9bRuQobsouQ77vMGziNfT6SGJofamA== X-Received: by 2002:a05:6402:360a:b0:469:f59f:352e with SMTP id el10-20020a056402360a00b00469f59f352emr50578887edb.241.1670166926274; Sun, 04 Dec 2022 07:15:26 -0800 (PST) Received: from bill-the-cat.lan (2603-6081-7b00-6400-61c7-2644-b62d-0af3.res6.spectrum.com. [2603:6081:7b00:6400:61c7:2644:b62d:af3]) by smtp.gmail.com with ESMTPSA id b21-20020aa7c915000000b00461816beef9sm5174405edt.14.2022.12.04.07.15.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Dec 2022 07:15:25 -0800 (PST) From: Tom Rini To: u-boot@lists.denx.de Subject: [PATCH 143/149] checkpatch.pl: Update CONFIG logic in U-Boot section Date: Sun, 4 Dec 2022 10:14:14 -0500 Message-Id: <20221204151420.56851-53-trini@konsulko.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221204151420.56851-1-trini@konsulko.com> References: <20221202214251.3027264-41-trini@konsulko.com> <20221204151420.56851-1-trini@konsulko.com> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Now that all CONFIG symbols are in Kconfig, checkpatch.pl should check for and error on any case of define/undef CONFIG_*. Signed-off-by: Tom Rini --- scripts/checkpatch.pl | 8 ++++---- tools/patman/test_checkpatch.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index fe13e265a3fe..ccfcbb3e1255 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2630,10 +2630,10 @@ sub u_boot_line { "strl$1 is preferred over strn$1 because it always produces a nul-terminated string\n" . $herecurr); } - # use defconfig to manage CONFIG_CMD options - if ($line =~ /\+\s*#\s*(define|undef)\s+(CONFIG_CMD\w*)\b/) { - ERROR("DEFINE_CONFIG_CMD", - "All commands are managed by Kconfig\n" . $herecurr); + # use Kconfig for all CONFIG symbols + if ($line =~ /\+\s*#\s*(define|undef)\s+(CONFIG_\w*)\b/) { + ERROR("DEFINE_CONFIG_SYM", + "All CONFIG symbols are managed by Kconfig\n" . $herecurr); } # Don't put common.h and dm.h in header files diff --git a/tools/patman/test_checkpatch.py b/tools/patman/test_checkpatch.py index 8960cd505f82..4c2ab6e590ed 100644 --- a/tools/patman/test_checkpatch.py +++ b/tools/patman/test_checkpatch.py @@ -396,7 +396,7 @@ index 0000000..2234c87 """Test for enabling/disabling commands using preprocesor""" pm = PatchMaker() pm.add_line('common/main.c', '#undef CONFIG_CMD_WHICH') - self.check_single_message(pm, 'DEFINE_CONFIG_CMD', 'error') + self.check_single_message(pm, 'DEFINE_CONFIG_SYM', 'error') def test_barred_include_in_hdr(self): """Test for using a barred include in a header file"""