diff mbox series

[v2,3/4] watchdog: ulp_wdog: enable watchdog interrupt on imx93

Message ID 20221021084118.2367-4-alice.guo@oss.nxp.com
State Accepted
Delegated to: Stefan Roese
Headers show
Series ulp wdog | expand

Commit Message

Alice Guo (OSS) Oct. 21, 2022, 8:41 a.m. UTC
From: Alice Guo <alice.guo@nxp.com>

The reset source of the external PMIC on i.MX93 is WDOG_ANY PAD and the
source of WDOG_ANY PAD is interrupt. Therefore, using PMIC to reset
needs to enable the watchdog interrupt.

Signed-off-by: Alice Guo <alice.guo@nxp.com>
---

Changes for v2:
 none

 drivers/watchdog/ulp_wdog.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Stefan Roese Oct. 24, 2022, 6:01 a.m. UTC | #1
On 21.10.22 10:41, Alice Guo (OSS) wrote:
> From: Alice Guo <alice.guo@nxp.com>
> 
> The reset source of the external PMIC on i.MX93 is WDOG_ANY PAD and the
> source of WDOG_ANY PAD is interrupt. Therefore, using PMIC to reset
> needs to enable the watchdog interrupt.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan


> ---
> 
> Changes for v2:
>   none
> 
>   drivers/watchdog/ulp_wdog.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/watchdog/ulp_wdog.c b/drivers/watchdog/ulp_wdog.c
> index 17778587ee..1b286816b5 100644
> --- a/drivers/watchdog/ulp_wdog.c
> +++ b/drivers/watchdog/ulp_wdog.c
> @@ -39,6 +39,7 @@ struct wdog_regs {
>   #define WDOG_CS_PRES                    BIT(12)
>   #define WDGCS_CMD32EN                   BIT(13)
>   #define WDGCS_FLG                       BIT(14)
> +#define WDGCS_INT			BIT(6)
>   
>   #define WDG_BUS_CLK                      (0x0)
>   #define WDG_LPO_CLK                      (0x1)
> @@ -92,7 +93,7 @@ void hw_watchdog_init(void)
>   	/* setting 1-kHz clock source, enable counter running, and clear interrupt */
>   	if (IS_ENABLED(CONFIG_ARCH_IMX9))
>   		writel((cmd32 | WDGCS_WDGE | WDGCS_WDGUPDATE | (WDG_LPO_CLK << 8) |
> -		       WDGCS_FLG | WDOG_CS_PRES), &wdog->cs);
> +		       WDGCS_FLG | WDOG_CS_PRES | WDGCS_INT), &wdog->cs);
>   	else
>   		writel((cmd32 | WDGCS_WDGE | WDGCS_WDGUPDATE | (WDG_LPO_CLK << 8) |
>   		       WDGCS_FLG), &wdog->cs);
> @@ -128,7 +129,8 @@ void reset_cpu(void)
>   
>   	/* enable counter running */
>   	if (IS_ENABLED(CONFIG_ARCH_IMX9))
> -		writel((cmd32 | WDGCS_WDGE | (WDG_LPO_CLK << 8) | WDOG_CS_PRES), &wdog->cs);
> +		writel((cmd32 | WDGCS_WDGE | (WDG_LPO_CLK << 8) | WDOG_CS_PRES |
> +		       WDGCS_INT), &wdog->cs);
>   	else
>   		writel((cmd32 | WDGCS_WDGE | (WDG_LPO_CLK << 8)), &wdog->cs);
>   

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/drivers/watchdog/ulp_wdog.c b/drivers/watchdog/ulp_wdog.c
index 17778587ee..1b286816b5 100644
--- a/drivers/watchdog/ulp_wdog.c
+++ b/drivers/watchdog/ulp_wdog.c
@@ -39,6 +39,7 @@  struct wdog_regs {
 #define WDOG_CS_PRES                    BIT(12)
 #define WDGCS_CMD32EN                   BIT(13)
 #define WDGCS_FLG                       BIT(14)
+#define WDGCS_INT			BIT(6)
 
 #define WDG_BUS_CLK                      (0x0)
 #define WDG_LPO_CLK                      (0x1)
@@ -92,7 +93,7 @@  void hw_watchdog_init(void)
 	/* setting 1-kHz clock source, enable counter running, and clear interrupt */
 	if (IS_ENABLED(CONFIG_ARCH_IMX9))
 		writel((cmd32 | WDGCS_WDGE | WDGCS_WDGUPDATE | (WDG_LPO_CLK << 8) |
-		       WDGCS_FLG | WDOG_CS_PRES), &wdog->cs);
+		       WDGCS_FLG | WDOG_CS_PRES | WDGCS_INT), &wdog->cs);
 	else
 		writel((cmd32 | WDGCS_WDGE | WDGCS_WDGUPDATE | (WDG_LPO_CLK << 8) |
 		       WDGCS_FLG), &wdog->cs);
@@ -128,7 +129,8 @@  void reset_cpu(void)
 
 	/* enable counter running */
 	if (IS_ENABLED(CONFIG_ARCH_IMX9))
-		writel((cmd32 | WDGCS_WDGE | (WDG_LPO_CLK << 8) | WDOG_CS_PRES), &wdog->cs);
+		writel((cmd32 | WDGCS_WDGE | (WDG_LPO_CLK << 8) | WDOG_CS_PRES |
+		       WDGCS_INT), &wdog->cs);
 	else
 		writel((cmd32 | WDGCS_WDGE | (WDG_LPO_CLK << 8)), &wdog->cs);