diff mbox series

rockchip: jerry: Enable RESET driver

Message ID 20220928024046.2657593-1-sjg@chromium.org
State Accepted
Delegated to: Kever Yang
Headers show
Series rockchip: jerry: Enable RESET driver | expand

Commit Message

Simon Glass Sept. 28, 2022, 2:40 a.m. UTC
At present the display does not work since it needs the reset driver to
operate. Fix this by enabling it.

Signed-off-by: Simon Glass <sjg@chromium.org>
Fixes: cd529f7ad62 ("rockchip: video: edp: Add missing reset support")
Fixes: 9749d2ea29e ("rockchip: video: vop: Add reset support")
---

 configs/chromebook_jerry_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Kever Yang Sept. 28, 2022, 7:40 a.m. UTC | #1
Hi Simon,

On 2022/9/28 10:40, Simon Glass wrote:
> At present the display does not work since it needs the reset driver to
> operate. Fix this by enabling it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Fixes: cd529f7ad62 ("rockchip: video: edp: Add missing reset support")
> Fixes: 9749d2ea29e ("rockchip: video: vop: Add reset support")
> ---
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
>
>   configs/chromebook_jerry_defconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/configs/chromebook_jerry_defconfig b/configs/chromebook_jerry_defconfig
> index 35d546e6315..a60468eafa5 100644
> --- a/configs/chromebook_jerry_defconfig
> +++ b/configs/chromebook_jerry_defconfig
> @@ -95,6 +95,7 @@ CONFIG_REGULATOR_RK8XX=y
>   CONFIG_PWM_ROCKCHIP=y
>   CONFIG_RAM=y
>   CONFIG_SPL_RAM=y
> +CONFIG_DM_RESET=y
>   CONFIG_DEBUG_UART_SHIFT=2
>   CONFIG_ROCKCHIP_SERIAL=y
>   CONFIG_SOUND=y
Simon Glass Dec. 7, 2022, 1:08 a.m. UTC | #2
Hi Kever,

On Wed, 28 Sept 2022 at 20:40, Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Hi Simon,
>
> On 2022/9/28 10:40, Simon Glass wrote:
> > At present the display does not work since it needs the reset driver to
> > operate. Fix this by enabling it.
> >
> > Signed-off-by: Simon Glass <sjg@chromium.org>
> > Fixes: cd529f7ad62 ("rockchip: video: edp: Add missing reset support")
> > Fixes: 9749d2ea29e ("rockchip: video: vop: Add reset support")
> > ---
> Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Can this fix please be applied, along with the FIT series? We have hit rc3 now.

https://patchwork.ozlabs.org/project/uboot/list/?series=326766

>
> Thanks,
> - Kever
> >
> >   configs/chromebook_jerry_defconfig | 1 +
> >   1 file changed, 1 insertion(+)

Regards,
Simon
diff mbox series

Patch

diff --git a/configs/chromebook_jerry_defconfig b/configs/chromebook_jerry_defconfig
index 35d546e6315..a60468eafa5 100644
--- a/configs/chromebook_jerry_defconfig
+++ b/configs/chromebook_jerry_defconfig
@@ -95,6 +95,7 @@  CONFIG_REGULATOR_RK8XX=y
 CONFIG_PWM_ROCKCHIP=y
 CONFIG_RAM=y
 CONFIG_SPL_RAM=y
+CONFIG_DM_RESET=y
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_ROCKCHIP_SERIAL=y
 CONFIG_SOUND=y