diff mbox series

arm: mvebu: turris_omnia: Allow to use second serial port

Message ID 20220909121848.16118-1-pali@kernel.org
State Accepted
Commit cadda05a763ac5c1b844e6e9b78579ca62103cf3
Delegated to: Stefan Roese
Headers show
Series arm: mvebu: turris_omnia: Allow to use second serial port | expand

Commit Message

Pali Rohár Sept. 9, 2022, 12:18 p.m. UTC
Turris Omnia has two serial ports. Both are already specified in device
tree file. But U-Boot by default does not allow to use more than one serial
port unless CONFIG_SERIAL_PROBE_ALL is not enabled.

After enabling CONFIG_SERIAL_PROBE_ALL, U-Boot see also second serial port
(but is inactive by default):

    => coninfo
    List of available devices:
    serial@12000 00000007 IO stdin stdout stderr
    serial@12100 00000007 IO

To allow simultaneously to use more input / output devices it is needed to
enable CONFIG_CONSOLE_MUX option.

With CONFIG_CONSOLE_MUX it is possible to call:

    => setenv stdout 'serial@12000,serial@12100'

And U-Boot output is then visible on both serial ports.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 configs/turris_omnia_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Stefan Roese Sept. 12, 2022, 7:01 a.m. UTC | #1
On 09.09.22 14:18, Pali Rohár wrote:
> Turris Omnia has two serial ports. Both are already specified in device
> tree file. But U-Boot by default does not allow to use more than one serial
> port unless CONFIG_SERIAL_PROBE_ALL is not enabled.
> 
> After enabling CONFIG_SERIAL_PROBE_ALL, U-Boot see also second serial port
> (but is inactive by default):
> 
>      => coninfo
>      List of available devices:
>      serial@12000 00000007 IO stdin stdout stderr
>      serial@12100 00000007 IO
> 
> To allow simultaneously to use more input / output devices it is needed to
> enable CONFIG_CONSOLE_MUX option.
> 
> With CONFIG_CONSOLE_MUX it is possible to call:
> 
>      => setenv stdout 'serial@12000,serial@12100'
> 
> And U-Boot output is then visible on both serial ports.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   configs/turris_omnia_defconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index 4c9ec744e1b5..01dee5472200 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -35,6 +35,7 @@ CONFIG_FIT_VERBOSE=y
>   CONFIG_OF_BOARD_SETUP=y
>   CONFIG_BOOTDELAY=3
>   CONFIG_USE_PREBOOT=y
> +CONFIG_CONSOLE_MUX=y
>   CONFIG_SYS_CONSOLE_INFO_QUIET=y
>   # CONFIG_DISPLAY_BOARDINFO is not set
>   CONFIG_DISPLAY_BOARDINFO_LATE=y
> @@ -105,6 +106,7 @@ CONFIG_PINCTRL_ARMADA_38X=y
>   CONFIG_DM_RTC=y
>   CONFIG_RTC_ARMADA38X=y
>   CONFIG_SCSI=y
> +CONFIG_SERIAL_PROBE_ALL=y
>   CONFIG_SPL_DEBUG_UART_BASE=0xd0012000
>   CONFIG_DEBUG_UART_SHIFT=2
>   CONFIG_SYS_NS16550=y

Viele Grüße,
Stefan Roese
Stefan Roese Sept. 13, 2022, 7:02 a.m. UTC | #2
On 09.09.22 14:18, Pali Rohár wrote:
> Turris Omnia has two serial ports. Both are already specified in device
> tree file. But U-Boot by default does not allow to use more than one serial
> port unless CONFIG_SERIAL_PROBE_ALL is not enabled.
> 
> After enabling CONFIG_SERIAL_PROBE_ALL, U-Boot see also second serial port
> (but is inactive by default):
> 
>      => coninfo
>      List of available devices:
>      serial@12000 00000007 IO stdin stdout stderr
>      serial@12100 00000007 IO
> 
> To allow simultaneously to use more input / output devices it is needed to
> enable CONFIG_CONSOLE_MUX option.
> 
> With CONFIG_CONSOLE_MUX it is possible to call:
> 
>      => setenv stdout 'serial@12000,serial@12100'
> 
> And U-Boot output is then visible on both serial ports.
> 
> Signed-off-by: Pali Rohár <pali@kernel.org>

Applied to u-boot-marvell/master

Thanks,
Stefan

> ---
>   configs/turris_omnia_defconfig | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
> index 4c9ec744e1b5..01dee5472200 100644
> --- a/configs/turris_omnia_defconfig
> +++ b/configs/turris_omnia_defconfig
> @@ -35,6 +35,7 @@ CONFIG_FIT_VERBOSE=y
>   CONFIG_OF_BOARD_SETUP=y
>   CONFIG_BOOTDELAY=3
>   CONFIG_USE_PREBOOT=y
> +CONFIG_CONSOLE_MUX=y
>   CONFIG_SYS_CONSOLE_INFO_QUIET=y
>   # CONFIG_DISPLAY_BOARDINFO is not set
>   CONFIG_DISPLAY_BOARDINFO_LATE=y
> @@ -105,6 +106,7 @@ CONFIG_PINCTRL_ARMADA_38X=y
>   CONFIG_DM_RTC=y
>   CONFIG_RTC_ARMADA38X=y
>   CONFIG_SCSI=y
> +CONFIG_SERIAL_PROBE_ALL=y
>   CONFIG_SPL_DEBUG_UART_BASE=0xd0012000
>   CONFIG_DEBUG_UART_SHIFT=2
>   CONFIG_SYS_NS16550=y

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/configs/turris_omnia_defconfig b/configs/turris_omnia_defconfig
index 4c9ec744e1b5..01dee5472200 100644
--- a/configs/turris_omnia_defconfig
+++ b/configs/turris_omnia_defconfig
@@ -35,6 +35,7 @@  CONFIG_FIT_VERBOSE=y
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_BOOTDELAY=3
 CONFIG_USE_PREBOOT=y
+CONFIG_CONSOLE_MUX=y
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
 # CONFIG_DISPLAY_BOARDINFO is not set
 CONFIG_DISPLAY_BOARDINFO_LATE=y
@@ -105,6 +106,7 @@  CONFIG_PINCTRL_ARMADA_38X=y
 CONFIG_DM_RTC=y
 CONFIG_RTC_ARMADA38X=y
 CONFIG_SCSI=y
+CONFIG_SERIAL_PROBE_ALL=y
 CONFIG_SPL_DEBUG_UART_BASE=0xd0012000
 CONFIG_DEBUG_UART_SHIFT=2
 CONFIG_SYS_NS16550=y