diff mbox series

[06/17] net: ipv6: Enable IPv6 typeconversion specifier

Message ID 20220908115905.70928-7-v.v.mitrofanov@yadro.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series IPv6 support | expand

Commit Message

Vyacheslav V. Mitrofanov Sept. 8, 2022, 11:58 a.m. UTC 
Add the possibility to recognize IPv6 address in print function.
To output IPv6 address use %pI6 specifier.

Series-changes: 3
- Substituted #if (...) for if (...) to get better readability

Signed-off-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
---
 lib/vsprintf.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Simon Glass Sept. 9, 2022, 2:44 p.m. UTC | #1 
On Thu, 8 Sept 2022 at 05:59, Viacheslav Mitrofanov
<v.v.mitrofanov@yadro.com> wrote:
>
> Add the possibility to recognize IPv6 address in print function.
> To output IPv6 address use %pI6 specifier.
>
> Series-changes: 3
> - Substituted #if (...) for if (...) to get better readability
>
> Signed-off-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
> ---
>  lib/vsprintf.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index fe06aa2d71..530d8088c7 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -450,10 +450,6 @@  static char *uuid_string(char *buf, char *end, u8 *addr, int field_width,
  *       decimal for v4 and colon separated network-order 16 bit hex for v6)
  * - 'i' [46] for 'raw' IPv4/IPv6 addresses, IPv6 omits the colons, IPv4 is
  *       currently the same
- *
- * Note: IPv6 support is currently if(0)'ed out. If you ever need
- * %pI6, please add an IPV6 Kconfig knob, make your code select or
- * depend on that, and change the 0 below to CONFIG_IS_ENABLED(IPV6).
  */
 static char *pointer(const char *fmt, char *buf, char *end, void *ptr,
 		int field_width, int precision, int flags)
@@ -498,8 +494,7 @@  static char *pointer(const char *fmt, char *buf, char *end, void *ptr,
 		flags |= SPECIAL;
 		/* Fallthrough */
 	case 'I':
-		/* %pI6 currently unused */
-		if (0 && fmt[1] == '6')
+		if (IS_ENABLED(CONFIG_IPV6) && fmt[1] == '6')
 			return ip6_addr_string(buf, end, ptr, field_width,
 					       precision, flags);
 		if (fmt[1] == '4')