diff mbox series

arch: arm: mach-socfpga: To notify SDM when SPL pass control to U-Boot

Message ID 20220830155217.17886-1-jit.loon.lim@intel.com
State Needs Review / ACK, archived
Delegated to: Marek Vasut
Headers show
Series arch: arm: mach-socfpga: To notify SDM when SPL pass control to U-Boot | expand

Commit Message

Jit Loon Lim Aug. 30, 2022, 3:52 p.m. UTC 
From: Chin Liang See <chin.liang.see@intel.com>

Prior SPL pass control to U-Boot, SPL will send a mailbox command
"HPS_STAGE_NOTIFY" to notify Secure Device Manager (SDM) on HPS SW
transition.

The purpose is for debug as user can query SDM on HPS error details
when HPS enters a warm reset due to error such as watchdog.

Signed-off-by: Jit Loon Lim <jit.loon.lim@intel.com>
---
 arch/arm/mach-socfpga/spl_s10.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Chee, Tien Fong Sept. 9, 2022, 4:32 a.m. UTC | #1 
> -----Original Message-----
> From: Lim, Jit Loon <jit.loon.lim@intel.com>
> Sent: Tuesday, 30 August, 2022 11:52 PM
> To: u-boot@lists.denx.de
> Cc: Jagan Teki <jagan@amarulasolutions.com>; Vignesh R <vigneshr@ti.com>;
> Vasut, Marek <marex@denx.de>; Simon <simon.k.r.goldschmidt@gmail.com>;
> Chee, Tien Fong <tien.fong.chee@intel.com>; Hea, Kok Kiang
> <kok.kiang.hea@intel.com>; Lim, Elly Siew Chin <elly.siew.chin.lim@intel.com>;
> Kho, Sin Hui <sin.hui.kho@intel.com>; Lokanathan, Raaj
> <raaj.lokanathan@intel.com>; Maniyam, Dinesh <dinesh.maniyam@intel.com>;
> Ng, Boon Khai <boon.khai.ng@intel.com>; Yuslaimi, Alif Zakuan
> <alif.zakuan.yuslaimi@intel.com>; Chong, Teik Heng
> <teik.heng.chong@intel.com>; Zamri, Muhammad Hazim Izzat
> <muhammad.hazim.izzat.zamri@intel.com>; Tang, Sieu Mun
> <sieu.mun.tang@intel.com>; Lim, Jit Loon <jit.loon.lim@intel.com>; Chin Liang
> See <chin.liang.see@intel.com>
> Subject: [PATCH] arch: arm: mach-socfpga: To notify SDM when SPL pass
> control to U-Boot
> 
> From: Chin Liang See <chin.liang.see@intel.com>
> 
> Prior SPL pass control to U-Boot, SPL will send a mailbox command
> "HPS_STAGE_NOTIFY" to notify Secure Device Manager (SDM) on HPS SW
> transition.
> 
> The purpose is for debug as user can query SDM on HPS error details when HPS
> enters a warm reset due to error such as watchdog.
> 
> Signed-off-by: Jit Loon Lim <jit.loon.lim@intel.com>
> ---
>  arch/arm/mach-socfpga/spl_s10.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm/mach-socfpga/spl_s10.c b/arch/arm/mach-
> socfpga/spl_s10.c index c20e87cdbe..9bfd1a0f6a 100644
> --- a/arch/arm/mach-socfpga/spl_s10.c
> +++ b/arch/arm/mach-socfpga/spl_s10.c
> @@ -92,3 +92,9 @@ void board_init_f(ulong dummy)
>  	mbox_qspi_open();
>  #endif
>  }
> +
> +/* board specific function prior loading SSBL / U-Boot */ void
> +spl_board_prepare_for_boot(void) {
> +	mbox_hps_stage_notify(HPS_EXECUTION_STATE_SSBL);
> +}

You should put this notify into spl_perform_fixups(), so this can used by both boot flows:
SPL -> U-Boot and SPL -> ATF -> U-Boot.

Regards
Tien Fong
diff mbox series

Patch

diff --git a/arch/arm/mach-socfpga/spl_s10.c b/arch/arm/mach-socfpga/spl_s10.c
index c20e87cdbe..9bfd1a0f6a 100644
--- a/arch/arm/mach-socfpga/spl_s10.c
+++ b/arch/arm/mach-socfpga/spl_s10.c
@@ -92,3 +92,9 @@  void board_init_f(ulong dummy)
 	mbox_qspi_open();
 #endif
 }
+
+/* board specific function prior loading SSBL / U-Boot */
+void spl_board_prepare_for_boot(void)
+{
+	mbox_hps_stage_notify(HPS_EXECUTION_STATE_SSBL);
+}