diff mbox series

[13/17] test: dm: eth: Add csum_ipv6_magic test

Message ID 20220830123104.256224-14-v.v.mitrofanov@yadro.com
State Superseded
Delegated to: Ramon Fried
Headers show
Series IPv6 support | expand

Commit Message

Vyacheslav V. Mitrofanov Aug. 30, 2022, 12:31 p.m. UTC
Test checksum computation. csum_ipv6_magic() uses in upper layer
protocols as TCP/UDP/ICMPv6/etc to calculate payload checksum.

Signed-off-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
---
 test/dm/eth.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

Comments

Simon Glass Sept. 1, 2022, 2:27 a.m. UTC | #1
Hi Viacheslav,

On Tue, 30 Aug 2022 at 07:03, Viacheslav Mitrofanov
<v.v.mitrofanov@yadro.com> wrote:
>
> Test checksum computation. csum_ipv6_magic() uses in upper layer
> protocols as TCP/UDP/ICMPv6/etc to calculate payload checksum.
>
> Signed-off-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
> ---
>  test/dm/eth.c | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/test/dm/eth.c b/test/dm/eth.c
> index 4cc90cf514..bbfa14ef6d 100644
> --- a/test/dm/eth.c
> +++ b/test/dm/eth.c
> @@ -70,6 +70,35 @@ static int dm_test_string_to_ip6(struct unit_test_state *uts)
>  }
>  DM_TEST(dm_test_string_to_ip6, 0);
>
> +static int dm_test_csum_ipv6_magic(struct unit_test_state *uts)
> +{
> +       unsigned short csum = 0xBEEF;

lower-case hex consistently

> +       /* Predefined correct parameters */
> +       unsigned short correct_csum = 0xD8AC;
> +       struct in6_addr saddr = {.s6_addr32[0] = 0x000080fe,
> +                                .s6_addr32[1] = 0x00000000,
> +                                .s6_addr32[2] = 0xffe9f242,
> +                                .s6_addr32[3] = 0xe8f66dfe};
> +       struct in6_addr daddr = {.s6_addr32[0] = 0x000080fe,
> +                                .s6_addr32[1] = 0x00000000,
> +                                .s6_addr32[2] = 0xffd5b372,
> +                                .s6_addr32[3] = 0x3ef692fe};
> +       u16 len = 1460;
> +       unsigned short proto = 17;
> +       unsigned int head_csum = 0x91f0;
> +
> +       csum = csum_ipv6_magic(&saddr, &daddr, len, proto, head_csum);
> +       ut_assert(csum == correct_csum);

ut_asserteq

> +
> +       /* Broke a parameter */
> +       proto--;
> +       csum = csum_ipv6_magic(&saddr, &daddr, len, proto, head_csum);
> +       ut_assert(csum != correct_csum);
> +
> +       return 0;
> +}
> +DM_TEST(dm_test_csum_ipv6_magic, 0);
> +
>  static int dm_test_eth(struct unit_test_state *uts)
>  {
>         net_ping_ip = string_to_ip("1.1.2.2");
> --
> 2.25.1
>

Regards,
Simon
diff mbox series

Patch

diff --git a/test/dm/eth.c b/test/dm/eth.c
index 4cc90cf514..bbfa14ef6d 100644
--- a/test/dm/eth.c
+++ b/test/dm/eth.c
@@ -70,6 +70,35 @@  static int dm_test_string_to_ip6(struct unit_test_state *uts)
 }
 DM_TEST(dm_test_string_to_ip6, 0);
 
+static int dm_test_csum_ipv6_magic(struct unit_test_state *uts)
+{
+	unsigned short csum = 0xBEEF;
+	/* Predefined correct parameters */
+	unsigned short correct_csum = 0xD8AC;
+	struct in6_addr saddr = {.s6_addr32[0] = 0x000080fe,
+				 .s6_addr32[1] = 0x00000000,
+				 .s6_addr32[2] = 0xffe9f242,
+				 .s6_addr32[3] = 0xe8f66dfe};
+	struct in6_addr daddr = {.s6_addr32[0] = 0x000080fe,
+				 .s6_addr32[1] = 0x00000000,
+				 .s6_addr32[2] = 0xffd5b372,
+				 .s6_addr32[3] = 0x3ef692fe};
+	u16 len = 1460;
+	unsigned short proto = 17;
+	unsigned int head_csum = 0x91f0;
+
+	csum = csum_ipv6_magic(&saddr, &daddr, len, proto, head_csum);
+	ut_assert(csum == correct_csum);
+
+	/* Broke a parameter */
+	proto--;
+	csum = csum_ipv6_magic(&saddr, &daddr, len, proto, head_csum);
+	ut_assert(csum != correct_csum);
+
+	return 0;
+}
+DM_TEST(dm_test_csum_ipv6_magic, 0);
+
 static int dm_test_eth(struct unit_test_state *uts)
 {
 	net_ping_ip = string_to_ip("1.1.2.2");