| Message ID | 20220827120051.28092-1-pali@kernel.org |
|---|---|
| State | Accepted |
| Commit | 8ac3615e8d73f6be446bc25ae17d4f38f3cbf371 |
| Delegated to: | Stefan Roese |
| Headers | show |
| Series | arm: mvebu: Espressobin: When emmc is not present disable it also in OF_LIVE | expand |
Hi Pali, On Sat, 27 Aug 2022 at 06:01, Pali Rohár <pali@kernel.org> wrote: > This patch is missing a motivation. Please always add a commit message. > Signed-off-by: Pali Rohár <pali@kernel.org> > --- > board/Marvell/mvebu_armada-37xx/board.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c > index 5ae133879f32..45779198b678 100644 > --- a/board/Marvell/mvebu_armada-37xx/board.c > +++ b/board/Marvell/mvebu_armada-37xx/board.c > @@ -132,6 +132,8 @@ int board_late_init(void) > dev = mmc_dev->dev; > device_remove(dev, DM_REMOVE_NORMAL); > device_unbind(dev); > + if (of_live_active()) > + ofnode_set_enabled(dev_ofnode(dev), false); > } > > /* Ensure that 'env default -a' set correct value to $fdtfile */ > -- > 2.20.1 > Regards, Simon
On 27.08.22 14:00, Pali Rohár wrote: > Signed-off-by: Pali Rohár <pali@kernel.org> As mentioned by Simon, please add a short sentence in the commit text as well. Other than that: Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan > --- > board/Marvell/mvebu_armada-37xx/board.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c > index 5ae133879f32..45779198b678 100644 > --- a/board/Marvell/mvebu_armada-37xx/board.c > +++ b/board/Marvell/mvebu_armada-37xx/board.c > @@ -132,6 +132,8 @@ int board_late_init(void) > dev = mmc_dev->dev; > device_remove(dev, DM_REMOVE_NORMAL); > device_unbind(dev); > + if (of_live_active()) > + ofnode_set_enabled(dev_ofnode(dev), false); > } > > /* Ensure that 'env default -a' set correct value to $fdtfile */ Viele Grüße, Stefan Roese
On 27.08.22 14:00, Pali Rohár wrote: > Signed-off-by: Pali Rohár <pali@kernel.org> Applied to u-boot-marvell/master Thanks, Stefan > --- > board/Marvell/mvebu_armada-37xx/board.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c > index 5ae133879f32..45779198b678 100644 > --- a/board/Marvell/mvebu_armada-37xx/board.c > +++ b/board/Marvell/mvebu_armada-37xx/board.c > @@ -132,6 +132,8 @@ int board_late_init(void) > dev = mmc_dev->dev; > device_remove(dev, DM_REMOVE_NORMAL); > device_unbind(dev); > + if (of_live_active()) > + ofnode_set_enabled(dev_ofnode(dev), false); > } > > /* Ensure that 'env default -a' set correct value to $fdtfile */ Viele Grüße, Stefan Roese
diff --git a/board/Marvell/mvebu_armada-37xx/board.c b/board/Marvell/mvebu_armada-37xx/board.c index 5ae133879f32..45779198b678 100644 --- a/board/Marvell/mvebu_armada-37xx/board.c +++ b/board/Marvell/mvebu_armada-37xx/board.c @@ -132,6 +132,8 @@ int board_late_init(void) dev = mmc_dev->dev; device_remove(dev, DM_REMOVE_NORMAL); device_unbind(dev); + if (of_live_active()) + ofnode_set_enabled(dev_ofnode(dev), false); } /* Ensure that 'env default -a' set correct value to $fdtfile */
Signed-off-by: Pali Rohár <pali@kernel.org> --- board/Marvell/mvebu_armada-37xx/board.c | 2 ++ 1 file changed, 2 insertions(+)