diff mbox series

[v5,3/8] rockchip: remove binman temporary files when cleaning

Message ID 20220826153634.3086393-4-foss+uboot@0leil.net
State Superseded
Delegated to: Kever Yang
Headers show
Series migrate u-boot-rockchip.bin to binman and generate an image for SPI | expand

Commit Message

Quentin Schulz Aug. 26, 2022, 3:36 p.m. UTC
From: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Binman mkimage entry generates temporary files so let's remove them
when calling `make clean`.

Fixes: 9b312e26fc77 ("rockchip: Enable building a SPI ROM image on jerry")
Cc: Quentin Schulz <foss+uboot@0leil.net>
Reported-by: Johan Jonker <jbx6244@gmail.com>
Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
---

added in v3

 Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Simon Glass Aug. 27, 2022, 12:21 a.m. UTC | #1
On Fri, 26 Aug 2022 at 09:37, Quentin Schulz <foss+uboot@0leil.net> wrote:
>
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> Binman mkimage entry generates temporary files so let's remove them
> when calling `make clean`.
>
> Fixes: 9b312e26fc77 ("rockchip: Enable building a SPI ROM image on jerry")
> Cc: Quentin Schulz <foss+uboot@0leil.net>
> Reported-by: Johan Jonker <jbx6244@gmail.com>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> ---
>
> added in v3
>
>  Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>


>
> diff --git a/Makefile b/Makefile
> index 541e942ed5..5750a9e4b8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2225,7 +2225,8 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h \
>                lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \
>                idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \
>                mkimage-out.spl.mkimage mkimage.spl.mkimage imx-boot.map \
> -              itb.fit.fit itb.fit.itb itb.map spl.map
> +              itb.fit.fit itb.fit.itb itb.map spl.map mkimage-out.rom.mkimage \
> +              mkimage.rom.mkimage rom.map simple-bin.map
>
>  # Directories & files removed with 'make mrproper'
>  MRPROPER_DIRS  += include/config include/generated spl tpl \
> --
> 2.37.2
>
Kever Yang Sept. 1, 2022, 12:04 p.m. UTC | #2
On 2022/8/26 23:36, Quentin Schulz wrote:
> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>
> Binman mkimage entry generates temporary files so let's remove them
> when calling `make clean`.
>
> Fixes: 9b312e26fc77 ("rockchip: Enable building a SPI ROM image on jerry")
> Cc: Quentin Schulz <foss+uboot@0leil.net>
> Reported-by: Johan Jonker <jbx6244@gmail.com>
> Signed-off-by: Quentin Schulz <quentin.schulz@theobroma-systems.com>

Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
> added in v3
>
>   Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 541e942ed5..5750a9e4b8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2225,7 +2225,8 @@ CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h \
>   	       lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \
>   	       idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \
>   	       mkimage-out.spl.mkimage mkimage.spl.mkimage imx-boot.map \
> -	       itb.fit.fit itb.fit.itb itb.map spl.map
> +	       itb.fit.fit itb.fit.itb itb.map spl.map mkimage-out.rom.mkimage \
> +	       mkimage.rom.mkimage rom.map simple-bin.map
>   
>   # Directories & files removed with 'make mrproper'
>   MRPROPER_DIRS  += include/config include/generated spl tpl \
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index 541e942ed5..5750a9e4b8 100644
--- a/Makefile
+++ b/Makefile
@@ -2225,7 +2225,8 @@  CLEAN_FILES += include/bmp_logo.h include/bmp_logo_data.h \
 	       lpc32xx-* bl31.c bl31.elf bl31_*.bin image.map tispl.bin* \
 	       idbloader.img flash.bin flash.log defconfig keep-syms-lto.c \
 	       mkimage-out.spl.mkimage mkimage.spl.mkimage imx-boot.map \
-	       itb.fit.fit itb.fit.itb itb.map spl.map
+	       itb.fit.fit itb.fit.itb itb.map spl.map mkimage-out.rom.mkimage \
+	       mkimage.rom.mkimage rom.map simple-bin.map
 
 # Directories & files removed with 'make mrproper'
 MRPROPER_DIRS  += include/config include/generated spl tpl \