From patchwork Wed Aug 24 11:38:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ashok Reddy Soma X-Patchwork-Id: 1669761 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-xilinx-onmicrosoft-com header.b=CZbx6m1O; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4MCPJc6Sdyz1yhJ for ; Wed, 24 Aug 2022 21:39:28 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5BA318480F; Wed, 24 Aug 2022 13:39:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="CZbx6m1O"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4033F8418B; Wed, 24 Aug 2022 13:39:14 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2074.outbound.protection.outlook.com [40.107.92.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 85D3484194 for ; Wed, 24 Aug 2022 13:39:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ashokred@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EmljF+WN70uqQv6Py1HjQPI3pKihpRFH0yWez+FJXYhykEVUG9noQlSAY/uIe0EGVrHQH88tUnC9DAhrQcJLtk4MSA4vs+VjINqGFl1+qF8Tt7zu5SmI5J8B2aJcgwIMOZ/ZEEOPb4JovcLNgEM5Q6rb9/MDPMAEoOjRGaLgNKygKEc7rDRFqIMPNdKwT1F8kBVuq0aXPvoIept70wbJk/5UOkkX57SpoIIP3zJpW7GqGoNnc4yJX8EaMY2vzjMoV9WCVSl1AhC/LoyyekW7JYTp8mRkPxMFYOKc6mqnItueDHVJCl6R3byesm0Z0znA+ZUDG20+q8mCkUr4vPFM/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h3YF3jPDxHMewsJZezmC0aZcc1mNUMlys0rdxqZsb/8=; b=I0pGb/cykp6A1ghP/UUbdwwRMCfP77JmsKjbPBr8pcA6WETbPH2pZMbhSMBNmut58drUa86ycGHuq7DFJ8t4uo+pnkdK2FVPO70xm67lBl5jbvUD5W24hxGZOGWF3yWLTwPWBc+/YnaJbV08Nw9GCOy0c2+p8bbJ4mfeb0rRxiFny75SoP55Oon/eCadWxNJfygmQ9zR3/jSg/17GwcYoWT4rWYubc4ByqIwvZQIL28uN7frZUVl3xnSEXgLDG8jNpTgzQz3qaLRl/0kBzn9ywE5n1bdDb7KJrP/tgxB7haizZGb7rGyMcCUZOgFwcBRxyRXcF7o3uPqaqLATCvbzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h3YF3jPDxHMewsJZezmC0aZcc1mNUMlys0rdxqZsb/8=; b=CZbx6m1O3z+bQ+jThf92dJBncKQ0kfREUt0QgXkuOWrg/Bi0yiGOSB0CT7t9iwure7rn37me8sLgmhtycmWVeFu75BEf9OTNoFY1OuIS0n2sgIKjkAYPHI7xWF9DGEmtQJ98A3TWbE6Pdt31Z6Kq60V3lucJ00BEamo+BTgf2as= Received: from SA1PR02CA0014.namprd02.prod.outlook.com (2603:10b6:806:2cf::21) by SA2PR02MB7530.namprd02.prod.outlook.com (2603:10b6:806:149::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.19; Wed, 24 Aug 2022 11:39:08 +0000 Received: from SN1NAM02FT0020.eop-nam02.prod.protection.outlook.com (2603:10b6:806:2cf:cafe::c1) by SA1PR02CA0014.outlook.office365.com (2603:10b6:806:2cf::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.21 via Frontend Transport; Wed, 24 Aug 2022 11:39:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch01.xlnx.xilinx.com; pr=C Received: from xsj-pvapexch01.xlnx.xilinx.com (149.199.62.198) by SN1NAM02FT0020.mail.protection.outlook.com (10.97.5.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5566.15 via Frontend Transport; Wed, 24 Aug 2022 11:39:07 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch01.xlnx.xilinx.com (172.19.86.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Wed, 24 Aug 2022 04:39:05 -0700 Received: from smtp.xilinx.com (172.19.127.96) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Wed, 24 Aug 2022 04:39:05 -0700 Envelope-to: git@xilinx.com, u-boot@lists.denx.de, jagan@amarulasolutions.com, michal.simek@amd.com, git@amd.com Received: from [10.140.6.65] (port=45366 helo=xhdashokred41.xilinx.com) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oQoiv-0002ax-2d; Wed, 24 Aug 2022 04:39:05 -0700 From: Ashok Reddy Soma To: CC: , , , , Ashok Reddy Soma Subject: [PATCH 1/3] spi: cadence-qspi: Correct flash reset function name Date: Wed, 24 Aug 2022 05:38:45 -0600 Message-ID: <20220824113847.7482-2-ashok.reddy.soma@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220824113847.7482-1-ashok.reddy.soma@xilinx.com> References: <20220824113847.7482-1-ashok.reddy.soma@xilinx.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 796580f6-7db2-4161-ab1f-08da85c54119 X-MS-TrafficTypeDiagnostic: SA2PR02MB7530:EE_ X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hXuFPi9QfVivMs1SUvnz020sAOPLdeOIo+w2F5VAPQZpD0m5qMMGVpq3ZcAIHYU/uvrrSo7uu26uPT+zUPt7zPUgkZAmFcMAHtSPkqloO4/uBdq67ADKrdQK3KKTqAA/NbAbfQHQf6aVC1YpS4MiyU0odC4pNAg6yZdMGPtskxHIESb38dNtzBjm1YzKaUKvxHUBipuDvj/mgdZ5RPBcM406o+qu+10Te5JwRfQz8jKjFwzzTq73VAo1skXMSJEt68FG7PoWnv9bq4mx3D7x8vAjb7fAqqqvbxMBu98vJecgGauwLGoEZWD7xs4NkhonCa5Pl2zjJ8lSkKEPxeuMS/nw2N898C2ba3Dok+2WlFG+sFxYAtFDo+4LmCBGUyeAQx6BoW7AeKMu+ONrJ8MKm0XJc6NyRpZSj4Rb/3NdqfPCFh4XXqv+9mvVX6V140A1OQXt9bPp+cw9JaZt91c3LyRw+BoYPLCz7zUyictUW9iglHjQoXgQ3R48hNrrPBvheVi1pbPXhIuU+GGPqFHmjVGX+ZpLCZVpjzxaKiadxclJ3kCQimbeEx+oxZepSthDV+FoTvsXan72gbDAs394i2NxTjeufLjOlRdafksqSXKbu+6FhlOcW1PyqYjcK7P+Uhz/XsqAqk44f3TPw6hyGOhR3YV2QIUJkKjx0Yt0+79oJQ2xiWtHmInBn3eDbo++jue83pU4h2ZHP9jv+t3Dphr/U+pqXbi1xpnIK9ty9Z9GYnu/7MR1tXgOgV0QGXkh2IrDTS5HpYBkWtMdOFsf+z13L8vcFdr7P05OtuOE6vQ= X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch01.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(376002)(346002)(39860400002)(396003)(36840700001)(46966006)(40470700004)(6916009)(8676002)(54906003)(9786002)(36756003)(5660300002)(8936002)(7696005)(6666004)(107886003)(2616005)(336012)(186003)(26005)(1076003)(478600001)(47076005)(41300700001)(103116003)(2906002)(356005)(40460700003)(4326008)(40480700001)(83380400001)(70206006)(316002)(82740400003)(36860700001)(70586007)(82310400005)(7636003)(426003)(102446001); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 11:39:07.2505 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 796580f6-7db2-4161-ab1f-08da85c54119 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0020.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR02MB7530 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean In cadence_spi_probe, cadence_qspi_versal_flash_reset() is called to reset the flash device. Looks like there is a mistake in previous series of patches where it is defined as cadence_spi_versal_flash_reset() but called as cadence_qspi_versal_flash_reset. Since there is a weak function defined with the same name this issue was not caught. Fix the issue by renaming cadence_spi_versal_flash_reset as cadence_qspi_versal_flash_reset(). Signed-off-by: Ashok Reddy Soma --- drivers/spi/cadence_ospi_versal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/cadence_ospi_versal.c b/drivers/spi/cadence_ospi_versal.c index 52bcad053f..c756a854bc 100644 --- a/drivers/spi/cadence_ospi_versal.c +++ b/drivers/spi/cadence_ospi_versal.c @@ -128,7 +128,7 @@ int cadence_qspi_apb_wait_for_dma_cmplt(struct cadence_spi_plat *plat) } #if defined(CONFIG_DM_GPIO) -int cadence_spi_versal_flash_reset(struct udevice *dev) +int cadence_qspi_versal_flash_reset(struct udevice *dev) { struct gpio_desc gpio; u32 reset_gpio; @@ -169,7 +169,7 @@ int cadence_spi_versal_flash_reset(struct udevice *dev) return 0; } #else -int cadence_spi_versal_flash_reset(struct udevice *dev) +int cadence_qspi_versal_flash_reset(struct udevice *dev) { /* CRP WPROT */ writel(0, WPROT_CRP);