| Message ID | 20220801185701.3803727-1-trini@konsulko.com |
|---|---|
| State | Accepted, archived |
| Commit | 3b706f3d872a8e41b9470f2a42d97bf83fecd506 |
| Delegated to: | Heinrich Schuchardt |
| Headers | show |
| Series | doc: develop: Add a note about importing code from other projects | expand |
On Mon, Aug 01, 2022 at 02:57:01PM -0400, Tom Rini wrote: > We talk about importing code from other projects in two places. The > first place is in the coding style section, where we explain when to or > not to deviate in terms of white space, etc. In the process > documentation we now add a note about saying where the code was imported > from and to ensure that you do not copy Signed-off-by or other tags. > > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > Given Sudeep's feedback just now on another series, it makes sense to > note this in the documentation, for future reference. Thanks for the quick response in the form of patch. That is super fast and efficient 😄. Acked-by: Sudeep Holla <sudeep.holla@arm.com>
diff --git a/doc/develop/process.rst b/doc/develop/process.rst index 0ef24e819982..388945cf9bb9 100644 --- a/doc/develop/process.rst +++ b/doc/develop/process.rst @@ -139,6 +139,10 @@ like this: as the Linux kernel. Following this and adding a ``Signed-off-by:`` line that contains the developer's name and email address is required. + * Please note that when importing code from other projects you must say + where it comes from, and what revision you are importing. You must not + however copy ``Signed-off-by`` or other tags. + #. Everybody who can is invited to review and test the changes. Typically, we follow the same guidelines as the Linux kernel for `Acked-by <https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by>`_
We talk about importing code from other projects in two places. The first place is in the coding style section, where we explain when to or not to deviate in terms of white space, etc. In the process documentation we now add a note about saying where the code was imported from and to ensure that you do not copy Signed-off-by or other tags. Signed-off-by: Tom Rini <trini@konsulko.com> --- Given Sudeep's feedback just now on another series, it makes sense to note this in the documentation, for future reference. --- doc/develop/process.rst | 4 ++++ 1 file changed, 4 insertions(+)