diff mbox series

ARM: mvebu: x530: set MPP55 to gpio

Message ID 20220502031625.1725916-1-judge.packham@gmail.com
State Accepted
Commit 08dc62c1527ec7401cc98719cde50ca47533a7c2
Delegated to: Stefan Roese
Headers show
Series ARM: mvebu: x530: set MPP55 to gpio | expand

Commit Message

Chris Packham May 2, 2022, 3:16 a.m. UTC
MPP55 is used as a reset connected to the L3 switch chip. This doesn't
matter for u-boot as it doesn't use the L3 switch but it is useful to
be able to toggle the switch in/out of reset for the OS.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
I sent this out a while back but it was part of a series that has been dropped
for the time being. There's not reason to hold this change up behind the other
so I'm sending it as a standalong change.

 board/alliedtelesis/x530/x530.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Roese May 2, 2022, 5:23 a.m. UTC | #1
On 02.05.22 05:16, Chris Packham wrote:
> MPP55 is used as a reset connected to the L3 switch chip. This doesn't
> matter for u-boot as it doesn't use the L3 switch but it is useful to
> be able to toggle the switch in/out of reset for the OS.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> I sent this out a while back but it was part of a series that has been dropped
> for the time being. There's not reason to hold this change up behind the other
> so I'm sending it as a standalong change.

Good.

> 
>   board/alliedtelesis/x530/x530.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c
> index c0ec2afa3011..cbf4533e78de 100644
> --- a/board/alliedtelesis/x530/x530.c
> +++ b/board/alliedtelesis/x530/x530.c
> @@ -93,7 +93,7 @@ int board_early_init_f(void)
>   	writel(0x55550550, MVEBU_MPP_BASE + 0x0c);
>   	writel(0x55555555, MVEBU_MPP_BASE + 0x10);
>   	writel(0x00100565, MVEBU_MPP_BASE + 0x14);
> -	writel(0x40000000, MVEBU_MPP_BASE + 0x18);
> +	writel(0x00000000, MVEBU_MPP_BASE + 0x18);
>   	writel(0x00004444, MVEBU_MPP_BASE + 0x1c);
>   
>   	return 0;

Viele Grüße,
Stefan Roese
Stefan Roese May 2, 2022, 3:45 p.m. UTC | #2
On 02.05.22 05:16, Chris Packham wrote:
> MPP55 is used as a reset connected to the L3 switch chip. This doesn't
> matter for u-boot as it doesn't use the L3 switch but it is useful to
> be able to toggle the switch in/out of reset for the OS.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> I sent this out a while back but it was part of a series that has been dropped
> for the time being. There's not reason to hold this change up behind the other
> so I'm sending it as a standalong change.

Applied to u-boot-marvell/master

Thanks,
Stefan


>   board/alliedtelesis/x530/x530.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c
> index c0ec2afa3011..cbf4533e78de 100644
> --- a/board/alliedtelesis/x530/x530.c
> +++ b/board/alliedtelesis/x530/x530.c
> @@ -93,7 +93,7 @@ int board_early_init_f(void)
>   	writel(0x55550550, MVEBU_MPP_BASE + 0x0c);
>   	writel(0x55555555, MVEBU_MPP_BASE + 0x10);
>   	writel(0x00100565, MVEBU_MPP_BASE + 0x14);
> -	writel(0x40000000, MVEBU_MPP_BASE + 0x18);
> +	writel(0x00000000, MVEBU_MPP_BASE + 0x18);
>   	writel(0x00004444, MVEBU_MPP_BASE + 0x1c);
>   
>   	return 0;

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/board/alliedtelesis/x530/x530.c b/board/alliedtelesis/x530/x530.c
index c0ec2afa3011..cbf4533e78de 100644
--- a/board/alliedtelesis/x530/x530.c
+++ b/board/alliedtelesis/x530/x530.c
@@ -93,7 +93,7 @@  int board_early_init_f(void)
 	writel(0x55550550, MVEBU_MPP_BASE + 0x0c);
 	writel(0x55555555, MVEBU_MPP_BASE + 0x10);
 	writel(0x00100565, MVEBU_MPP_BASE + 0x14);
-	writel(0x40000000, MVEBU_MPP_BASE + 0x18);
+	writel(0x00000000, MVEBU_MPP_BASE + 0x18);
 	writel(0x00004444, MVEBU_MPP_BASE + 0x1c);
 
 	return 0;