diff mbox series

arm: mvebu: clearfog_defconfig: enable setexpr command

Message ID 20220429154914.34278-1-pepe.schlehofer@gmail.com
State Accepted
Commit af767e9a3da6b1ce899ee3942d470b9a9dee2d95
Delegated to: Stefan Roese
Headers show
Series arm: mvebu: clearfog_defconfig: enable setexpr command | expand

Commit Message

Josef Schlehofer April 29, 2022, 3:49 p.m. UTC
This command is useful in U-boot scripts and it is being used by
OpenWrt bootscript for this board [1]. Otherwise shell scripting
commands are enabled by default in cmd/Kconfig.

[1] https://github.com/openwrt/openwrt/blob/852126680e21edc71c0c66561ae5a6d7479dcc67/target/linux/mvebu/image/clearfog.bootscript#L7

[2] https://source.denx.de/u-boot/u-boot/-/blob/e95afa56753cebcd20a5114b6d121f281b789006/cmd/Kconfig#L1504

Fixes: 0299c90f396c5b2971a4bac596339f4b03661c27 ("arm: mvebu: Add
SolidRun ClearFog Armada 38x initial support")

Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
---
 configs/clearfog_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Stefan Roese May 2, 2022, 5:25 a.m. UTC | #1
On 29.04.22 17:49, Josef Schlehofer wrote:
> This command is useful in U-boot scripts and it is being used by
> OpenWrt bootscript for this board [1]. Otherwise shell scripting
> commands are enabled by default in cmd/Kconfig.
> 
> [1] https://github.com/openwrt/openwrt/blob/852126680e21edc71c0c66561ae5a6d7479dcc67/target/linux/mvebu/image/clearfog.bootscript#L7
> 
> [2] https://source.denx.de/u-boot/u-boot/-/blob/e95afa56753cebcd20a5114b6d121f281b789006/cmd/Kconfig#L1504
> 
> Fixes: 0299c90f396c5b2971a4bac596339f4b03661c27 ("arm: mvebu: Add
> SolidRun ClearFog Armada 38x initial support")
> 
> Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   configs/clearfog_defconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig
> index 880f16a6e0..1e9c389deb 100644
> --- a/configs/clearfog_defconfig
> +++ b/configs/clearfog_defconfig
> @@ -34,7 +34,6 @@ CONFIG_CMD_MMC=y
>   CONFIG_CMD_PCI=y
>   CONFIG_CMD_SPI=y
>   CONFIG_CMD_USB=y
> -# CONFIG_CMD_SETEXPR is not set
>   CONFIG_CMD_TFTPPUT=y
>   CONFIG_CMD_CACHE=y
>   CONFIG_CMD_TIME=y

Viele Grüße,
Stefan Roese
Stefan Roese May 2, 2022, 3:45 p.m. UTC | #2
On 29.04.22 17:49, Josef Schlehofer wrote:
> This command is useful in U-boot scripts and it is being used by
> OpenWrt bootscript for this board [1]. Otherwise shell scripting
> commands are enabled by default in cmd/Kconfig.
> 
> [1] https://github.com/openwrt/openwrt/blob/852126680e21edc71c0c66561ae5a6d7479dcc67/target/linux/mvebu/image/clearfog.bootscript#L7
> 
> [2] https://source.denx.de/u-boot/u-boot/-/blob/e95afa56753cebcd20a5114b6d121f281b789006/cmd/Kconfig#L1504
> 
> Fixes: 0299c90f396c5b2971a4bac596339f4b03661c27 ("arm: mvebu: Add
> SolidRun ClearFog Armada 38x initial support")
> 
> Signed-off-by: Josef Schlehofer <pepe.schlehofer@gmail.com>

Applied to u-boot-marvell/master

Thanks,
Stefan

> ---
>   configs/clearfog_defconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig
> index 880f16a6e0..1e9c389deb 100644
> --- a/configs/clearfog_defconfig
> +++ b/configs/clearfog_defconfig
> @@ -34,7 +34,6 @@ CONFIG_CMD_MMC=y
>   CONFIG_CMD_PCI=y
>   CONFIG_CMD_SPI=y
>   CONFIG_CMD_USB=y
> -# CONFIG_CMD_SETEXPR is not set
>   CONFIG_CMD_TFTPPUT=y
>   CONFIG_CMD_CACHE=y
>   CONFIG_CMD_TIME=y

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/configs/clearfog_defconfig b/configs/clearfog_defconfig
index 880f16a6e0..1e9c389deb 100644
--- a/configs/clearfog_defconfig
+++ b/configs/clearfog_defconfig
@@ -34,7 +34,6 @@  CONFIG_CMD_MMC=y
 CONFIG_CMD_PCI=y
 CONFIG_CMD_SPI=y
 CONFIG_CMD_USB=y
-# CONFIG_CMD_SETEXPR is not set
 CONFIG_CMD_TFTPPUT=y
 CONFIG_CMD_CACHE=y
 CONFIG_CMD_TIME=y