diff mbox series

[2/3] imx: imx8mq: default select CLK_IMX8MQ

Message ID 20220429080149.29344-2-peng.fan@oss.nxp.com
State Superseded
Delegated to: Stefano Babic
Headers show
Series [1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN | expand

Commit Message

Peng Fan (OSS) April 29, 2022, 8:01 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Since the power domain driver default select CONFIG_CLK, so we will
meet lots failures without CLK_IMX8MQ, so default select it.

Fixes: commit 4eb82c2e56a7c ("imx: power-domain: Get rid of SMCCC dependency")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm/mach-imx/imx8m/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Adam Ford April 30, 2022, 1:49 p.m. UTC | #1 
On Fri, Apr 29, 2022 at 2:20 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Since the power domain driver default select CONFIG_CLK, so we will
> meet lots failures without CLK_IMX8MQ, so default select it.
>

There is a related patch [1] that I submitted for all imx8m SoC's t
select their respective CLK_IMX8M[MNPQ]

adam

[1] - https://patchwork.ozlabs.org/project/uboot/patch/20220417221647.2390750-1-aford173@gmail.com/

> Fixes: commit 4eb82c2e56a7c ("imx: power-domain: Get rid of SMCCC dependency")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm/mach-imx/imx8m/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
> index 24299ae037f..7f23d687be3 100644
> --- a/arch/arm/mach-imx/imx8m/Kconfig
> +++ b/arch/arm/mach-imx/imx8m/Kconfig
> @@ -8,6 +8,7 @@ config IMX8M
>  config IMX8MQ
>         bool
>         select IMX8M
> +       select CLK_IMX8MQ
>
>  config IMX8MM
>         bool
> --
> 2.36.0
>
Peng Fan (OSS) May 1, 2022, 9:44 a.m. UTC | #2 
On 2022/4/30 21:49, Adam Ford wrote:
> On Fri, Apr 29, 2022 at 2:20 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>>
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Since the power domain driver default select CONFIG_CLK, so we will
>> meet lots failures without CLK_IMX8MQ, so default select it.
>>
> 
> There is a related patch [1] that I submitted for all imx8m SoC's t
> select their respective CLK_IMX8M[MNPQ]

Actually default select CLK_IMX8MQ will not make i.MX8MQ bootable,
patch 1 in this patchset still needed. If possible, you could take
my patch 1 in your patchset and drop patch 2 in this patchset.

Thanks,
Peng.

> 
> adam
> 
> [1] - https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20220417221647.2390750-1-aford173%40gmail.com%2F&amp;data=05%7C01%7Cpeng.fan%40nxp.com%7C48339c3e1efe45476e6d08da2ab04211%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637869233759129025%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=wZCdJR%2BVf%2BpeBkq%2BtGA%2FcXkxY5GUPUfU%2FeyPtrc%2Bpn0%3D&amp;reserved=0
> 
>> Fixes: commit 4eb82c2e56a7c ("imx: power-domain: Get rid of SMCCC dependency")
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>   arch/arm/mach-imx/imx8m/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
>> index 24299ae037f..7f23d687be3 100644
>> --- a/arch/arm/mach-imx/imx8m/Kconfig
>> +++ b/arch/arm/mach-imx/imx8m/Kconfig
>> @@ -8,6 +8,7 @@ config IMX8M
>>   config IMX8MQ
>>          bool
>>          select IMX8M
>> +       select CLK_IMX8MQ
>>
>>   config IMX8MM
>>          bool
>> --
>> 2.36.0
>>
diff mbox series

Patch

diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
index 24299ae037f..7f23d687be3 100644
--- a/arch/arm/mach-imx/imx8m/Kconfig
+++ b/arch/arm/mach-imx/imx8m/Kconfig
@@ -8,6 +8,7 @@  config IMX8M
 config IMX8MQ
 	bool
 	select IMX8M
+	select CLK_IMX8MQ
 
 config IMX8MM
 	bool