diff mbox series

[u-boot-marvell,02/19] net: mvneta: Fix 10Mbps speed

Message ID 20220427104202.1205-3-kabel@kernel.org
State Accepted
Commit 47f0e8e21a16a97963b639df3529759840730d65
Delegated to: Stefan Roese
Headers show
Series some mvneta changes, cleanups, fixes | expand

Commit Message

Marek Behún April 27, 2022, 10:41 a.m. UTC 
From: Marek Behún <marek.behun@nic.cz>

In mvneta_adjust_link() we need to set MII_SPEED bit only if PHY reports
the speed at 100Mbps.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
---
 drivers/net/mvneta.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ramon Fried April 30, 2022, 11:28 p.m. UTC | #1 
On Wed, Apr 27, 2022 at 1:42 PM Marek Behún <kabel@kernel.org> wrote:
>
> From: Marek Behún <marek.behun@nic.cz>
>
> In mvneta_adjust_link() we need to set MII_SPEED bit only if PHY reports
> the speed at 100Mbps.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
>  drivers/net/mvneta.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c
> index d1c5f7930d..79cdb93341 100644
> --- a/drivers/net/mvneta.c
> +++ b/drivers/net/mvneta.c
> @@ -1195,7 +1195,7 @@ static void mvneta_adjust_link(struct udevice *dev)
>
>                         if (phydev->speed == SPEED_1000)
>                                 val |= MVNETA_GMAC_CONFIG_GMII_SPEED;
> -                       else
> +                       else if (pp->speed == SPEED_100)
>                                 val |= MVNETA_GMAC_CONFIG_MII_SPEED;
>
>                         mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val);
> --
> 2.35.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Stefan Roese May 2, 2022, 6:48 a.m. UTC | #2 
On 27.04.22 12:41, Marek Behún wrote:
> From: Marek Behún <marek.behun@nic.cz>
> 
> In mvneta_adjust_link() we need to set MII_SPEED bit only if PHY reports
> the speed at 100Mbps.
> 
> Signed-off-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan


> ---
>   drivers/net/mvneta.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c
> index d1c5f7930d..79cdb93341 100644
> --- a/drivers/net/mvneta.c
> +++ b/drivers/net/mvneta.c
> @@ -1195,7 +1195,7 @@ static void mvneta_adjust_link(struct udevice *dev)
>   
>   			if (phydev->speed == SPEED_1000)
>   				val |= MVNETA_GMAC_CONFIG_GMII_SPEED;
> -			else
> +			else if (pp->speed == SPEED_100)
>   				val |= MVNETA_GMAC_CONFIG_MII_SPEED;
>   
>   			mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val);

Viele Grüße,
Stefan Roese
diff mbox series

Patch

diff --git a/drivers/net/mvneta.c b/drivers/net/mvneta.c
index d1c5f7930d..79cdb93341 100644
--- a/drivers/net/mvneta.c
+++ b/drivers/net/mvneta.c
@@ -1195,7 +1195,7 @@  static void mvneta_adjust_link(struct udevice *dev)
 
 			if (phydev->speed == SPEED_1000)
 				val |= MVNETA_GMAC_CONFIG_GMII_SPEED;
-			else
+			else if (pp->speed == SPEED_100)
 				val |= MVNETA_GMAC_CONFIG_MII_SPEED;
 
 			mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val);