From patchwork Tue Mar 1 10:35:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Niklas Cassel X-Patchwork-Id: 1599357 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=A19RHUEc; dkim=pass (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-sharedspace-onmicrosoft-com header.b=dcSgn0C6; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4K7GwT1pxFz9sFh for ; Tue, 1 Mar 2022 23:37:13 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C374083BBE; Tue, 1 Mar 2022 13:36:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=wdc.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="A19RHUEc"; dkim=pass (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="dcSgn0C6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 958B283C9B; Tue, 1 Mar 2022 11:35:55 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.2 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 59FEB83C8F for ; Tue, 1 Mar 2022 11:35:48 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=wdc.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=prvs=052f00158=Niklas.Cassel@wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1646130947; x=1677666947; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fsezkIzXdqzwPTN1RMHe7VWxS8J2LGSz9vZ3I6FNj+k=; b=A19RHUEc4+eCC9OYNnBhcS+UAU6G6GD0KEB5bk6U9dgksvdFjthRyjnW d110j3FMT7NFox7zpNyiUq3JsjGL635B9C5uKj81kmBj7ZU7tPCF8kFzi JkWok5tosX7IMr5hVXiyjg4fZIP/GPjh5f8IccbunlgW0ET/Q5vs0BskK FB0JsA/wHq3BjMvh+ueyAjXLZ5Aez9gPrN1dayCzzSncPtnMwlM1PJmfP IkBc8xhCaJ5o1weI7+vIdXDZY0zvjuZRH7y9tniIlNJ/UGb2aq+L0sz1x 6ygqFn7cq3fAnbpglK3TTnKLYl3j9WnnXLbtJI4/5ii+4tvBGZGHbP2Qx A==; X-IronPort-AV: E=Sophos;i="5.90,145,1643644800"; d="scan'208";a="199026915" Received: from mail-bn8nam08lp2043.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.43]) by ob1.hgst.iphmx.com with ESMTP; 01 Mar 2022 18:35:44 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aVAS6Jk5EhmN+gy4kuBCckM/aSZTuMXWwzpcLKATjqupohaqk+K8QrE/mqFMcPcDI488yPYOb+8O2Ny87xl6lBmzOFMsqHL/SXre/LtNydgIyws5PqAONSFlmayGpf7PZQFbdqCJSF4F6HkxGkYcyIn4tXwLbxo2P+hJe6z9P7ZbGoWwADPRVLTucGUQc+fKbUPtNHZYFrlSRsAtONgkxSo5lRZqJK7ofasMheYOMQQMBfWDVD54O0zlAIM4dNjD/ujdNn/MyOvCrkX/YkTDa1BEe6qMTHa9MAIoIWyVFletqb7wc0jDbDGszNiAaQvw0x0fJVNEIfMCW1cxzEwfJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ForeOHH2W8/5WJ56+mGD7QC3/3NOvAyr9ThWWd+uTz0=; b=WJAsHqLeqCIZeBS+rZ/PS2NRH/ZXT2kBhXfmtXEwa4BYGiNPq5gKHtf8jeY/I2PT53qTVqcng2v9lH6XKEVfJYVeytxzFXMvbOKeUIWfTpDEEfCv6kp0IKbgQ4oEGgZ6lCbt7y2SsWdk16PUL2No/oXnc5RM0RMPLajJX9kYdNHu8PVTtchZUog0HWR2OpXnHDIQ4io0VM96s+np3VUfjryv/6njE8pAH8mjOVEMLnFCO9aP+/P+I02aSvE5BzKMEbu2UvkVrmT36REEF/ATho0crvpSqPYKpd6kpWsHrUd0h9/1WVGwY2jKKA9NRhFSxtrpSI8eOF2YgRR6JXrvpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=wdc.com; dmarc=pass action=none header.from=wdc.com; dkim=pass header.d=wdc.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector2-sharedspace-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ForeOHH2W8/5WJ56+mGD7QC3/3NOvAyr9ThWWd+uTz0=; b=dcSgn0C6gdFCwanYGKavocztn+XBC1CnSOE7EZni2zXPuNFuE9MbrE+UnuD0haiAIcF+qtcFkiG09RTmyPTDCvhHubRBi2fh9XkDS7ycvrWcOzO+6cgvqIS0oM2T3UFhM6FrgVDvlsTEMc09+7LFNQHGi5zlH1PS/kOLYIswPNA= Received: from PH0PR04MB7158.namprd04.prod.outlook.com (2603:10b6:510:8::18) by MN2PR04MB6910.namprd04.prod.outlook.com (2603:10b6:208:1ea::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.23; Tue, 1 Mar 2022 10:35:44 +0000 Received: from PH0PR04MB7158.namprd04.prod.outlook.com ([fe80::f025:4f23:8e46:b2ed]) by PH0PR04MB7158.namprd04.prod.outlook.com ([fe80::f025:4f23:8e46:b2ed%2]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 10:35:44 +0000 From: Niklas Cassel To: Jagan Teki , Simon Glass , Stefan Roese CC: "damien.lemoal@opensource.wdc.com" , Sean Anderson , Niklas Cassel , "u-boot@lists.denx.de" Subject: [PATCH v2 6/8] spi: dw: Actually mask interrupts Thread-Topic: [PATCH v2 6/8] spi: dw: Actually mask interrupts Thread-Index: AQHYLVgaQDokQF4Y8ECYA8jWDRiNQQ== Date: Tue, 1 Mar 2022 10:35:43 +0000 Message-ID: <20220301103529.3060257-7-Niklas.Cassel@wdc.com> References: <20220301103529.3060257-1-Niklas.Cassel@wdc.com> In-Reply-To: <20220301103529.3060257-1-Niklas.Cassel@wdc.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.35.1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=wdc.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37203f54-b369-403c-9e99-08d9fb6f3d7b x-ms-traffictypediagnostic: MN2PR04MB6910:EE_ x-microsoft-antispam-prvs: wdcipoutbound: EOP-TRUE x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DxM60FMu4vAkGYRaQcMwtYKWr8A1up/51WBy6O0Svaomf6oik2RXUkmAuCAlMKrhe3Q9XdJZQRY6IYfESVTbLP42CUbE/7Q1vwEr/+cjIOVHAaUAKRaQ1XrywRtmiHBCGlZcijfWk/++VkDSdIC2lVG0/6obijkxMrc9irL8nR30dfdQOk7oPgHJW2wgdIVhd2jauF4MGxo5L25NiAg0C1pCwgRg1nLsTCqHhOnSqsSYXwVlF7kf2wahf+/sjbi8CVcBiB3qLPiyrq4PLfTkLGdzMdfMsOU4UCN48XJhD3GM0Y2/xXHx7g4d2J5Qw5bZITZf2Rwv83OILANQm/GfJvQ1KqrPN6Q/WM6F+bKB+M5L/ZJLX/10ryQAu0Uial2zepySxGl/LlfRKnnB0dEs3xHmOmSgngqBHr6fZg77C9ft3Nco4f0QEdyzzEM5LPFxg3y/Deu0o1yb/Sg8GY0G8qAiCRreiZK7pSzowZaVfGhS27J/R0CkLIyTaYuh+9oJ4rSzUtvCS1hzfMXZFkOJw3kIrIyYTdzVFx9ZulK9Q75p9C87aVZNWHoN5Vozs1feZoWRYdF4PVmpeAuZ1+MLgULxfweu/Zk3iUFVHtO+DMbuVwcbzj/lEUYEAG0cUqmkYr9/YaGvSGaZrRYJT6DW4jNx6vS08HT+yQxMw1QWRV6jDNFfPWA38On2GiZFXTHnmA3/DTkbKZqcRZ7obnyXaQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR04MB7158.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(5660300002)(83380400001)(26005)(2906002)(122000001)(186003)(2616005)(1076003)(82960400001)(86362001)(38070700005)(38100700002)(76116006)(508600001)(110136005)(54906003)(91956017)(6506007)(316002)(6512007)(71200400001)(6486002)(66476007)(36756003)(64756008)(66556008)(8936002)(8676002)(4326008)(66946007)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?q?o8BMcigjANQqem0SjnJj2lZ?= =?iso-8859-1?q?xSqRtEHGXK4fRoHt/1/nOk5H9l0v67J6i3QOqvuTInUIASAef0QoLCzyWMQT?= =?iso-8859-1?q?lBR6C+99UBmPN7BKL0dHcGHs0RgkezmAK7XdObTsYRdGGgD8u9TpVaN7ssNb?= =?iso-8859-1?q?6xPRBOS68kL/aClmIhkfFccAY1RQkHUEmqMKQAWXRARPgfoE2xNZWCKxNOF+?= =?iso-8859-1?q?A1oUUZXTg07m5rUAlApV0InCwQR8EYSGkFs7BCB9SS3X6r1p0e1YBD2T8f5U?= =?iso-8859-1?q?N9WES0je7g9ctaVysyU9GchpopGb7nR7nPEb0pkhglQ91zDpSAO8kDX6iRax?= =?iso-8859-1?q?maNCn++0qWjpK8IOzddFCbL8wLac7ffF4QfHqdyQjQMSKLdHiwQ2uYu27QIo?= =?iso-8859-1?q?q26RKaUYO58RCi4tM03QCI1SuJfbo5hYWYKuICYniB7rgxLOpZlXezPjqBaw?= =?iso-8859-1?q?k6tGxBm7H0DKvbtQErWxw9B36BLQe0UbtzsOxB+vkbAveqUCLZ+tDoE+DC/b?= =?iso-8859-1?q?8j7Ufixsh1moSgxkKQM13z5Onor/Ur7PtCVERGdhnw9a1pWNnfuoffEaNCSy?= =?iso-8859-1?q?RRUR3fYZyKPeskdTcv4VCBYSH1ehvcBkufUrNm2qKcztbKlysS7n8AX7ftMR?= =?iso-8859-1?q?whSRBUBuRjaVcmZAlUuVWLs37KVVc/QW279dG4Uu6vAzXuDrGYS1FDs0VAxe?= =?iso-8859-1?q?ptiIIOfqcI+Jw5jj84W253NcYazI7HGIPoyDblRqZ7xM1i9ADo6fHjCihex/?= =?iso-8859-1?q?Ei7GQe/kfta2gnns2x0Y9PyaZvOYuW3KlUPH+Ml7KMZHpJ9y7UaaVQSOfkJn?= =?iso-8859-1?q?VFFHIsKrQHrtlrl+PsSVZcNXFeFFrGFOGFiDLUpGUGxnCwWneUAo9+EwWzHK?= =?iso-8859-1?q?Vth/XFJlpzkU6DPXlJQq9a54Xv2fu0SsFfzSyJzmYdynxN8rvh5FlJecok9Z?= =?iso-8859-1?q?F6XspgApmLrQq/WcRxMoCl/4L4rcLHrdA2RvXs1ziOvdCAZ5S6V1f1E6PAmW?= =?iso-8859-1?q?DcQlRroWAmyOYkZ79P61LTdEhoAsoZOkps+cNZDXAMV+1a8ggAfGMhfgniJt?= =?iso-8859-1?q?gBgOe0oBxqwEMZSD5ZJd2uDHTK0R7kUqwtyLOaPQSfBmVATk0W7vtOu88AMd?= =?iso-8859-1?q?bi3RSB94xVlRAHYYtTsxA/ldBzHsEgzd3nyEKirxjmOsDLrslzYLy2yb5mOr?= =?iso-8859-1?q?XXd7g3OdJkrACZQL/1lbYh/9aL4XxFMx6ctbA7CTh+/Sq0Wx82bDHJ9xR+/j?= =?iso-8859-1?q?iJ7JLFRKpCO6iJIxs6MRrNCVe3rRkNwTHg6RTy1nBJIy5kXib72aGRAjEHx5?= =?iso-8859-1?q?/kOp5y4jLgUf/Ta33HZzsC0en7yuLPuz/jTT7aLbLvwPKqMSmVyDNZcHOQJm?= =?iso-8859-1?q?RGRBcwgQEjFDETBdcHEfsI5nGXTWNwCGifrvsJSpxj/Ax9vPzMMjXXEEKLB9?= =?iso-8859-1?q?XDr6Azo0tqco8rsFEq5d+bPCbwUTJ+yyWpVSI/95jIAyle3B/5y/YcXTzmAv?= =?iso-8859-1?q?CxfHo4p0y2uz2/PZhcVGYz1WTJ/NfV2crWp9wzLFMuAEgmV1KK+XQVtkzkZf?= =?iso-8859-1?q?Yn80oKbdZNI4GUqzB7jqTEoiZ/D9UjYkpfvvmHj8rvxXPvmm2h+iSk0yyZ5M?= =?iso-8859-1?q?66QQ9Rp/lx0hWN1Na4fs2kYRUtOKQe4QXqthKye4Wx8V/eVphI51evSKD0eH?= =?iso-8859-1?q?yVe85yQiZrh5G1xy5SWVn?= MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37203f54-b369-403c-9e99-08d9fb6f3d7b X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2022 10:35:43.9839 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dCOXuCeRJqzBCZ/B7un6VKi/R5gi1wRBOJ8+KvevnHQXbFs3JI332WQ0l32NEaRdqf5q44Mnh/J26fg6jXmFEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6910 X-Mailman-Approved-At: Tue, 01 Mar 2022 13:36:28 +0100 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean From: Sean Anderson The designware spi driver unconditionally uses polling. The comment to spi_hw_init() also states that the function should disable interrupts. According to the DesignWare DW_apb_ssi Databook, value 0xff in IMR enables all interrupts. Since we want to mask all interrupts write 0x0 instead. On the canaan k210 board, pressing the reset button twice to reset the board will run u-boot. If u-boot boots Linux without having SPI interrupts masked, Linux will hang as soon as interrupts are enabled, because of an interrupt storm. Properly masking the SPI interrupts in u-boot allows us to successfully boot Linux, even after resetting the board. Fixes: 5bef6fd79f94 ("spi: Add designware master SPI DM driver used on SoCFPGA") Signed-off-by: Sean Anderson [Niklas: rewrite commit message] Signed-off-by: Niklas Cassel Reviewed-by: Sean Anderson --- drivers/spi/designware_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/designware_spi.c b/drivers/spi/designware_spi.c index f9b19a5ea4..47bea0b376 100644 --- a/drivers/spi/designware_spi.c +++ b/drivers/spi/designware_spi.c @@ -266,7 +266,7 @@ static int dw_spi_of_to_plat(struct udevice *bus) static void spi_hw_init(struct udevice *bus, struct dw_spi_priv *priv) { dw_write(priv, DW_SPI_SSIENR, 0); - dw_write(priv, DW_SPI_IMR, 0xff); + dw_write(priv, DW_SPI_IMR, 0); dw_write(priv, DW_SPI_SSIENR, 1); /*