diff mbox series

serial: remove nulldev_serial_input

Message ID 20220202125318.4169517-1-hs@denx.de
State Accepted
Commit 0129f2d8ee41d221519287de2a7417f7431584c7
Delegated to: Simon Glass
Headers show
Series serial: remove nulldev_serial_input | expand

Commit Message

Heiko Schocher Feb. 2, 2022, 12:53 p.m. UTC
nulldev_serial_input is static and not used in this file,
so remove it.

Signed-off-by: Heiko Schocher <hs@denx.de>
---
azure build is clean
https://dev.azure.com/hs0298/hs/_build/results?buildId=78&view=results

 drivers/serial/serial_nulldev.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Simon Glass Feb. 8, 2022, 3:13 p.m. UTC | #1
On Wed, 2 Feb 2022 at 05:53, Heiko Schocher <hs@denx.de> wrote:
>
> nulldev_serial_input is static and not used in this file,
> so remove it.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> azure build is clean
> https://dev.azure.com/hs0298/hs/_build/results?buildId=78&view=results
>
>  drivers/serial/serial_nulldev.c | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Simon Glass Feb. 8, 2022, 8:39 p.m. UTC | #2
On Wed, 2 Feb 2022 at 05:53, Heiko Schocher <hs@denx.de> wrote:
>
> nulldev_serial_input is static and not used in this file,
> so remove it.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> azure build is clean
> https://dev.azure.com/hs0298/hs/_build/results?buildId=78&view=results
>
>  drivers/serial/serial_nulldev.c | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!
diff mbox series

Patch

diff --git a/drivers/serial/serial_nulldev.c b/drivers/serial/serial_nulldev.c
index efae14dd6c..f3ca7f5255 100644
--- a/drivers/serial/serial_nulldev.c
+++ b/drivers/serial/serial_nulldev.c
@@ -22,11 +22,6 @@  static int nulldev_serial_pending(struct udevice *dev, bool input)
 	return 0;
 }
 
-static int nulldev_serial_input(struct udevice *dev)
-{
-	return 0;
-}
-
 static int nulldev_serial_putc(struct udevice *dev, const char ch)
 {
 	return 0;