| Message ID | 20220201000315.1398716-1-trini@konsulko.com |
|---|---|
| State | Deferred |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | boot: Update default on USE_SPL_FIT_GENERATOR | expand |
Hi Tom, On Mon, 31 Jan 2022 at 17:03, Tom Rini <trini@konsulko.com> wrote: > > The use of CONFIG_SPL_FIT_GENERATOR is deprecated and should not be > used. Start by changing the current default option from enabled to only > enabled for the platforms still using it. > > Cc: Simon Glass <sjg@chromium.org> > Signed-off-by: Tom Rini <trini@konsulko.com> > --- > This change completes the migration for a number of platforms that were > tripping the warning before but not actually using a generator. > --- > boot/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> This landed in spam so I missed it. I have a similar patch in my series if I ever get time to finish it. But we can deal with any conflict later. Regards, Simon
On Tue, Feb 08, 2022 at 08:13:33AM -0700, Simon Glass wrote: > Hi Tom, > > On Mon, 31 Jan 2022 at 17:03, Tom Rini <trini@konsulko.com> wrote: > > > > The use of CONFIG_SPL_FIT_GENERATOR is deprecated and should not be > > used. Start by changing the current default option from enabled to only > > enabled for the platforms still using it. > > > > Cc: Simon Glass <sjg@chromium.org> > > Signed-off-by: Tom Rini <trini@konsulko.com> > > --- > > This change completes the migration for a number of platforms that were > > tripping the warning before but not actually using a generator. > > --- > > boot/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> > > This landed in spam so I missed it. I have a similar patch in my > series if I ever get time to finish it. But we can deal with any > conflict later. OK. Now that the first iMX PR has come through I _think_ the implicitly depended on binman patches there have come in and so this patch won't break anything. I'll pick this up soon along with other Kconfig migration/etc patches in the next day or two.
On Tue, Feb 08, 2022 at 10:22:34AM -0500, Tom Rini wrote: > On Tue, Feb 08, 2022 at 08:13:33AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 31 Jan 2022 at 17:03, Tom Rini <trini@konsulko.com> wrote: > > > > > > The use of CONFIG_SPL_FIT_GENERATOR is deprecated and should not be > > > used. Start by changing the current default option from enabled to only > > > enabled for the platforms still using it. > > > > > > Cc: Simon Glass <sjg@chromium.org> > > > Signed-off-by: Tom Rini <trini@konsulko.com> > > > --- > > > This change completes the migration for a number of platforms that were > > > tripping the warning before but not actually using a generator. > > > --- > > > boot/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > > > This landed in spam so I missed it. I have a similar patch in my > > series if I ever get time to finish it. But we can deal with any > > conflict later. > > OK. Now that the first iMX PR has come through I _think_ the implicitly > depended on binman patches there have come in and so this patch won't > break anything. I'll pick this up soon along with other Kconfig > migration/etc patches in the next day or two. So, I was wrong. There's still: configs/cgtqmx8_defconfig configs/imx8mm-icore-mx8mm-ctouch2_defconfig configs/imx8mm-icore-mx8mm-edimm2.2_defconfig configs/imx8qm_rom7720_a1_4G_defconfig that need migration and only the last of which has a patch that I see right now: https://patchwork.ozlabs.org/project/uboot/patch/20220126155204.25099-1-oliver.graute@kococonnector.com/ but I assume the other 3 could be done fairly quickly.
Hi Tom, On Tue, 8 Feb 2022 at 10:53, Tom Rini <trini@konsulko.com> wrote: > > On Tue, Feb 08, 2022 at 10:22:34AM -0500, Tom Rini wrote: > > On Tue, Feb 08, 2022 at 08:13:33AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 31 Jan 2022 at 17:03, Tom Rini <trini@konsulko.com> wrote: > > > > > > > > The use of CONFIG_SPL_FIT_GENERATOR is deprecated and should not be > > > > used. Start by changing the current default option from enabled to only > > > > enabled for the platforms still using it. > > > > > > > > Cc: Simon Glass <sjg@chromium.org> > > > > Signed-off-by: Tom Rini <trini@konsulko.com> > > > > --- > > > > This change completes the migration for a number of platforms that were > > > > tripping the warning before but not actually using a generator. > > > > --- > > > > boot/Kconfig | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Reviewed-by: Simon Glass <sjg@chromium.org> > > > > > > This landed in spam so I missed it. I have a similar patch in my > > > series if I ever get time to finish it. But we can deal with any > > > conflict later. > > > > OK. Now that the first iMX PR has come through I _think_ the implicitly > > depended on binman patches there have come in and so this patch won't > > break anything. I'll pick this up soon along with other Kconfig > > migration/etc patches in the next day or two. > > So, I was wrong. There's still: > configs/cgtqmx8_defconfig > configs/imx8mm-icore-mx8mm-ctouch2_defconfig > configs/imx8mm-icore-mx8mm-edimm2.2_defconfig > configs/imx8qm_rom7720_a1_4G_defconfig > that need migration and only the last of which has a patch that I see > right now: > https://patchwork.ozlabs.org/project/uboot/patch/20220126155204.25099-1-oliver.graute@kococonnector.com/ > but I assume the other 3 could be done fairly quickly. See the cover letter for the series I just sent for another one that is hidden in a Makefile. My series disables the IMX8 stuff which might be good enough since it is easy to migrate. Regards, Simon
diff --git a/boot/Kconfig b/boot/Kconfig index c8d5906cd304..38fc64595ca7 100644 --- a/boot/Kconfig +++ b/boot/Kconfig @@ -275,7 +275,7 @@ config SPL_FIT_SOURCE config USE_SPL_FIT_GENERATOR bool "Use a script to generate the .its script" - default y if SPL_FIT && (!ARCH_SUNXI && !RISCV) + default y if SPL_FIT && SPL_LOAD_FIT && (ARCH_ROCKCHIP || ARCH_ZYNQMP) config SPL_FIT_GENERATOR string ".its file generator script for U-Boot FIT image"
The use of CONFIG_SPL_FIT_GENERATOR is deprecated and should not be used. Start by changing the current default option from enabled to only enabled for the platforms still using it. Cc: Simon Glass <sjg@chromium.org> Signed-off-by: Tom Rini <trini@konsulko.com> --- This change completes the migration for a number of platforms that were tripping the warning before but not actually using a generator. --- boot/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)