From patchwork Mon Jan 17 15:38:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pali_Roh=C3=A1r?= X-Patchwork-Id: 1580896 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=DkUo+NRn; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4Jcx19651Rz9ssD for ; Tue, 18 Jan 2022 02:39:57 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 72253837D0; Mon, 17 Jan 2022 16:39:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="DkUo+NRn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 032E482FD5; Mon, 17 Jan 2022 16:39:32 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.2 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 708A4837C1 for ; Mon, 17 Jan 2022 16:39:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EAC88B810F4; Mon, 17 Jan 2022 15:39:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9EB12C36AEF; Mon, 17 Jan 2022 15:39:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642433962; bh=Rd0KCqEosX7zr/R9uCX60ZUW7+ExfJCk8OgiZr3rmVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DkUo+NRnRgJP7TnJJcf6vffXVZm3prn7P6/qRJdHsafn3pRqYCLXToUI0Y4sxSqLX nAMc32tQFJNAQPrwmMT5E2RMLijGbrS1SjLfG/lhFxoGB9HeV1v+/S3o5VqWgCI7fc tqh8vmoIb1r1eIPbS6tVbgsdPSsuqPnT2xXAYsd3zWWTBB+cVkW44vrsHWeIBSKQQW m7eO7Ca7At7tYutIOqVMKJtqb26zEUTS1fs6aOEWxXPikECfrTk4Mr4dRfI+EPY47S TNZ91vFXkrlVaXT2yumJQURGcnAt81JiMaARRi0BdQzgzqax3waL52F9A8LH9bvt+3 lo4/PMqN2E6Cw== Received: by pali.im (Postfix) id 5553F871; Mon, 17 Jan 2022 16:39:22 +0100 (CET) From: =?utf-8?q?Pali_Roh=C3=A1r?= To: Bin Meng , Simon Glass , Stefan Roese , =?utf-8?q?Marek_Beh=C3=BAn?= Cc: u-boot@lists.denx.de Subject: [PATCH 3/4] pci: Add checks for valid cmdline arguments Date: Mon, 17 Jan 2022 16:38:39 +0100 Message-Id: <20220117153840.31173-4-pali@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220117153840.31173-1-pali@kernel.org> References: <20220117153840.31173-1-pali@kernel.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Currently pci command ignores invalid cmdline arguments and do something. Add checks that all passed arguments were processed. Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese --- cmd/pci.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cmd/pci.c b/cmd/pci.c index 53edf0d90010..8d2c0c4b43dd 100644 --- a/cmd/pci.c +++ b/cmd/pci.c @@ -523,7 +523,12 @@ static int do_pci(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[]) } if (argc > 2 || (argc > 1 && cmd != 'r' && argv[1][0] != 's')) { busnum = hextoul(argv[argc - 1], NULL); + argc--; } + if (cmd == 'r' && argc > 2) + goto usage; + else if (cmd != 'r' && (argc > 2 || (argc == 2 && argv[1][0] != 's'))) + goto usage; } ret = uclass_get_device_by_seq(UCLASS_PCI, busnum, &bus); if (ret) {