| Message ID | 20220111170449.2514811-1-john@metanate.com |
|---|---|
| State | Accepted |
| Commit | e44d2f5df9baa9b604df4eaa4d42f89657170598 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | misc: mark write buffer const | expand |
On Tue, 11 Jan 2022 at 10:04, John Keeping <john@metanate.com> wrote: > > The write operation in misc_ops already takes a "const void *" buffer, > but misc_write() takes a mutable "void *". There's no reason for this, > so make misc_write() consistent with the standard write() prototype. > > Signed-off-by: John Keeping <john@metanate.com> > --- > drivers/misc/misc-uclass.c | 2 +- > include/misc.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Tue, Jan 11, 2022 at 05:04:49PM +0000, John Keeping wrote: > The write operation in misc_ops already takes a "const void *" buffer, > but misc_write() takes a mutable "void *". There's no reason for this, > so make misc_write() consistent with the standard write() prototype. > > Signed-off-by: John Keeping <john@metanate.com> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/drivers/misc/misc-uclass.c b/drivers/misc/misc-uclass.c index cbfacc3801..cfe9d562fa 100644 --- a/drivers/misc/misc-uclass.c +++ b/drivers/misc/misc-uclass.c @@ -26,7 +26,7 @@ int misc_read(struct udevice *dev, int offset, void *buf, int size) return ops->read(dev, offset, buf, size); } -int misc_write(struct udevice *dev, int offset, void *buf, int size) +int misc_write(struct udevice *dev, int offset, const void *buf, int size) { const struct misc_ops *ops = device_get_ops(dev); diff --git a/include/misc.h b/include/misc.h index 82ec2ce793..6f042625c9 100644 --- a/include/misc.h +++ b/include/misc.h @@ -28,7 +28,7 @@ int misc_read(struct udevice *dev, int offset, void *buf, int size); * * Return: number of bytes written if OK (may be < @size), -ve on error */ -int misc_write(struct udevice *dev, int offset, void *buf, int size); +int misc_write(struct udevice *dev, int offset, const void *buf, int size); /** * misc_ioctl() - Assert command to the device, optional.
The write operation in misc_ops already takes a "const void *" buffer, but misc_write() takes a mutable "void *". There's no reason for this, so make misc_write() consistent with the standard write() prototype. Signed-off-by: John Keeping <john@metanate.com> --- drivers/misc/misc-uclass.c | 2 +- include/misc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)