diff mbox series

Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled

Message ID 20220101185039.470766-1-marex@denx.de
State Accepted
Commit 0c5cc164a911e1e2ae9b4de7224a10cea0309491
Delegated to: Stefano Babic
Headers show
Series Makefile: imx: Do not call arch/arm/mach-imx flash.bin generation if BINMAN enabled | expand

Commit Message

Marek Vasut Jan. 1, 2022, 6:50 p.m. UTC
Skip running arch/arm/mach-imx flash.bin generation in case BINMAN is
enabled, otherwise the target in arch/arm/mach-imx/Makefile regenerates
the flash.bin again and produces corrupted result.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Peng Fan <peng.fan@oss.nxp.com>
Cc: Simon Glass <sjg@chromium.org>
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)

Comments

Simon Glass Jan. 12, 2022, 8:03 p.m. UTC | #1
On Sat, 1 Jan 2022 at 11:50, Marek Vasut <marex@denx.de> wrote:
>
> Skip running arch/arm/mach-imx flash.bin generation in case BINMAN is
> enabled, otherwise the target in arch/arm/mach-imx/Makefile regenerates
> the flash.bin again and produces corrupted result.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Peng Fan <peng.fan@oss.nxp.com>
> Cc: Simon Glass <sjg@chromium.org>
> ---
>  Makefile | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Stefano Babic Feb. 5, 2022, 4:43 p.m. UTC | #2
> Skip running arch/arm/mach-imx flash.bin generation in case BINMAN is
> enabled, otherwise the target in arch/arm/mach-imx/Makefile regenerates
> the flash.bin again and produces corrupted result.
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Peng Fan <peng.fan@oss.nxp.com>
> Cc: Simon Glass <sjg@chromium.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/Makefile b/Makefile
index ae9bfab91ac..c04caaebc8e 100644
--- a/Makefile
+++ b/Makefile
@@ -1517,7 +1517,6 @@  else
 ifeq ($(CONFIG_BINMAN),y)
 flash.bin: spl/u-boot-spl.bin $(INPUTS-y) FORCE
 	$(call if_changed,binman)
-	$(Q)$(MAKE) $(build)=arch/arm/mach-imx $@
 else
 flash.bin: spl/u-boot-spl.bin u-boot.itb FORCE
 	$(Q)$(MAKE) $(build)=arch/arm/mach-imx $@