| Message ID | 20211221041547.52964-1-joel.peshkin@broadcom.com |
|---|---|
| State | Accepted |
| Commit | 36a3b4ed5632d8da13e3b89796cfdd0683021224 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | BRCMNAND: Fix reporting of uncorrectable errors on subpages during page read | expand |
On Mon, 20 Dec 2021 at 21:15, Joel Peshkin <joel.peshkin@broadcom.com> wrote: > > Previously, a subpage with an uncorrectable error followed by a subpage > with a correctable error would return an erroneous correctable status. > > Signed-off-by: Joel Peshkin <joel.peshkin@broadcom.com> > Cc: Simon Glass <sjg@chromium.org> > --- > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> Note that we normally like to have the commit subject 60 chars at most. > > diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > index f8434ca..74c9348 100644 > --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c > +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c > @@ -1632,7 +1632,7 @@ static int brcmnand_read_by_pio(struct mtd_info *mtd, struct nand_chip *chip, > mtd->oobsize / trans, > host->hwcfg.sector_size_1k); > > - if (!ret) { > + if (ret != -EBADMSG) { > *err_addr = brcmnand_read_reg(ctrl, > BRCMNAND_UNCORR_ADDR) | > ((u64)(brcmnand_read_reg(ctrl, > -- > 1.8.3.1 >
On Mon, Dec 20, 2021 at 08:15:47PM -0800, Joel Peshkin wrote: > Previously, a subpage with an uncorrectable error followed by a subpage > with a correctable error would return an erroneous correctable status. > > Signed-off-by: Joel Peshkin <joel.peshkin@broadcom.com> > Cc: Simon Glass <sjg@chromium.org> > Reviewed-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/drivers/mtd/nand/raw/brcmnand/brcmnand.c b/drivers/mtd/nand/raw/brcmnand/brcmnand.c index f8434ca..74c9348 100644 --- a/drivers/mtd/nand/raw/brcmnand/brcmnand.c +++ b/drivers/mtd/nand/raw/brcmnand/brcmnand.c @@ -1632,7 +1632,7 @@ static int brcmnand_read_by_pio(struct mtd_info *mtd, struct nand_chip *chip, mtd->oobsize / trans, host->hwcfg.sector_size_1k); - if (!ret) { + if (ret != -EBADMSG) { *err_addr = brcmnand_read_reg(ctrl, BRCMNAND_UNCORR_ADDR) | ((u64)(brcmnand_read_reg(ctrl,
Previously, a subpage with an uncorrectable error followed by a subpage with a correctable error would return an erroneous correctable status. Signed-off-by: Joel Peshkin <joel.peshkin@broadcom.com> Cc: Simon Glass <sjg@chromium.org> --- drivers/mtd/nand/raw/brcmnand/brcmnand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)