| Message ID | 20211218211025.770362-3-festevam@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | [1/6] udoo_spl: Initialize the eSDHC controller in SPL | expand |
On Sat, Dec 18, 2021 at 9:10 PM Fabio Estevam <festevam@gmail.com> wrote: > > Calling gpio_request() prior to its usage is now mandatory. > > This fixes the following GPIO errors: > > U-Boot SPL 2022.01-rc3-00067-g7a5be871c0ec (Dec 18 2021 - 17:45:07 -0300) > Trying to boot from MMC1 > > > U-Boot 2022.01-rc3-00067-g7a5be871c0ec (Dec 18 2021 - 17:45:07 -0300) > > CPU: Freescale i.MX6Q rev1.2 at 792 MHz > Reset cause: WDOG > Model: Udoo i.MX6 Quad Board > Board: Udoo Quad > DRAM: 1 GiB > MMC: FSL_SDHC: 2 > Loading Environment from MMC... OK > In: serial > Out: serial > Err: serial > gpio@20a0000: set_dir_flags: error: gpio GPIO2_31 not reserved > gpio@20a4000: set_dir_flags: error: gpio GPIO3_23 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_24 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_25 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_27 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_28 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_29 not reserved > gpio@20a4000: set_value: error: gpio GPIO3_23 not reserved > Net: Could not get PHY for FEC0: addr -2 > No ethernet found. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Reviewed-by: Peter Robinson <pbrobinson@gmail.com> > --- > board/udoo/udoo.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/board/udoo/udoo.c b/board/udoo/udoo.c > index 5c49388cbfbe..9e0365615d6d 100644 > --- a/board/udoo/udoo.c > +++ b/board/udoo/udoo.c > @@ -90,6 +90,14 @@ int mx6_rgmii_rework(struct phy_device *phydev) > > static void setup_iomux_enet(void) > { > + gpio_request(IMX_GPIO_NR(2, 31), "eth_power"); > + gpio_request(IMX_GPIO_NR(3, 23), "eth_phy_reset"); > + gpio_request(IMX_GPIO_NR(6, 24), "strap1"); > + gpio_request(IMX_GPIO_NR(6, 25), "strap2"); > + gpio_request(IMX_GPIO_NR(6, 27), "strap3"); > + gpio_request(IMX_GPIO_NR(6, 28), "strap4"); > + gpio_request(IMX_GPIO_NR(6, 29), "strap5"); > + > gpio_direction_output(IMX_GPIO_NR(2, 31), 1); /* Power supply on */ > > gpio_direction_output(IMX_GPIO_NR(3, 23), 0); /* assert PHY rst */ > -- > 2.25.1 >
On Sat, Dec 18, 2021 at 06:10:22PM -0300, Fabio Estevam wrote: > Calling gpio_request() prior to its usage is now mandatory. > > This fixes the following GPIO errors: > > U-Boot SPL 2022.01-rc3-00067-g7a5be871c0ec (Dec 18 2021 - 17:45:07 -0300) > Trying to boot from MMC1 > > > U-Boot 2022.01-rc3-00067-g7a5be871c0ec (Dec 18 2021 - 17:45:07 -0300) > > CPU: Freescale i.MX6Q rev1.2 at 792 MHz > Reset cause: WDOG > Model: Udoo i.MX6 Quad Board > Board: Udoo Quad > DRAM: 1 GiB > MMC: FSL_SDHC: 2 > Loading Environment from MMC... OK > In: serial > Out: serial > Err: serial > gpio@20a0000: set_dir_flags: error: gpio GPIO2_31 not reserved > gpio@20a4000: set_dir_flags: error: gpio GPIO3_23 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_24 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_25 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_27 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_28 not reserved > gpio@20b0000: set_dir_flags: error: gpio GPIO6_29 not reserved > gpio@20a4000: set_value: error: gpio GPIO3_23 not reserved > Net: Could not get PHY for FEC0: addr -2 > No ethernet found. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > Reviewed-by: Peter Robinson <pbrobinson@gmail.com> Applied to u-boot/master, thanks!
diff --git a/board/udoo/udoo.c b/board/udoo/udoo.c index 5c49388cbfbe..9e0365615d6d 100644 --- a/board/udoo/udoo.c +++ b/board/udoo/udoo.c @@ -90,6 +90,14 @@ int mx6_rgmii_rework(struct phy_device *phydev) static void setup_iomux_enet(void) { + gpio_request(IMX_GPIO_NR(2, 31), "eth_power"); + gpio_request(IMX_GPIO_NR(3, 23), "eth_phy_reset"); + gpio_request(IMX_GPIO_NR(6, 24), "strap1"); + gpio_request(IMX_GPIO_NR(6, 25), "strap2"); + gpio_request(IMX_GPIO_NR(6, 27), "strap3"); + gpio_request(IMX_GPIO_NR(6, 28), "strap4"); + gpio_request(IMX_GPIO_NR(6, 29), "strap5"); + gpio_direction_output(IMX_GPIO_NR(2, 31), 1); /* Power supply on */ gpio_direction_output(IMX_GPIO_NR(3, 23), 0); /* assert PHY rst */
Calling gpio_request() prior to its usage is now mandatory. This fixes the following GPIO errors: U-Boot SPL 2022.01-rc3-00067-g7a5be871c0ec (Dec 18 2021 - 17:45:07 -0300) Trying to boot from MMC1 U-Boot 2022.01-rc3-00067-g7a5be871c0ec (Dec 18 2021 - 17:45:07 -0300) CPU: Freescale i.MX6Q rev1.2 at 792 MHz Reset cause: WDOG Model: Udoo i.MX6 Quad Board Board: Udoo Quad DRAM: 1 GiB MMC: FSL_SDHC: 2 Loading Environment from MMC... OK In: serial Out: serial Err: serial gpio@20a0000: set_dir_flags: error: gpio GPIO2_31 not reserved gpio@20a4000: set_dir_flags: error: gpio GPIO3_23 not reserved gpio@20b0000: set_dir_flags: error: gpio GPIO6_24 not reserved gpio@20b0000: set_dir_flags: error: gpio GPIO6_25 not reserved gpio@20b0000: set_dir_flags: error: gpio GPIO6_27 not reserved gpio@20b0000: set_dir_flags: error: gpio GPIO6_28 not reserved gpio@20b0000: set_dir_flags: error: gpio GPIO6_29 not reserved gpio@20a4000: set_value: error: gpio GPIO3_23 not reserved Net: Could not get PHY for FEC0: addr -2 No ethernet found. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- board/udoo/udoo.c | 8 ++++++++ 1 file changed, 8 insertions(+)