diff mbox series

[v4,1/6] clk: actions: Introduce dummy get/set_rate callbacks

Message ID 20211128113225.3992-2-atomar25opensource@gmail.com
State Accepted
Commit 234c1672a12f74141deab78b0bfcb37c886ba1b1
Delegated to: Tom Rini
Headers show
Series Add MMC/SD support for S700/S900 | expand

Commit Message

Amit Singh Tomar Nov. 28, 2021, 11:32 a.m. UTC
From: Amit Singh Tomar <amittomer25@gmail.com>

This commit introduces get/set_rate callbacks, these are dummy at
the moment, and can be used to get/set clock for various devices
based on the clk id.

Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
---
Changes since v3:
	* No changes.
Changes since v2:
	* No changes.
Changes since previous version:
	* Removed premature initialization to avoid
	  compiler warnings.
---
 drivers/clk/owl/clk_owl.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

Comments

Sean Anderson Jan. 15, 2022, 5:44 p.m. UTC | #1
On 11/28/21 6:32 AM, Amit Singh Tomar wrote:
> From: Amit Singh Tomar <amittomer25@gmail.com>
> 
> This commit introduces get/set_rate callbacks, these are dummy at
> the moment, and can be used to get/set clock for various devices
> based on the clk id.
> 
> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
> ---
> Changes since v3:
> 	* No changes.
> Changes since v2:
> 	* No changes.
> Changes since previous version:
> 	* Removed premature initialization to avoid
> 	  compiler warnings.
> ---
>   drivers/clk/owl/clk_owl.c | 26 ++++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
> 
> diff --git a/drivers/clk/owl/clk_owl.c b/drivers/clk/owl/clk_owl.c
> index 96ab7fed1f37..f78e5fa3f08d 100644
> --- a/drivers/clk/owl/clk_owl.c
> +++ b/drivers/clk/owl/clk_owl.c
> @@ -128,6 +128,30 @@ int owl_clk_disable(struct clk *clk)
>   	return 0;
>   }
>   
> +static ulong owl_clk_get_rate(struct clk *clk)
> +{
> +	ulong rate;
> +
> +	switch (clk->id) {
> +	default:
> +		return -ENOENT;

-ENOSYS please

> +	}
> +
> +	return rate;
> +}
> +
> +static ulong owl_clk_set_rate(struct clk *clk, ulong rate)
> +{
> +	ulong new_rate;
> +
> +	switch (clk->id) {
> +	default:
> +		return -ENOENT;

ditto

> +	}
> +
> +	return new_rate;
> +}
> +
>   static int owl_clk_probe(struct udevice *dev)
>   {
>   	struct owl_clk_priv *priv = dev_get_priv(dev);
> @@ -145,6 +169,8 @@ static int owl_clk_probe(struct udevice *dev)
>   static const struct clk_ops owl_clk_ops = {
>   	.enable = owl_clk_enable,
>   	.disable = owl_clk_disable,
> +	.get_rate = owl_clk_get_rate,
> +	.set_rate = owl_clk_set_rate,
>   };
>   
>   static const struct udevice_id owl_clk_ids[] = {
> 

With that fixed,

Reviewed-by: Sean Anderson <seanga2@gmail.com>
Tom Rini Jan. 18, 2022, 9:09 p.m. UTC | #2
On Sun, Nov 28, 2021 at 05:02:20PM +0530, Amit Singh Tomar wrote:

> From: Amit Singh Tomar <amittomer25@gmail.com>
> 
> This commit introduces get/set_rate callbacks, these are dummy at
> the moment, and can be used to get/set clock for various devices
> based on the clk id.
> 
> Signed-off-by: Amit Singh Tomar <amittomer25@gmail.com>
> Reviewed-by: Sean Anderson <seanga2@gmail.com>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/clk/owl/clk_owl.c b/drivers/clk/owl/clk_owl.c
index 96ab7fed1f37..f78e5fa3f08d 100644
--- a/drivers/clk/owl/clk_owl.c
+++ b/drivers/clk/owl/clk_owl.c
@@ -128,6 +128,30 @@  int owl_clk_disable(struct clk *clk)
 	return 0;
 }
 
+static ulong owl_clk_get_rate(struct clk *clk)
+{
+	ulong rate;
+
+	switch (clk->id) {
+	default:
+		return -ENOENT;
+	}
+
+	return rate;
+}
+
+static ulong owl_clk_set_rate(struct clk *clk, ulong rate)
+{
+	ulong new_rate;
+
+	switch (clk->id) {
+	default:
+		return -ENOENT;
+	}
+
+	return new_rate;
+}
+
 static int owl_clk_probe(struct udevice *dev)
 {
 	struct owl_clk_priv *priv = dev_get_priv(dev);
@@ -145,6 +169,8 @@  static int owl_clk_probe(struct udevice *dev)
 static const struct clk_ops owl_clk_ops = {
 	.enable = owl_clk_enable,
 	.disable = owl_clk_disable,
+	.get_rate = owl_clk_get_rate,
+	.set_rate = owl_clk_set_rate,
 };
 
 static const struct udevice_id owl_clk_ids[] = {