| Message ID | 20211012154129.19710-2-dsankouski@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Add support for Samsung 2017 A-series phones | expand |
Dear Dzmitry Sankouski, On Wed, 13 Oct 2021 at 00:42, Dzmitry Sankouski <dsankouski@gmail.com> wrote: > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > Cc: Minkyu Kang <mk7.kang@samsung.com> > --- > drivers/serial/serial_s5p.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c > index 6d09952a5d..caa9a4e5c1 100644 > --- a/drivers/serial/serial_s5p.c > +++ b/drivers/serial/serial_s5p.c > @@ -221,10 +221,12 @@ U_BOOT_DRIVER(serial_s5p) = { > > static inline void _debug_uart_init(void) > { > - struct s5p_uart *uart = (struct s5p_uart *)CONFIG_DEBUG_UART_BASE; > + if (IS_ENABLED(CONFIG_DEBUG_UART_SKIP_INIT)) { > + struct s5p_uart *uart = (struct s5p_uart > *)CONFIG_DEBUG_UART_BASE; > > - s5p_serial_init(uart); > - s5p_serial_baud(uart, CONFIG_DEBUG_UART_CLOCK, CONFIG_BAUDRATE); > + s5p_serial_init(uart); > + s5p_serial_baud(uart, CONFIG_DEBUG_UART_CLOCK, > CONFIG_BAUDRATE); > + } > } > > Please return if disabled. It looks cleaner. less change, less depth.
diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c index 6d09952a5d..caa9a4e5c1 100644 --- a/drivers/serial/serial_s5p.c +++ b/drivers/serial/serial_s5p.c @@ -221,10 +221,12 @@ U_BOOT_DRIVER(serial_s5p) = { static inline void _debug_uart_init(void) { - struct s5p_uart *uart = (struct s5p_uart *)CONFIG_DEBUG_UART_BASE; + if (IS_ENABLED(CONFIG_DEBUG_UART_SKIP_INIT)) { + struct s5p_uart *uart = (struct s5p_uart *)CONFIG_DEBUG_UART_BASE; - s5p_serial_init(uart); - s5p_serial_baud(uart, CONFIG_DEBUG_UART_CLOCK, CONFIG_BAUDRATE); + s5p_serial_init(uart); + s5p_serial_baud(uart, CONFIG_DEBUG_UART_CLOCK, CONFIG_BAUDRATE); + } } static inline void _debug_uart_putc(int ch)
Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> Cc: Minkyu Kang <mk7.kang@samsung.com> --- drivers/serial/serial_s5p.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)