diff mbox series

[v2] mtd: spi-nor-ids: Reinstate Micron MT25QL02G

Message ID 20211005085847.62761-1-marex@denx.de
State Accepted
Commit e8966138175644545fbd9ed741cbde572dd1ed1c
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series [v2] mtd: spi-nor-ids: Reinstate Micron MT25QL02G | expand

Commit Message

Marek Vasut Oct. 5, 2021, 8:58 a.m. UTC
This ID disappeared in 5b66fdb29dc ("mtd: spi: Remove unused files"),
add the ID back, since the chip is used on devices supported by U-Boot.

Fixes: 5b66fdb29dc ("mtd: spi: Remove unused files")
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Cc: Stefan Roese <sr@denx.de>
Cc: Vignesh R <vigneshr@ti.com>
---
V2: Enable 4B opcodes which are supported by this chip
---
 drivers/mtd/spi/spi-nor-ids.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Roese Oct. 5, 2021, 9:17 a.m. UTC | #1
On 05.10.21 10:58, Marek Vasut wrote:
> This ID disappeared in 5b66fdb29dc ("mtd: spi: Remove unused files"),
> add the ID back, since the chip is used on devices supported by U-Boot.
> 
> Fixes: 5b66fdb29dc ("mtd: spi: Remove unused files")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vignesh R <vigneshr@ti.com>
> ---
> V2: Enable 4B opcodes which are supported by this chip

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
>   drivers/mtd/spi/spi-nor-ids.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 4aef1ddd6e2..39af04cf795 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -195,6 +195,7 @@ const struct flash_info spi_nor_ids[] = {
>   	{ INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>   	{ INFO("mt25ql01g",   0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
>   	{ INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
> +	{ INFO("mt25ql02g",   0x20ba22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE | SPI_NOR_4B_OPCODES) },
>   #ifdef CONFIG_SPI_FLASH_MT35XU
>   	{ INFO("mt35xu512aba", 0x2c5b1a, 0,  128 * 1024,  512, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES | SPI_NOR_OCTAL_DTR_READ) },
>   #endif /* CONFIG_SPI_FLASH_MT35XU */
> 


Viele Grüße,
Stefan
Jagan Teki Oct. 8, 2021, 12:49 p.m. UTC | #2
On Tue, Oct 5, 2021 at 2:29 PM Marek Vasut <marex@denx.de> wrote:
>
> This ID disappeared in 5b66fdb29dc ("mtd: spi: Remove unused files"),
> add the ID back, since the chip is used on devices supported by U-Boot.
>
> Fixes: 5b66fdb29dc ("mtd: spi: Remove unused files")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Stefan Roese <sr@denx.de>
> Cc: Vignesh R <vigneshr@ti.com>
> ---
> V2: Enable 4B opcodes which are supported by this chip
> ---

Applied to u-boot-spi/master
Marek Vasut Oct. 22, 2021, 10:30 p.m. UTC | #3
On 10/8/21 2:49 PM, Jagan Teki wrote:
> On Tue, Oct 5, 2021 at 2:29 PM Marek Vasut <marex@denx.de> wrote:
>>
>> This ID disappeared in 5b66fdb29dc ("mtd: spi: Remove unused files"),
>> add the ID back, since the chip is used on devices supported by U-Boot.
>>
>> Fixes: 5b66fdb29dc ("mtd: spi: Remove unused files")
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
>> Cc: Jagan Teki <jagan@amarulasolutions.com>
>> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>> Cc: Stefan Roese <sr@denx.de>
>> Cc: Vignesh R <vigneshr@ti.com>
>> ---
>> V2: Enable 4B opcodes which are supported by this chip
>> ---
> 
> Applied to u-boot-spi/master

It seems u-boot-spi/master was last updated on August 5th and this patch 
still isn't in u-boot/master either. Any news ?
diff mbox series

Patch

diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 4aef1ddd6e2..39af04cf795 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -195,6 +195,7 @@  const struct flash_info spi_nor_ids[] = {
 	{ INFO("n25q00a",     0x20bb21, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt25ql01g",   0x21ba20, 0, 64 * 1024, 2048, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
 	{ INFO("mt25qu02g",   0x20bb22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE) },
+	{ INFO("mt25ql02g",   0x20ba22, 0, 64 * 1024, 4096, SECT_4K | USE_FSR | SPI_NOR_QUAD_READ | NO_CHIP_ERASE | SPI_NOR_4B_OPCODES) },
 #ifdef CONFIG_SPI_FLASH_MT35XU
 	{ INFO("mt35xu512aba", 0x2c5b1a, 0,  128 * 1024,  512, USE_FSR | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES | SPI_NOR_OCTAL_DTR_READ) },
 #endif /* CONFIG_SPI_FLASH_MT35XU */