diff mbox series

mtd: Add SPI Nor Flash chip GD25LQ256D ID

Message ID 20210930105329.438730-1-tekkamanv@163.com
State Superseded
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series mtd: Add SPI Nor Flash chip GD25LQ256D ID | expand

Commit Message

tekkamanv@163.com Sept. 30, 2021, 10:53 a.m. UTC 
From: "yanhong.wang" <yanhong.wang@starfivetech.com>

Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
---
 drivers/mtd/spi/spi-nor-ids.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Bin Meng Oct. 2, 2021, 2:15 p.m. UTC | #1 
On Thu, Sep 30, 2021 at 6:55 PM <tekkamanv@163.com> wrote:
>
> From: "yanhong.wang" <yanhong.wang@starfivetech.com>
>

Please add a brief commit message for this, like providing a datasheet
for reference:

https://www.gigadevice.com/datasheet/gd25lq256d/

> Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>

I believe the name should be spelled as "Yanhong Wang"

> ---
>  drivers/mtd/spi/spi-nor-ids.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index 4aef1ddd6e..35fa347c44 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -122,6 +122,11 @@ const struct flash_info spi_nor_ids[] = {
>                         SECT_4K | SPI_NOR_DUAL_READ |
>                         SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
>         },
> +       {
> +               INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
> +                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> +       },
>  #endif
>  #ifdef CONFIG_SPI_FLASH_ISSI           /* ISSI */
>         /* ISSI */

Otherwise LGTM:
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Jagan Teki Oct. 8, 2021, 12:58 p.m. UTC | #2 
On Thu, Sep 30, 2021 at 4:24 PM <tekkamanv@163.com> wrote:
>
> From: "yanhong.wang" <yanhong.wang@starfivetech.com>
>
> Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
> ---

Applied to u-boot-spi/master
Bin Meng Oct. 8, 2021, 3:13 p.m. UTC | #3 
HI Jagan,

On Fri, Oct 8, 2021 at 8:58 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
>
> On Thu, Sep 30, 2021 at 4:24 PM <tekkamanv@163.com> wrote:
> >
> > From: "yanhong.wang" <yanhong.wang@starfivetech.com>
> >
> > Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
> > ---
>
> Applied to u-boot-spi/master

Did you address my comments when applying?

Regards,
Bin
Jagan Teki Oct. 9, 2021, 8:51 a.m. UTC | #4 
Hi Bin,

On Fri, Oct 8, 2021 at 8:43 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> HI Jagan,
>
> On Fri, Oct 8, 2021 at 8:58 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> >
> > On Thu, Sep 30, 2021 at 4:24 PM <tekkamanv@163.com> wrote:
> > >
> > > From: "yanhong.wang" <yanhong.wang@starfivetech.com>
> > >
> > > Signed-off-by: yanhong.wang <yanhong.wang@starfivetech.com>
> > > ---
> >
> > Applied to u-boot-spi/master
>
> Did you address my comments when applying?

Yes.
diff mbox series

Patch

diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index 4aef1ddd6e..35fa347c44 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -122,6 +122,11 @@  const struct flash_info spi_nor_ids[] = {
 			SECT_4K | SPI_NOR_DUAL_READ |
 			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
 	},
+	{
+		INFO("gd25lq256d", 0xc86019, 0, 64 * 1024, 512,
+			SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
+	},
 #endif
 #ifdef CONFIG_SPI_FLASH_ISSI		/* ISSI */
 	/* ISSI */