diff mbox series

[4/4] net: dsa: felix: remove "xgmii" phy-mode

Message ID 20210918123237.1081530-5-vladimir.oltean@nxp.com
State Accepted
Commit 9bf2b962ff3585d570f3a46457f3d598c3ef301f
Delegated to: Ramon Fried
Headers show
Series phy-mode cleanup | expand

Commit Message

Vladimir Oltean Sept. 18, 2021, 12:32 p.m. UTC
The felix driver runs only on NXP LS1028A, which most definitely does
not support the parallel 10G interface, just USXGMII, and that only up
to 2.5Gbps (toned down from 10 Gbps via symbol replication).

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/mscc_eswitch/felix_switch.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ramon Fried Sept. 28, 2021, 1:30 p.m. UTC | #1
On Sat, Sep 18, 2021 at 3:34 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
>
> The felix driver runs only on NXP LS1028A, which most definitely does
> not support the parallel 10G interface, just USXGMII, and that only up
> to 2.5Gbps (toned down from 10 Gbps via symbol replication).
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/mscc_eswitch/felix_switch.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c
> index bd40c3b8b1bb..47ac45b354da 100644
> --- a/drivers/net/mscc_eswitch/felix_switch.c
> +++ b/drivers/net/mscc_eswitch/felix_switch.c
> @@ -222,7 +222,6 @@ static void felix_start_pcs(struct udevice *dev, int port,
>         case PHY_INTERFACE_MODE_QSGMII:
>                 felix_init_sgmii(imdio, port, autoneg);
>                 break;
> -       case PHY_INTERFACE_MODE_XGMII:
>         case PHY_INTERFACE_MODE_10GBASER:
>         case PHY_INTERFACE_MODE_USXGMII:
>                 if (felix_init_sxgmii(imdio, port))
> --
> 2.25.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
diff mbox series

Patch

diff --git a/drivers/net/mscc_eswitch/felix_switch.c b/drivers/net/mscc_eswitch/felix_switch.c
index bd40c3b8b1bb..47ac45b354da 100644
--- a/drivers/net/mscc_eswitch/felix_switch.c
+++ b/drivers/net/mscc_eswitch/felix_switch.c
@@ -222,7 +222,6 @@  static void felix_start_pcs(struct udevice *dev, int port,
 	case PHY_INTERFACE_MODE_QSGMII:
 		felix_init_sgmii(imdio, port, autoneg);
 		break;
-	case PHY_INTERFACE_MODE_XGMII:
 	case PHY_INTERFACE_MODE_10GBASER:
 	case PHY_INTERFACE_MODE_USXGMII:
 		if (felix_init_sxgmii(imdio, port))