Message ID | 20210908133405.696481-3-sjg@chromium.org |
---|---|
State | Changes Requested |
Delegated to: | Heinrich Schuchardt |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=oHGnt/C7; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4H4NV00N3kz9sVw for <incoming@patchwork.ozlabs.org>; Wed, 8 Sep 2021 23:37:11 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0E6F683466; Wed, 8 Sep 2021 15:35:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="oHGnt/C7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4CA37833AB; Wed, 8 Sep 2021 15:34:48 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 12DB083350 for <u-boot@lists.denx.de>; Wed, 8 Sep 2021 15:34:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-wr1-x434.google.com with SMTP id v10so3360929wrd.4 for <u-boot@lists.denx.de>; Wed, 08 Sep 2021 06:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XLUqsm3J9reoLhygIZA0J79zapaH7FstSfvOPaD1BYM=; b=oHGnt/C7CagsAXIMO6JWcRQb6pE0vXWGibn6+P8CI0HUDtzEQ7Hh/hcNY5xKm4ewFq TM/3Rpc/Cz1OFC9YnNd77r3o18zEeRvkEWnKurviEDm4W6GdEL8fLd/I8AH8LJmN4eoX agTvIUIxzNc/VqGALBy9bNQwsfgQkZNoMr2go= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XLUqsm3J9reoLhygIZA0J79zapaH7FstSfvOPaD1BYM=; b=DD2lTa7L3Xjf1/W7XT7TH7cnsmm1XxJ2R7445AbbinW//XAoCKxBdTkEpzQ/HE6GaO P6Wr3w3gc+el/a7QaWyjH0Lthr6NfYdAWzKB7+EEV7Xb6UIPnipoFvYcShJhcOJ5atj3 tKODeh8YftsKEGZXbNeHq34YhJFX5zFyDVDRArvrAB6FuI/5nVsK+oHxY3I0o1l6O+Cn CnLCYe54RPH9Q6atOvn3JA9uQaDuKVnYZJBtfuXc8dlfo67aos5kZNl0xRoMKOb8tegD eAd0NQAMdXsk23kp0yqdrDEyYW095wwxYnAH5j24gioAKr+hZou6J9uBWfiDd9+IyeWO pvFw== X-Gm-Message-State: AOAM531BBNymGIHfQgin1OIWrm64xipYF7ERvxks+uycjN3RdfZX5cAs 2SPUH99crrettA7Z4bHbWhNYZOKuit49SNwY X-Google-Smtp-Source: ABdhPJz7nxiEszlcKyvUtG+9Cx0sb3C/trEvrtSyVORe/4f2HB5WJGs7wiTFjFTVJu+Zu0zgRwZJ0w== X-Received: by 2002:a5d:4ccc:: with SMTP id c12mr4138431wrt.59.1631108078302; Wed, 08 Sep 2021 06:34:38 -0700 (PDT) Received: from sjg1.roam.corp.google.com (82-69-54-180.dsl.in-addr.zen.co.uk. [82.69.54.180]) by smtp.gmail.com with ESMTPSA id l2sm2209065wmi.1.2021.09.08.06.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 06:34:37 -0700 (PDT) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>, Heinrich Schuchardt <xypron.glpk@gmx.de>, Bin Meng <bmeng.cn@gmail.com>, Tom Rini <trini@konsulko.com>, Christian Melki <christian.melki@t2data.com>, Simon Glass <sjg@chromium.org> Subject: [PATCH 15/35] patman: Use a ValueError exception if tools.Run() fails Date: Wed, 8 Sep 2021 07:33:45 -0600 Message-Id: <20210908133405.696481-3-sjg@chromium.org> X-Mailer: git-send-email 2.33.0.153.gba50c8fa24-goog In-Reply-To: <20210908133405.696481-1-sjg@chromium.org> References: <20210908133405.696481-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean |
Series |
efi: Improvements to U-Boot running on top of UEFI
|
expand
|
diff --git a/tools/patman/tools.py b/tools/patman/tools.py index 877e37cd8da..23ddb124804 100644 --- a/tools/patman/tools.py +++ b/tools/patman/tools.py @@ -348,7 +348,7 @@ def Run(name, *args, **kwargs): result = command.RunPipe([all_args], capture=True, capture_stderr=True, env=env, raise_on_error=False, binary=binary) if result.return_code: - raise Exception("Error %d running '%s': %s" % + raise ValueError("Error %d running '%s': %s" % (result.return_code,' '.join(all_args), result.stderr)) return result.stdout
The Exception base class is a very vague and could be confusing to the test system. Use the more specific ValueError exception instead. Signed-off-by: Simon Glass <sjg@chromium.org> --- tools/patman/tools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)