diff mbox series

[v7,4/6] mtd: spi-nor-ids: Add XTX XT25F128B

Message ID 20210805162301.v7.4.I427e8f56a57233300ed93c532415a4502d2dd561@changeid
State Accepted
Commit 674a9483096148999818f336ddd2755172bfee0c
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series rockchip_sfc: add support for Rockchip SFC | expand

Commit Message

Jon Lin Aug. 5, 2021, 8:26 a.m. UTC
From: Chris Morgan <macromorgan@hotmail.com>

Adds support for XT25F128B used on Odroid Go Advance. Unfortunately
this chip uses a continuation code which I cannot seem to parse, so
there are possibly going to be collisions with chips that use the same
manufacturer/ID.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
---

Changes in v7:
- Remove SPI_NOR_HAS_TB and SPI_NOR_HAS_LOCK

 drivers/mtd/spi/Kconfig       | 6 ++++++
 drivers/mtd/spi/spi-nor-ids.c | 4 ++++
 2 files changed, 10 insertions(+)

Comments

Jagan Teki Aug. 5, 2021, 11:34 a.m. UTC | #1
On Thu, Aug 5, 2021 at 1:56 PM Jon Lin <jon.lin@rock-chips.com> wrote:
>
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Adds support for XT25F128B used on Odroid Go Advance. Unfortunately
> this chip uses a continuation code which I cannot seem to parse, so
> there are possibly going to be collisions with chips that use the same
> manufacturer/ID.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
> ---

Applied to u-boot-spi/master
Kever Yang Aug. 11, 2021, 10:19 a.m. UTC | #2
On 2021/8/5 下午4:26, Jon Lin wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Adds support for XT25F128B used on Odroid Go Advance. Unfortunately
> this chip uses a continuation code which I cannot seem to parse, so
> there are possibly going to be collisions with chips that use the same
> manufacturer/ID.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>
> Changes in v7:
> - Remove SPI_NOR_HAS_TB and SPI_NOR_HAS_LOCK
>
>   drivers/mtd/spi/Kconfig       | 6 ++++++
>   drivers/mtd/spi/spi-nor-ids.c | 4 ++++
>   2 files changed, 10 insertions(+)
>
> diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig
> index 1b2ef37e92..b2291f7290 100644
> --- a/drivers/mtd/spi/Kconfig
> +++ b/drivers/mtd/spi/Kconfig
> @@ -204,6 +204,12 @@ config SPI_FLASH_XMC
>   	  Add support for various XMC (Wuhan Xinxin Semiconductor
>   	  Manufacturing Corp.) SPI flash chips (XM25xxx)
>   
> +config SPI_FLASH_XTX
> +	bool "XTX SPI flash support"
> +	help
> +	  Add support for various XTX (XTX Technology Limited)
> +	  SPI flash chips (XT25xxx).
> +
>   endif
>   
>   config SPI_FLASH_USE_4K_SECTORS
> diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
> index cb3a08872d..4aef1ddd6e 100644
> --- a/drivers/mtd/spi/spi-nor-ids.c
> +++ b/drivers/mtd/spi/spi-nor-ids.c
> @@ -361,6 +361,10 @@ const struct flash_info spi_nor_ids[] = {
>   	{ INFO("XM25QH64A", 0x207017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>   	{ INFO("XM25QH64C", 0x204017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>   	{ INFO("XM25QH128A", 0x207018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +#endif
> +#ifdef CONFIG_SPI_FLASH_XTX
> +	/* XTX Technology (Shenzhen) Limited */
> +	{ INFO("xt25f128b", 0x0b4018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>   #endif
>   	{ },
>   };
Philipp Tomsich Aug. 11, 2021, 10:27 a.m. UTC | #3
On Thu, 5 Aug 2021 at 10:27, Jon Lin <jon.lin@rock-chips.com> wrote:
>
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Adds support for XT25F128B used on Odroid Go Advance. Unfortunately
> this chip uses a continuation code which I cannot seem to parse, so
> there are possibly going to be collisions with chips that use the same
> manufacturer/ID.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> Signed-off-by: Jon Lin <jon.lin@rock-chips.com>

Reviewed-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
diff mbox series

Patch

diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig
index 1b2ef37e92..b2291f7290 100644
--- a/drivers/mtd/spi/Kconfig
+++ b/drivers/mtd/spi/Kconfig
@@ -204,6 +204,12 @@  config SPI_FLASH_XMC
 	  Add support for various XMC (Wuhan Xinxin Semiconductor
 	  Manufacturing Corp.) SPI flash chips (XM25xxx)
 
+config SPI_FLASH_XTX
+	bool "XTX SPI flash support"
+	help
+	  Add support for various XTX (XTX Technology Limited)
+	  SPI flash chips (XT25xxx).
+
 endif
 
 config SPI_FLASH_USE_4K_SECTORS
diff --git a/drivers/mtd/spi/spi-nor-ids.c b/drivers/mtd/spi/spi-nor-ids.c
index cb3a08872d..4aef1ddd6e 100644
--- a/drivers/mtd/spi/spi-nor-ids.c
+++ b/drivers/mtd/spi/spi-nor-ids.c
@@ -361,6 +361,10 @@  const struct flash_info spi_nor_ids[] = {
 	{ INFO("XM25QH64A", 0x207017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("XM25QH64C", 0x204017, 0, 64 * 1024, 128, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 	{ INFO("XM25QH128A", 0x207018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
+#endif
+#ifdef CONFIG_SPI_FLASH_XTX
+	/* XTX Technology (Shenzhen) Limited */
+	{ INFO("xt25f128b", 0x0b4018, 0, 64 * 1024, 256, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
 #endif
 	{ },
 };