| Message ID | 20210617155729.50510-1-festevam@denx.de |
|---|---|
| State | Accepted |
| Commit | 31b3829f746770973c7425b0bdfc5e3efceb2a49 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | o4-imx-nano: Fix dtc warnings | expand |
17.06.21 18:57, Fabio Estevam пише: > Remove the LED unit addresses and reg properties to > fix the following dtc build warnings: > > arch/arm/dts/o4-imx-nano.dtb: Warning (reg_format): /leds/led@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > ... > arch/arm/dts/o4-imx-nano.dtb: Warning (avoid_default_addr_size): /leds/led@0: Relying on default #address-cells value > > Reported-by: Tom Rini <trini@konsulko.com> > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > arch/arm/dts/o4-imx-nano.dts | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/dts/o4-imx-nano.dts b/arch/arm/dts/o4-imx-nano.dts > index d1785b7dc702..54d32f9dd47b 100644 > --- a/arch/arm/dts/o4-imx-nano.dts > +++ b/arch/arm/dts/o4-imx-nano.dts > @@ -24,40 +24,34 @@ > leds { > compatible = "gpio-leds"; > > - led@0 { > + led0 { > color = <LED_COLOR_ID_RED>; > gpios = <&pcf8574a 0 GPIO_ACTIVE_LOW>; > - reg = <0>; > }; > > - led@1 { > + led1{ > color = <LED_COLOR_ID_GREEN>; > gpios = <&pcf8574a 1 GPIO_ACTIVE_LOW>; > - reg = <1>; > }; > > - led@2 { > + led2 { > gpios = <&pcf8574a 2 GPIO_ACTIVE_LOW>; > color = <LED_COLOR_ID_BLUE>; > - reg = <2>; > }; > > - led@3 { > + led3 { > color = <LED_COLOR_ID_RED>; > gpios = <&pcf8574a 3 GPIO_ACTIVE_LOW>; > - reg = <3>; > }; > > - led@4 { > + led4{ > color = <LED_COLOR_ID_GREEN>; > gpios = <&pcf8574a 4 GPIO_ACTIVE_LOW>; > - reg = <4>; > }; > > - led@5 { > + led5 { > color = <LED_COLOR_ID_BLUE>; > gpios = <&pcf8574a 5 GPIO_ACTIVE_LOW>; > - reg = <5>; > }; > }; > > Reviewed-by: Oleh Kravchenko <oleg@kaa.org.ua>
On 17.06.21 17:57, Fabio Estevam wrote: > Remove the LED unit addresses and reg properties to > fix the following dtc build warnings: > > arch/arm/dts/o4-imx-nano.dtb: Warning (reg_format): /leds/led@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) > ... > arch/arm/dts/o4-imx-nano.dtb: Warning (avoid_default_addr_size): /leds/led@0: Relying on default #address-cells value > > Reported-by: Tom Rini <trini@konsulko.com> > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- Thanks, applied to -master. Best regards, Stefano > arch/arm/dts/o4-imx-nano.dts | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/arch/arm/dts/o4-imx-nano.dts b/arch/arm/dts/o4-imx-nano.dts > index d1785b7dc702..54d32f9dd47b 100644 > --- a/arch/arm/dts/o4-imx-nano.dts > +++ b/arch/arm/dts/o4-imx-nano.dts > @@ -24,40 +24,34 @@ > leds { > compatible = "gpio-leds"; > > - led@0 { > + led0 { > color = <LED_COLOR_ID_RED>; > gpios = <&pcf8574a 0 GPIO_ACTIVE_LOW>; > - reg = <0>; > }; > > - led@1 { > + led1{ > color = <LED_COLOR_ID_GREEN>; > gpios = <&pcf8574a 1 GPIO_ACTIVE_LOW>; > - reg = <1>; > }; > > - led@2 { > + led2 { > gpios = <&pcf8574a 2 GPIO_ACTIVE_LOW>; > color = <LED_COLOR_ID_BLUE>; > - reg = <2>; > }; > > - led@3 { > + led3 { > color = <LED_COLOR_ID_RED>; > gpios = <&pcf8574a 3 GPIO_ACTIVE_LOW>; > - reg = <3>; > }; > > - led@4 { > + led4{ > color = <LED_COLOR_ID_GREEN>; > gpios = <&pcf8574a 4 GPIO_ACTIVE_LOW>; > - reg = <4>; > }; > > - led@5 { > + led5 { > color = <LED_COLOR_ID_BLUE>; > gpios = <&pcf8574a 5 GPIO_ACTIVE_LOW>; > - reg = <5>; > }; > }; > >
diff --git a/arch/arm/dts/o4-imx-nano.dts b/arch/arm/dts/o4-imx-nano.dts index d1785b7dc702..54d32f9dd47b 100644 --- a/arch/arm/dts/o4-imx-nano.dts +++ b/arch/arm/dts/o4-imx-nano.dts @@ -24,40 +24,34 @@ leds { compatible = "gpio-leds"; - led@0 { + led0 { color = <LED_COLOR_ID_RED>; gpios = <&pcf8574a 0 GPIO_ACTIVE_LOW>; - reg = <0>; }; - led@1 { + led1{ color = <LED_COLOR_ID_GREEN>; gpios = <&pcf8574a 1 GPIO_ACTIVE_LOW>; - reg = <1>; }; - led@2 { + led2 { gpios = <&pcf8574a 2 GPIO_ACTIVE_LOW>; color = <LED_COLOR_ID_BLUE>; - reg = <2>; }; - led@3 { + led3 { color = <LED_COLOR_ID_RED>; gpios = <&pcf8574a 3 GPIO_ACTIVE_LOW>; - reg = <3>; }; - led@4 { + led4{ color = <LED_COLOR_ID_GREEN>; gpios = <&pcf8574a 4 GPIO_ACTIVE_LOW>; - reg = <4>; }; - led@5 { + led5 { color = <LED_COLOR_ID_BLUE>; gpios = <&pcf8574a 5 GPIO_ACTIVE_LOW>; - reg = <5>; }; };
Remove the LED unit addresses and reg properties to fix the following dtc build warnings: arch/arm/dts/o4-imx-nano.dtb: Warning (reg_format): /leds/led@0:reg: property has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) ... arch/arm/dts/o4-imx-nano.dtb: Warning (avoid_default_addr_size): /leds/led@0: Relying on default #address-cells value Reported-by: Tom Rini <trini@konsulko.com> Signed-off-by: Fabio Estevam <festevam@denx.de> --- arch/arm/dts/o4-imx-nano.dts | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-)