diff mbox series

nvme: Correct the prps per page calculation method

Message ID 20210616032238.76916-1-wesley.sheng@amd.com
State Changes Requested
Delegated to: Tom Rini
Headers show
Series nvme: Correct the prps per page calculation method | expand

Commit Message

Wesley Sheng June 16, 2021, 3:22 a.m. UTC 
From: wesleywesley <wesleyshenggit@sina.com>

Each prp is 8 bytes, calculate the number of prps
per page should just divide page size by 8
there is no need to minus 1

Signed-off-by: wesleywesley <wesleyshenggit@sina.com>
---
 drivers/nvme/nvme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng June 18, 2021, 6 a.m. UTC | #1 
On Wed, Jun 16, 2021 at 12:09 PM Wesley Sheng <wesley.sheng@amd.com> wrote:
>
> From: wesleywesley <wesleyshenggit@sina.com>

nits: are you sure this name is correct? Should it be "Wesley Sheng"?

>
> Each prp is 8 bytes, calculate the number of prps
> per page should just divide page size by 8
> there is no need to minus 1
>
> Signed-off-by: wesleywesley <wesleyshenggit@sina.com>
> ---
>  drivers/nvme/nvme.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff mbox series

Patch

diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c
index fc64d93ab8..622bb378c0 100644
--- a/drivers/nvme/nvme.c
+++ b/drivers/nvme/nvme.c
@@ -79,7 +79,7 @@  static int nvme_setup_prps(struct nvme_dev *dev, u64 *prp2,
 	u64 *prp_pool;
 	int length = total_len;
 	int i, nprps;
-	u32 prps_per_page = (page_size >> 3) - 1;
+	u32 prps_per_page = page_size >> 3;
 	u32 num_pages;
 
 	length -= (page_size - offset);