diff mbox series

fixdep: remove leftover handling of IS_BUILTIN/IS_MODULE

Message ID 20210520103217.325117-1-rasmus.villemoes@prevas.dk
State Accepted
Commit 33b9027c4e98c9b74ee47e0f48f65b72912243dd
Delegated to: Tom Rini
Headers show
Series fixdep: remove leftover handling of IS_BUILTIN/IS_MODULE | expand

Commit Message

Rasmus Villemoes May 20, 2021, 10:32 a.m. UTC 
I removed CONFIG_IS_BUILTIN and CONFIG_IS_MODULE in commit
7d78a4547d ("linux/kconfig.h: remove unused helper macros"), but
fixdep.c still looks for those. It's harmless, but also pointless and
possibly confusing to a future reader.

Fixes: 7d78a4547d ("linux/kconfig.h: remove unused helper macros")
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
 scripts/basic/fixdep.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Tom Rini July 15, 2021, 1:27 a.m. UTC | #1 
On Thu, May 20, 2021 at 12:32:17PM +0200, Rasmus Villemoes wrote:

> I removed CONFIG_IS_BUILTIN and CONFIG_IS_MODULE in commit
> 7d78a4547d ("linux/kconfig.h: remove unused helper macros"), but
> fixdep.c still looks for those. It's harmless, but also pointless and
> possibly confusing to a future reader.
> 
> Fixes: 7d78a4547d ("linux/kconfig.h: remove unused helper macros")
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c
index 6d59cf8c07..5ced0f6b06 100644
--- a/scripts/basic/fixdep.c
+++ b/scripts/basic/fixdep.c
@@ -257,13 +257,9 @@  static void parse_config_file(const char *p)
 		/*
 		 * U-Boot also handles
 		 *   CONFIG_IS_ENABLED(...)
-		 *   CONFIG_IS_BUILTIN(...)
-		 *   CONFIG_IS_MODULE(...)
 		 *   CONFIG_VAL(...)
 		 */
 		if ((q - p == 10 && !memcmp(p, "IS_ENABLED(", 11)) ||
-		    (q - p == 10 && !memcmp(p, "IS_BUILTIN(", 11)) ||
-		    (q - p == 9 && !memcmp(p, "IS_MODULE(", 10)) ||
 		    (q - p == 3 && !memcmp(p, "VAL(", 4))) {
 			p = q + 1;
 			q = p;