diff mbox series

[v2,03/16] test: Rename final check in setexpr_test_backref()

Message ID 20210514014011.2832707-2-sjg@chromium.org
State Accepted
Commit ff0494c120be86bb442718f46eac06654d67a5bb
Delegated to: Tom Rini
Headers show
Series [v2,01/16] sandbox: net: Ensure host name is always a valid string | expand

Commit Message

Simon Glass May 14, 2021, 1:39 a.m. UTC
The bug in setexpr is fixed now, so this test can be enabled.

Reported-by: Coverity (CID: 316346)

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 test/cmd/setexpr.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Tom Rini July 16, 2021, 3:51 p.m. UTC | #1
On Thu, May 13, 2021 at 07:39:19PM -0600, Simon Glass wrote:

> The bug in setexpr is fixed now, so this test can be enabled.
> 
> Reported-by: Coverity (CID: 316346)
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/test/cmd/setexpr.c b/test/cmd/setexpr.c
index c537e893538..08b6e6e7243 100644
--- a/test/cmd/setexpr.c
+++ b/test/cmd/setexpr.c
@@ -270,8 +270,6 @@  static int setexpr_test_backref(struct unit_test_state *uts)
 	ut_asserteq_str("us this is surely! a test is it? yes us this is indeed! a test",
 			buf);
 
-	/* The following checks fail at present due to a bug in setexpr */
-	return 0;
 	for (i = BUF_SIZE; i < 0x1000; i++) {
 		ut_assertf(buf[i] == (char)i,
 			   "buf byte at %x should be %02x, got %02x)\n",