diff mbox series

[v4] efi_loader: Fix Kconfig for EFI_TCG2 protocol

Message ID 20210511114058.260933-1-ilias.apalodimas@linaro.org
State Accepted, archived
Delegated to: Heinrich Schuchardt
Headers show
Series [v4] efi_loader: Fix Kconfig for EFI_TCG2 protocol | expand

Commit Message

Ilias Apalodimas May 11, 2021, 11:40 a.m. UTC
EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms.
So select the missing SHA1, SHA256, SHA384 and SHA512 we currently support

Reported-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
changes since v3:
- add multiple select lines
changes since v2: 
- remove 'on' after select
changes since v1:
- use 'select' instead of 'depend'
 lib/efi_loader/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Heinrich Schuchardt May 11, 2021, 11:43 a.m. UTC | #1
On 11.05.21 13:40, Ilias Apalodimas wrote:
> EFI_TCG2 depends not only on TPMv2 but also on the underlying algorithms.
> So select the missing SHA1, SHA256, SHA384 and SHA512 we currently support
>
> Reported-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>

I will add the default=y when merging as discussed online.

Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

> ---
> changes since v3:
> - add multiple select lines
> changes since v2:
> - remove 'on' after select
> changes since v1:
> - use 'select' instead of 'depend'
>  lib/efi_loader/Kconfig | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 0b99d7c7749b..9a5a0334ad45 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -301,6 +301,10 @@ config EFI_RNG_PROTOCOL
>  config EFI_TCG2_PROTOCOL
>  	bool "EFI_TCG2_PROTOCOL support"
>  	depends on TPM_V2
> +	select SHA1
> +	select SHA256
> +	select SHA384
> +	select SHA512
>  	help
>  	  Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware
>  	  of the platform.
>
diff mbox series

Patch

diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index 0b99d7c7749b..9a5a0334ad45 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -301,6 +301,10 @@  config EFI_RNG_PROTOCOL
 config EFI_TCG2_PROTOCOL
 	bool "EFI_TCG2_PROTOCOL support"
 	depends on TPM_V2
+	select SHA1
+	select SHA256
+	select SHA384
+	select SHA512
 	help
 	  Provide a EFI_TCG2_PROTOCOL implementation using the TPM hardware
 	  of the platform.