From patchwork Sat May 8 22:00:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Glass X-Patchwork-Id: 1475919 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=F0JxOjBD; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fd1VR6GDMz9tlN for ; Sun, 9 May 2021 08:01:19 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0A7C382E78; Sun, 9 May 2021 00:01:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="F0JxOjBD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3635082EA6; Sun, 9 May 2021 00:00:52 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 331B382E86 for ; Sun, 9 May 2021 00:00:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-il1-x12d.google.com with SMTP id p15so10845935iln.3 for ; Sat, 08 May 2021 15:00:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qaMWGvsepxS5TiNobmK1xapfRQL9rcM0m5i6joBaaow=; b=F0JxOjBDPIRYZ5ry5YP2U0AZ/IjxgIpkuQM4WFmrZ/nXHHJ4eNtQLmHb5TQVLTNPpG BoKwkQw6NEq6HvB4K4ki/+ogjoQm99cBr3jN/PnaB8tCWSkNy3w2N9SNzDO1/BxpoJDM ifp2DkRSyEcagfcif+amZguNDePv6q5XIlKWQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qaMWGvsepxS5TiNobmK1xapfRQL9rcM0m5i6joBaaow=; b=nwiEkTssvBAcnjUOBwgogyQywf/ccsoNV9H7UvciHMPF8O7mT/rhYo4Gb3mdYXbkmF TRLvd45wZchedgB0DgLFEWmWfw25QFqafLljIl6c+pk6bVoByx/NXV5XprQ4ginZ93Av aeX64dMBARmeTWLfO8oLjcQ8bAsPXapi91QJ9yaxnHcEJ8q2mpbauEk7BMlmywtAMK4i ENpcd05s1VK5Vfkb6hRiXjOdXwQCqYqM9m/r9mRa4B0XDz2zpr6BbNvwa4EzIE0iFzOW RspnDVyplKmWSvQXgFay771lnzuVdqY5GLomJvoXAm2Z3Hxc9oo1ng1/IBZefWOmSgQD 8ZyA== X-Gm-Message-State: AOAM533yKrzvVDZ3QQZnjQ0tWdHcZ+9LaMuExkRGdflOaz/d0pYIeaEG XiPDrAibl++EXJ4uAkCTneA+4HIQUJgB34RZ X-Google-Smtp-Source: ABdhPJyUZGeg7S8gmqPXQb4prVL+m4e54rs+rWxQy5BxNx9zIxD4dykw9xIfKh8MGy8INOe6Wl44Lg== X-Received: by 2002:a05:6e02:8f0:: with SMTP id n16mr15033553ilt.7.1620511227953; Sat, 08 May 2021 15:00:27 -0700 (PDT) Received: from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id t7sm5195196ile.87.2021.05.08.15.00.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 May 2021 15:00:27 -0700 (PDT) From: Simon Glass To: U-Boot Mailing List Cc: Tom Rini , Simon Glass , Joe Hershberger , Ramon Fried Subject: [PATCH 01/17] sandbox: net: Ensure host name is always a valid string Date: Sat, 8 May 2021 16:00:05 -0600 Message-Id: <20210508220021.1778080-2-sjg@chromium.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog In-Reply-To: <20210508220021.1778080-1-sjg@chromium.org> References: <20210508220021.1778080-1-sjg@chromium.org> MIME-Version: 1.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean At present if ifname is exactly IFNAMSIZ characters then it will result in an unterminated string. Fix this by using strlcpy() instead. Reported-by: Coverity (CID: 316358) Signed-off-by: Simon Glass Acked-by: Ramon Fried --- drivers/net/sandbox-raw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sandbox-raw.c b/drivers/net/sandbox-raw.c index ce66ff781ff..99eb7a3bbff 100644 --- a/drivers/net/sandbox-raw.c +++ b/drivers/net/sandbox-raw.c @@ -161,7 +161,7 @@ static int sb_eth_raw_of_to_plat(struct udevice *dev) ifname = dev_read_string(dev, "host-raw-interface"); if (ifname) { - strncpy(priv->host_ifname, ifname, IFNAMSIZ); + strlcpy(priv->host_ifname, ifname, IFNAMSIZ); printf(": Using %s from DT\n", priv->host_ifname); } if (dev_read_u32(dev, "host-raw-interface-idx",