Message ID | 20210508220021.1778080-14-sjg@chromium.org |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show
Return-Path: <u-boot-bounces@lists.denx.de> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=Tkr4kcMG; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Fd1YS2Zmwz9tlZ for <incoming@patchwork.ozlabs.org>; Sun, 9 May 2021 08:03:56 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 89A7A82EE7; Sun, 9 May 2021 00:02:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="Tkr4kcMG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4DC5182EA1; Sun, 9 May 2021 00:01:31 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 26BB282E9F for <u-boot@lists.denx.de>; Sun, 9 May 2021 00:00:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sjg@chromium.org Received: by mail-io1-xd31.google.com with SMTP id i7so3844131ioa.12 for <u-boot@lists.denx.de>; Sat, 08 May 2021 15:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VEret+IoASl0ikHp0M4qjpOGKSTHxLoJ/LOTZGkMpuo=; b=Tkr4kcMG5nXgl23DCIf2nKWHMrDifxV8n9Vb6sEN0RdmL6bj4t33PQ5V5sOOj4QkUd TIQeqiaEnmaLvhZPerCfjZMDcykIaxb67G4PgaLAL5YHjtk3IsfF0/efrNIKZNFohwgw mo/Hei9E7IfsHz5TtdUDwvAWas9EXuOuapdhI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VEret+IoASl0ikHp0M4qjpOGKSTHxLoJ/LOTZGkMpuo=; b=qvhvpV4EAAGTH5ER8l6km0mM8f4QSHD6VEVTWalzo3IBVYKGUOWswwm07skg59xKNK gBhDuff749xJ1MViNdFPWI2IzHhobMs44fiDjaKWtzQ15EEZZWWPGkkpDAjyXaj9RLDW dxpHHGE4gcHrX05/F8bevFo4tOnN4lG8Deu/OueaJaZQKnF7ONwjPHoOl55FZH0OKrf3 OhX+CC+Q31+jOU7E5Uud26xSt3mNUfJzZ/RBHtzxvoxi1MkBnELpotuEMHrW0IDuD8cU OFOxa9nbrkCuDxpqlAKcw+G5gh6gv8C0K4hFwm8O5GXo/VmChfKB+Gzl9Hregp1i2MZY Z+PQ== X-Gm-Message-State: AOAM531vcYNsTOIS3DAWhVdooSyol8TGUgtzRR6NTYq/SguOxrVce3V+ s23e3Rs1zMChJ+uUNAdvF0cbotY0cSLTlapg X-Google-Smtp-Source: ABdhPJz4xj7tPOOw3WwbbKP4QKVz7Rwe2UrE4qNJVYR/QSoW+LyBz5H8f85AFG3ostmDFmEZzJXwzw== X-Received: by 2002:a05:6638:2044:: with SMTP id t4mr15414850jaj.12.1620511237719; Sat, 08 May 2021 15:00:37 -0700 (PDT) Received: from kiwi.bld.corp.google.com (c-67-190-101-114.hsd1.co.comcast.net. [67.190.101.114]) by smtp.gmail.com with ESMTPSA id t7sm5195196ile.87.2021.05.08.15.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 May 2021 15:00:37 -0700 (PDT) From: Simon Glass <sjg@chromium.org> To: U-Boot Mailing List <u-boot@lists.denx.de> Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>, Dario Binacchi <dariobin@libero.it>, Pratyush Yadav <p.yadav@ti.com> Subject: [PATCH 13/17] pinctrl: Avoid coverity warning when checking width Date: Sat, 8 May 2021 16:00:17 -0600 Message-Id: <20210508220021.1778080-14-sjg@chromium.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog In-Reply-To: <20210508220021.1778080-1-sjg@chromium.org> References: <20210508220021.1778080-1-sjg@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion <u-boot.lists.denx.de> List-Unsubscribe: <https://lists.denx.de/options/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=unsubscribe> List-Archive: <https://lists.denx.de/pipermail/u-boot/> List-Post: <mailto:u-boot@lists.denx.de> List-Help: <mailto:u-boot-request@lists.denx.de?subject=help> List-Subscribe: <https://lists.denx.de/listinfo/u-boot>, <mailto:u-boot-request@lists.denx.de?subject=subscribe> Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" <u-boot-bounces@lists.denx.de> X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean |
Series |
Fix various coverity warnings
|
expand
|
diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c index ebb7602dde8..8100766d44b 100644 --- a/drivers/pinctrl/pinctrl-single.c +++ b/drivers/pinctrl/pinctrl-single.c @@ -471,6 +471,7 @@ static int single_probe(struct udevice *dev) return -ENOMEM; #endif + /* coverity[DIVIDE_BY_ZERO] */ priv->npins = size / (pdata->width / BITS_PER_BYTE); if (pdata->bits_per_mux) { if (!pdata->mask) {
The width is set up in single_of_to_plat() and can only have three values, all of which result in a non-zero divisor. Add a comment to help coverity. Signed-off-by: Simon Glass <sjg@chromium.org> Reported-by: Coverity (CID: 331154) --- drivers/pinctrl/pinctrl-single.c | 1 + 1 file changed, 1 insertion(+)