| Message ID | 20210503080210.705-1-andrey.zhizhikin@leica-geosystems.com |
|---|---|
| State | Accepted |
| Commit | d9a7f1a9131372e852407e4a5c6e812ce37456e4 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | arm: imx: imx8mm: clock: make debug output more descriptive | expand |
Hi Andrey, On Mon, May 3, 2021 at 5:02 AM Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com> wrote: > > Clock initialization functionality has ambitious debug messages, which are > printed out when failures are triggered during execution: > - Separate frequency table lookup functions have the the same output that > makes it impossible to understand which function failed and produced the > output > - PLL decoding routine has a generic debug statement printed, which does > not state the actual value failed to be found > > Extend the output for both cases with prefixing table lookup functions > output with function name, and report the failed value in PLL decoding > routine. > > Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Ye Li <ye.li@nxp.com> Thanks for doing the split: Reviewed-by: Fabio Estevam <festevam@gmail.com>
> Clock initialization functionality has ambitious debug messages, which are > printed out when failures are triggered during execution: > - Separate frequency table lookup functions have the the same output that > makes it impossible to understand which function failed and produced the > output > - PLL decoding routine has a generic debug statement printed, which does > not state the actual value failed to be found > Extend the output for both cases with prefixing table lookup functions > output with function name, and report the failed value in PLL decoding > routine. > Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com> > Cc: Peng Fan <peng.fan@nxp.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Ye Li <ye.li@nxp.com> > Reviewed-by: Fabio Estevam <festevam@gmail.com> Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic
diff --git a/arch/arm/mach-imx/imx8m/clock_imx8mm.c b/arch/arm/mach-imx/imx8m/clock_imx8mm.c index 7d0f564a24..8b0c19cec8 100644 --- a/arch/arm/mach-imx/imx8m/clock_imx8mm.c +++ b/arch/arm/mach-imx/imx8m/clock_imx8mm.c @@ -72,7 +72,7 @@ static int fracpll_configure(enum pll_clocks pll, u32 freq) } if (i == ARRAY_SIZE(imx8mm_fracpll_tbl)) { - printf("No matched freq table %u\n", freq); + printf("%s: No matched freq table %u\n", __func__, freq); return -EINVAL; } @@ -148,7 +148,7 @@ void dram_enable_bypass(ulong clk_val) } if (i == ARRAY_SIZE(imx8mm_dram_bypass_tbl)) { - printf("No matched freq table %lu\n", clk_val); + printf("%s: No matched freq table %lu\n", __func__, clk_val); return; } @@ -646,7 +646,7 @@ static u32 decode_fracpll(enum clk_root_src frac_pll) pll_fdiv_ctl1 = readl(&ana_pll->video_pll1_fdiv_ctl1); break; default: - printf("Not supported\n"); + printf("Unsupported clk_root_src %d\n", frac_pll); return 0; }
Clock initialization functionality has ambitious debug messages, which are printed out when failures are triggered during execution: - Separate frequency table lookup functions have the the same output that makes it impossible to understand which function failed and produced the output - PLL decoding routine has a generic debug statement printed, which does not state the actual value failed to be found Extend the output for both cases with prefixing table lookup functions output with function name, and report the failed value in PLL decoding routine. Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com> Cc: Stefano Babic <sbabic@denx.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com> Cc: Peng Fan <peng.fan@nxp.com> Cc: Simon Glass <sjg@chromium.org> Cc: Ye Li <ye.li@nxp.com> --- arch/arm/mach-imx/imx8m/clock_imx8mm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)