| Message ID | 20210501202306.5254-2-andrey.zhizhikin@leica-geosystems.com |
|---|---|
| State | Accepted |
| Commit | 52ce6a61c1fc74b62be7f57ba83c1b43181b1f91 |
| Delegated to: | Stefano Babic |
| Headers | show |
| Series | Correct and extend distro boot support for imx8m | expand |
Hi Andrey, On Sat, May 1, 2021 at 5:24 PM Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com> wrote: > > imx8mm ekv has been switched to use distro boot commands, but had no > correct options enabled to support sysboot. > According to the README.distro, sysboot is consindered to be a > recommended way of using distro boot commands, it required default distro > features to be enabled instead of only those that are relevant to the boot > script. > > Replace the boot script specific options in the config to a default distro > option. > > Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com> > Cc: Peng Fan <peng.fan@nxp.com> > Fixes: 2df8930bf9 ("imx8mm: configs: add support for distro boot commands") Reviewed-by: Fabio Estevam <festevam@gmail.com>
Hello Stefano, I believe the following patch is missing from the series that I've submitted earlier. From the entire series named "Correct and extend distro boot support for imx8m" [1], there were 3 patches included, namely: [2] imx8mm: configs: enable distro default features [3] imx8mp: configs: enable distro default features [4] imx8mn: configs: add support for distro boot commands I see that only [4] is actually got merged, the rest 2 patches are left in "Superseded" state in Patchwork. I'm not sure what happened here, I believe that was due to the fact that the patch which targeted "imx8mn" has been updated to V2 which caused the entire series to be dropped. Should I re-submit the rest of 2 patches from the original series, or perhaps you can take them from the Patchwork directly? > -----Original Message----- > From: Fabio Estevam <festevam@gmail.com> > Sent: Sunday, May 2, 2021 12:00 AM > To: ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com> > Cc: U-Boot-Denx <u-boot@lists.denx.de>; Peng Fan <peng.fan@nxp.com> > Subject: Re: [PATCH 1/3] imx8mm: configs: enable distro default features > > Hi Andrey, > > On Sat, May 1, 2021 at 5:24 PM Andrey Zhizhikin <andrey.zhizhikin@leica- > geosystems.com> wrote: > > > > imx8mm ekv has been switched to use distro boot commands, but had no > > correct options enabled to support sysboot. > > According to the README.distro, sysboot is consindered to be a > > recommended way of using distro boot commands, it required default > > distro features to be enabled instead of only those that are relevant > > to the boot script. > > > > Replace the boot script specific options in the config to a default > > distro option. > > > > Signed-off-by: Andrey Zhizhikin > > <andrey.zhizhikin@leica-geosystems.com> > > Cc: Peng Fan <peng.fan@nxp.com> > > Fixes: 2df8930bf9 ("imx8mm: configs: add support for distro boot > > commands") > > Reviewed-by: Fabio Estevam <festevam@gmail.com> Link: [1]: http://patchwork.ozlabs.org/project/uboot/list/?series=241695 Link: [2]: http://patchwork.ozlabs.org/project/uboot/patch/20210501202306.5254-2-andrey.zhizhikin@leica-geosystems.com/ Link: [3]: http://patchwork.ozlabs.org/project/uboot/patch/20210501202306.5254-3-andrey.zhizhikin@leica-geosystems.com/ Link: [4]: http://patchwork.ozlabs.org/project/uboot/patch/20210501202306.5254-4-andrey.zhizhikin@leica-geosystems.com/ -- Andrey
Hi Andrey, On 17.06.21 18:03, ZHIZHIKIN Andrey wrote: > Hello Stefano, > > I believe the following patch is missing from the series that I've submitted earlier. > > From the entire series named "Correct and extend distro boot support for imx8m" [1], there were 3 patches included, namely: > [2] imx8mm: configs: enable distro default features > [3] imx8mp: configs: enable distro default features > [4] imx8mn: configs: add support for distro boot commands > > I see that only [4] is actually got merged, the rest 2 patches are left in "Superseded" state in Patchwork. > ..and then discharged... > I'm not sure what happened here, I have no idea, too. > I believe that was due to the fact that the patch which targeted "imx8mn" has been updated to V2 which caused the entire series to be dropped. > > Should I re-submit the rest of 2 patches from the original series, or perhaps you can take them from the Patchwork directly? I check myself, thanks for pointing out. Best regards, Stefano > >> -----Original Message----- >> From: Fabio Estevam <festevam@gmail.com> >> Sent: Sunday, May 2, 2021 12:00 AM >> To: ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com> >> Cc: U-Boot-Denx <u-boot@lists.denx.de>; Peng Fan <peng.fan@nxp.com> >> Subject: Re: [PATCH 1/3] imx8mm: configs: enable distro default features >> >> Hi Andrey, >> >> On Sat, May 1, 2021 at 5:24 PM Andrey Zhizhikin <andrey.zhizhikin@leica- >> geosystems.com> wrote: >>> >>> imx8mm ekv has been switched to use distro boot commands, but had no >>> correct options enabled to support sysboot. >>> According to the README.distro, sysboot is consindered to be a >>> recommended way of using distro boot commands, it required default >>> distro features to be enabled instead of only those that are relevant >>> to the boot script. >>> >>> Replace the boot script specific options in the config to a default >>> distro option. >>> >>> Signed-off-by: Andrey Zhizhikin >>> <andrey.zhizhikin@leica-geosystems.com> >>> Cc: Peng Fan <peng.fan@nxp.com> >>> Fixes: 2df8930bf9 ("imx8mm: configs: add support for distro boot >>> commands") >> >> Reviewed-by: Fabio Estevam <festevam@gmail.com> > > Link: [1]: http://patchwork.ozlabs.org/project/uboot/list/?series=241695 > Link: [2]: http://patchwork.ozlabs.org/project/uboot/patch/20210501202306.5254-2-andrey.zhizhikin@leica-geosystems.com/ > Link: [3]: http://patchwork.ozlabs.org/project/uboot/patch/20210501202306.5254-3-andrey.zhizhikin@leica-geosystems.com/ > Link: [4]: http://patchwork.ozlabs.org/project/uboot/patch/20210501202306.5254-4-andrey.zhizhikin@leica-geosystems.com/ > > -- Andrey >
On 17.06.21 18:03, ZHIZHIKIN Andrey wrote: > Hello Stefano, > > I believe the following patch is missing from the series that I've submitted earlier. > > From the entire series named "Correct and extend distro boot support for imx8m" [1], there were 3 patches included, namely: > [2] imx8mm: configs: enable distro default features > [3] imx8mp: configs: enable distro default features > [4] imx8mn: configs: add support for distro boot commands > > I see that only [4] is actually got merged, the rest 2 patches are left in "Superseded" state in Patchwork. > > I'm not sure what happened here, I believe that was due to the fact that the patch which targeted "imx8mn" has been updated to V2 which caused the entire series to be dropped. > > Should I re-submit the rest of 2 patches from the original series, or perhaps you can take them from the Patchwork directly? > I picked up the two missing patches, just take a look at u-boot-imx, -master. Best regards, Stefano >> -----Original Message----- >> From: Fabio Estevam <festevam@gmail.com> >> Sent: Sunday, May 2, 2021 12:00 AM >> To: ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com> >> Cc: U-Boot-Denx <u-boot@lists.denx.de>; Peng Fan <peng.fan@nxp.com> >> Subject: Re: [PATCH 1/3] imx8mm: configs: enable distro default features >> >> Hi Andrey, >> >> On Sat, May 1, 2021 at 5:24 PM Andrey Zhizhikin <andrey.zhizhikin@leica- >> geosystems.com> wrote: >>> >>> imx8mm ekv has been switched to use distro boot commands, but had no >>> correct options enabled to support sysboot. >>> According to the README.distro, sysboot is consindered to be a >>> recommended way of using distro boot commands, it required default >>> distro features to be enabled instead of only those that are relevant >>> to the boot script. >>> >>> Replace the boot script specific options in the config to a default >>> distro option. >>> >>> Signed-off-by: Andrey Zhizhikin >>> <andrey.zhizhikin@leica-geosystems.com> >>> Cc: Peng Fan <peng.fan@nxp.com> >>> Fixes: 2df8930bf9 ("imx8mm: configs: add support for distro boot >>> commands") >> >> Reviewed-by: Fabio Estevam <festevam@gmail.com> > > Link: [1]: http://patchwork.ozlabs.org/project/uboot/list/?series=241695 > Link: [2]: http://patchwork.ozlabs.org/project/uboot/patch/20210501202306.5254-2-andrey.zhizhikin@leica-geosystems.com/ > Link: [3]: http://patchwork.ozlabs.org/project/uboot/patch/20210501202306.5254-3-andrey.zhizhikin@leica-geosystems.com/ > Link: [4]: http://patchwork.ozlabs.org/project/uboot/patch/20210501202306.5254-4-andrey.zhizhikin@leica-geosystems.com/ > > -- Andrey >
Hello Stefano, > -----Original Message----- > From: Stefano Babic <sbabic@denx.de> > Sent: Monday, June 21, 2021 1:36 PM > To: ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com>; > sbabic@denx.de > Cc: U-Boot-Denx <u-boot@lists.denx.de>; Peng Fan <peng.fan@nxp.com>; > Fabio Estevam <festevam@gmail.com> > Subject: Re: [PATCH 1/3] imx8mm: configs: enable distro default features > > On 17.06.21 18:03, ZHIZHIKIN Andrey wrote: > > Hello Stefano, > > > > I believe the following patch is missing from the series that I've submitted > earlier. > > > > From the entire series named "Correct and extend distro boot support for > imx8m" [1], there were 3 patches included, namely: > > [2] imx8mm: configs: enable distro default features [3] imx8mp: > > configs: enable distro default features [4] imx8mn: configs: add > > support for distro boot commands > > > > I see that only [4] is actually got merged, the rest 2 patches are left in > "Superseded" state in Patchwork. > > > > I'm not sure what happened here, I believe that was due to the fact that the > patch which targeted "imx8mn" has been updated to V2 which caused the entire > series to be dropped. > > > > Should I re-submit the rest of 2 patches from the original series, or perhaps you > can take them from the Patchwork directly? > > > > I picked up the two missing patches, just take a look at u-boot-imx, -master. I've checked the [master] branch of u-boot-imx and I can see those two missing patches in it. This now completed the original series, thanks for taking care of this. > > Best regards, > Stefano > > -- > ============================================================== > ======= > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de > ============================================================== > ======= -- andrey
diff --git a/configs/imx8mm_evk_defconfig b/configs/imx8mm_evk_defconfig index 23741a1c8a..6a3b15389b 100644 --- a/configs/imx8mm_evk_defconfig +++ b/configs/imx8mm_evk_defconfig @@ -18,6 +18,7 @@ CONFIG_SPL_SERIAL_SUPPORT=y CONFIG_SPL_DRIVERS_MISC_SUPPORT=y CONFIG_SPL=y CONFIG_DEFAULT_DEVICE_TREE="imx8mm-evk" +CONFIG_DISTRO_DEFAULTS=y CONFIG_FIT=y CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y @@ -40,7 +41,6 @@ CONFIG_CMD_FUSE=y CONFIG_CMD_GPIO=y CONFIG_CMD_I2C=y CONFIG_CMD_MMC=y -CONFIG_CMD_PART=y CONFIG_CMD_DHCP=y CONFIG_CMD_MII=y CONFIG_CMD_PING=y @@ -50,7 +50,6 @@ CONFIG_CMD_EXT2=y CONFIG_CMD_EXT4=y CONFIG_CMD_EXT4_WRITE=y CONFIG_CMD_FAT=y -CONFIG_CMD_FS_GENERIC=y CONFIG_OF_CONTROL=y CONFIG_SPL_OF_CONTROL=y CONFIG_ENV_OVERWRITE=y
imx8mm ekv has been switched to use distro boot commands, but had no correct options enabled to support sysboot. According to the README.distro, sysboot is consindered to be a recommended way of using distro boot commands, it required default distro features to be enabled instead of only those that are relevant to the boot script. Replace the boot script specific options in the config to a default distro option. Signed-off-by: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com> Cc: Peng Fan <peng.fan@nxp.com> Fixes: 2df8930bf9 ("imx8mm: configs: add support for distro boot commands") --- configs/imx8mm_evk_defconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)