From patchwork Mon Apr 12 22:53:06 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Anderson X-Patchwork-Id: 1465501 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=85.214.62.61; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-secospa-onmicrosoft-com header.b=KG1HwDFz; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FK3tz53lCz9sVq for ; Tue, 13 Apr 2021 08:53:42 +1000 (AEST) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DCA3B80C65; Tue, 13 Apr 2021 00:53:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=secospa.onmicrosoft.com header.i=@secospa.onmicrosoft.com header.b="KG1HwDFz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1D53580C77; Tue, 13 Apr 2021 00:53:29 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,SPF_HELO_PASS autolearn=no autolearn_force=no version=3.4.2 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on0605.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::605]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8732A80C63 for ; Tue, 13 Apr 2021 00:53:25 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=seco.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sean.anderson@seco.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gxwzXaJkRX74gWFrG1zZ1B6+xUfmMp/CeNfP4OdyaGZ24d8QT2OEGf8GONiB3AaePbtxzHBgzWT2TpxFdKH7YCn5esrrs72ejGUPUHrhRnOaGqRltFBHRpD1l82si6wIRNhqU2u/zv2IqNWXeL7SLSSSlkKKBWzuBymcTgjDIKGWibPdlf6dEFbrXgXGDnNR1Pjw+RBIRn8drKJoA6DbCj8w/yiOSTeViDpitKPKQtbh241MRZBww4WJ+AYXKfJjLvRNZ1VGUCf1H3wcZGP760Dqwu9sqUh1U9cPk79b8KP6vP3ZScLVm8Vmg5q3LbKDdWxBqVo6S8zyUDLUM2PKfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OAJ+r7XVh9UZ+uXvnqXNojf/VLQmonNJX15OwGfJW+I=; b=bexMjy7JJ0oGPvP5gGovF1EzK3DEnj2U38nSwCDij22RudVry7IdRcPtxKGqaxhBhAO4KTrzyPsD9ebf9qBsC3M34uA+n4GothF6dVLmhtIgmI1k7EH78ZBu3hjkLaIh93JjRkZ+HakFbDUvsonEleQf0y5YVdZsJmkdNxZqEEYHjeYlIvk0YSj7DA4dUUXK9C4Z18Jmfdbo0uQctaRpVBdBikz0lklBD60YhCP02Pp5yIU9L5a9lVqmOK0XVx9iD4LFA6bAmD2TSYwEiVPP75bSJ1uzQ4AKk5nw3b4TfwL/vsBDs4er3wav3LHom8qcbtl8R1NlVUTXG8ezo5moaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=seco.com; dmarc=pass action=none header.from=seco.com; dkim=pass header.d=seco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secospa.onmicrosoft.com; s=selector2-secospa-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OAJ+r7XVh9UZ+uXvnqXNojf/VLQmonNJX15OwGfJW+I=; b=KG1HwDFzF0irwty5JQ9fOI85N6QbxSKbCAOFUEOhl2QQ13tLx9GpK7sEz/qd6x4/uYbkQqrpG05HbMG/w06GecZajZDZjy8R/19ZegMg0S4JqRN12CgBShKiZRwMk8TzaannfGxaQcpT2GWVUvctZGMhYJcPxvyAkhjXU1p8me8= Authentication-Results: lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=none action=none header.from=seco.com; Received: from DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) by DBBPR03MB7051.eurprd03.prod.outlook.com (2603:10a6:10:200::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.22; Mon, 12 Apr 2021 22:53:24 +0000 Received: from DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::a102:77c6:a933:8922]) by DB7PR03MB4523.eurprd03.prod.outlook.com ([fe80::a102:77c6:a933:8922%7]) with mapi id 15.20.4020.022; Mon, 12 Apr 2021 22:53:24 +0000 From: Sean Anderson To: u-boot@lists.denx.de, Tom Rini Cc: Heinrich Schuchardt , Simon Glass , Sean Anderson , Anastasiia Lukianenko , Andrii Anisov , Oleksandr Andrushchenko Subject: [PATCH v2 2/3] part: Fix bogus return from part_get_info_by_dev_and_name Date: Mon, 12 Apr 2021 18:53:06 -0400 Message-Id: <20210412225307.3217317-2-sean.anderson@seco.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210412225307.3217317-1-sean.anderson@seco.com> References: <20210412225307.3217317-1-sean.anderson@seco.com> X-Originating-IP: [50.195.82.171] X-ClientProxiedBy: BL0PR02CA0105.namprd02.prod.outlook.com (2603:10b6:208:51::46) To DB7PR03MB4523.eurprd03.prod.outlook.com (2603:10a6:10:19::27) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from plantagenet.inhand.com (50.195.82.171) by BL0PR02CA0105.namprd02.prod.outlook.com (2603:10b6:208:51::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.17 via Frontend Transport; Mon, 12 Apr 2021 22:53:23 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e774ad0f-2e9d-44d4-eb3a-08d8fe05c6fe X-MS-TrafficTypeDiagnostic: DBBPR03MB7051: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MRbv1WxCmGMRk3LiKpG4S8ZKnm1bguFcyhZ3y9BVJmv3uD/CIVjvDbr68L1XA+lAVqmNuDP70RBK5V0vSBfLh8SzARvwfzuEgsjcEsOkyybUOnovIWWGpfSVyNWqjShq+48cX4Ww7pmsn7RYN6Qg7SS3YjWI2i2acW3iavqTBmeeQRaOehxw6p/66CiAyR30COx9oR8fj6ut7XpDQl1jgDsbhRfBIqCimvWTOqMIkTmR9lUki1yk2FzKE77olJAp+znX9RmToAO18Bqp+qedgelIFFtz0ojkjlC0GoSgkiP+/cyH1KCVexrqVNLuYxbBopKFdCHvkSO/5adD8LowG8tcx/RuJRvYFdqjZ+1pNbQIef15yGpup/8LfqF2XUh9C26Yc2pmy0Jsp6NPFBOClNINe8I2X/FT/+RAccaeUzzP3dcjYVS3UIcZAE5iCFlu0ztn76emldp/lrrLv2COi9HmZ5Og8KMgd1aM7tezJO6qoOQHD+um1CMJ2TioxN8L23GkVAH9+kPVoroPK8yCAHNE86v+4GUZwoE/LFz5vOrR3/dKEwVSNCWOXOwr/i5qtJVydbKPmBwVC/XKeoOvtLxwREd76gLbGNBE7GU5Skbc9522cDba0yw3+Qn1rc0lm02l5yy80EoiYq4NMxJPkA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB7PR03MB4523.eurprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(396003)(136003)(39840400004)(346002)(366004)(956004)(54906003)(478600001)(5660300002)(66556008)(66946007)(44832011)(6916009)(2616005)(26005)(4744005)(1076003)(186003)(6512007)(86362001)(6506007)(6486002)(52116002)(16526019)(66476007)(8936002)(36756003)(6666004)(38350700002)(38100700002)(4326008)(316002)(2906002)(8676002)(83380400001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: 4W2rsxAPARbZttVhhfItTWfh0H5vMhroKN7b1TSXiYIhz1TgkVWVeZp2GuQ9JwH4PzzsFYKKQpNOfGnnWYAILPlK8eleFEURe2YURPcCUttfmvqTAdoFg5lDChMr4ih1jBIjT1Cs7Zw4hjwDzpZPO3YTcpwyFydLA6QoAfwgJWAq+meFhronpEugrnlBJRwKsGpYWUMS4SpQzhHGvKEVT9SFEkg/d4VtsSFnlDisimPAL8c/L4TpnrtkHOBPVgaqMWbxX16Q8/Sl9za8ODs4f6zP0CiFaCUJNiMW7eqo3nb0Ih2zfVUaVIJ/Jo9uR2D3/v6eF/vCASazIccCrkRa85GFPfbrRvBL4O2JrqaKQRnx4djjmWAmQNrBFo1EGOsSFZtpHATC4z5TRPM0RIezPVvaKWnzAut97cO0LgquMDTuXjPUHZCUb84PHRPcer6Uc5/mDKLXWTKP/vKYsKmKgvjtIfLSts2lPqyJS5vod/NuT3luaIhmGZZrffliC4eE8DSSY35HJltpZYcHMC1dARlFqJInJrals49gft8ImNW3zMoqjHevAmjuXGblpZD4/NK0bJjmYhfL9U7BH+/tnC2c6nHw+g7fPvPeowiZdHd7WDfBiXjQOflpCRzt+KBCvxFqYpYo8Rjy3rrp/T5k7DpIuk/CJkz8NNUFhnJGpwC1A4dgYtXq9ah5rHROW5v29ljbHP8YkLzQq+XwRD02s6n5LG6oY+KUVbCgGNcr9+rjU++sZQD0MqkS+9CGeYVBQOboeBz2vnVLzGTznxm2hnv4pCYCC8y28AuGpEk1DhGrePrxyCMpPP8cYgHAzJIR71b4O9gEkqsVKI1FrwurnZtQqkzKssc0mOFQd+j4MrK980nlbIsN309JrmK9F55/cKybG6T6BFB4snHqzuhKPJjw0Z2XcAND+mOgY2hav2bj+RptcREFdlNKAVjeYiCGiW/yIr86Lox84J8v3i9WNJCYDyK7e8ZIgCqzLy/eLcEKsZEu6dJscO99EreP8kHAfpO8izii8PaFsp75xLok5KPgrYW39Oxj947Pg+vUgDICTxcXofxv7uEqTkgcN7xNbTHqGadR96z+z637mXE7aEMg3HdldIi9OySHp2vOlubyYAuQPzv7i2gY5X3FVM33aHc9K/jxNC6e9DcWb7979qxGL/ykbPFES9pQKEEDWtNF9sjbr/99uL2nHBqh6T7vjqs3fthtsDQfEUvA29HXScoHrpVIAYCZGXvhDiTT4lSRAhVToN60I3dkw8Ej0/fZQYHWrf4vqSgeacShuEW1UQP1UwModCbCo9QRzvudH8V8oOQRf+lVAK0Gxi+hv/QI X-OriginatorOrg: seco.com X-MS-Exchange-CrossTenant-Network-Message-Id: e774ad0f-2e9d-44d4-eb3a-08d8fe05c6fe X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4523.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2021 22:53:24.3954 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qxbbHmwYuLF+NVlshR8oE2A3kpX/DLlsLsYXGGpQP4SQ1A1j9xhtsMbE/d4vhJJeAgdt07UpuaiKfuiOQQuQbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR03MB7051 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean blk_get_device_by_str returns the device number on success. So we must check if the return was negative to determine an error. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- Changes in v2: - New disk/part.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/disk/part.c b/disk/part.c index 80ced2ba88..5e7e59cf25 100644 --- a/disk/part.c +++ b/disk/part.c @@ -725,7 +725,7 @@ static int part_get_info_by_dev_and_name(const char *dev_iface, } ret = blk_get_device_by_str(dev_iface, dev_str, dev_desc); - if (ret) + if (ret < 0) goto cleanup; ret = part_get_info_by_name(*dev_desc, part_str, part_info);